style: cargo clippy

Author: carlosvdr

crates/service/src/routes/request_handler.rs

@@ -37,8 +37,7 @@ pub async fn request_handler(
 
     let attestable = response
         .headers()
-        .get(GRAPH_ATTESTABLE)
-        .map_or(false, |value| {
+        .get(GRAPH_ATTESTABLE).is_some_and(|value| {
             value.to_str().map(|value| value == "true").unwrap_or(false)
         });
 

crates/service/src/tap/checks/sender_balance_check.rs

@@ -39,8 +39,7 @@ impl Check for SenderBalanceCheck {
         // Check that the sender has a non-zero balance -- more advanced accounting is done in
         // `tap-agent`.
         if !escrow_accounts_snapshot
-            .get_balance_for_sender(receipt_sender)
-            .map_or(false, |balance| balance > U256::ZERO)
+            .get_balance_for_sender(receipt_sender).is_ok_and(|balance| balance > U256::ZERO)
         {
             return Err(CheckError::Failed(anyhow!(
                 "Receipt sender `{}` does not have a sufficient balance",

crates/tap-agent/src/agent/sender_account.rs

@@ -965,7 +965,7 @@ impl Actor for SenderAccount {
                     tracing::error!("SenderAllocation doesn't have a name");
                     return Ok(());
                 };
-                let Some(allocation_id) = allocation_id.split(':').last() else {
+                let Some(allocation_id) = allocation_id.split(':').next_back() else {
                     tracing::error!(%allocation_id, "Could not extract allocation_id from name");
                     return Ok(());
                 };
@@ -1003,7 +1003,7 @@ impl Actor for SenderAccount {
                     tracing::error!("SenderAllocation doesn't have a name");
                     return Ok(());
                 };
-                let Some(allocation_id) = allocation_id.split(':').last() else {
+                let Some(allocation_id) = allocation_id.split(':').next_back() else {
                     tracing::error!(%allocation_id, "Could not extract allocation_id from name");
                     return Ok(());
                 };

crates/tap-agent/src/agent/sender_accounts_manager.rs

@@ -243,7 +243,7 @@ impl Actor for SenderAccountsManager {
                     tracing::error!("SenderAllocation doesn't have a name");
                     return Ok(());
                 };
-                let Some(sender_id) = sender_id.split(':').last() else {
+                let Some(sender_id) = sender_id.split(':').next_back() else {
                     tracing::error!(%sender_id, "Could not extract sender_id from name");
                     return Ok(());
                 };

crates/tap-agent/src/tap/context/receipt.rs

@@ -274,14 +274,13 @@ mod test {
                 range.contains(&received_receipt.signed_receipt().message.timestamp_ns)
                     && (received_receipt.signed_receipt().message.allocation_id
                         == storage_adapter.allocation_id)
-                    && (escrow_accounts_snapshot
+                    && escrow_accounts_snapshot
                         .get_sender_for_signer(
                             &received_receipt
                                 .signed_receipt()
                                 .recover_signer(&TAP_EIP712_DOMAIN_SEPARATOR)
                                 .unwrap(),
-                        )
-                        .map_or(false, |v| v == storage_adapter.sender))
+                        ).is_ok_and(|v| v == storage_adapter.sender)
             })
             .cloned()
             .collect();
@@ -340,14 +339,13 @@ mod test {
             .filter(|(_, received_receipt)| {
                 if (received_receipt.signed_receipt().message.allocation_id
                     == storage_adapter.allocation_id)
-                    && (escrow_accounts_snapshot
+                    && escrow_accounts_snapshot
                         .get_sender_for_signer(
                             &received_receipt
                                 .signed_receipt()
                                 .recover_signer(&TAP_EIP712_DOMAIN_SEPARATOR)
                                 .unwrap(),
-                        )
-                        .map_or(false, |v| v == storage_adapter.sender))
+                        ).is_ok_and(|v| v == storage_adapter.sender)
                 {
                     !range.contains(&received_receipt.signed_receipt().message.timestamp_ns)
                 } else {

crates/tap-agent/tests/tap_agent_test.rs

@@ -168,7 +168,7 @@ async fn test_start_tap_agent(pgpool: PgPool) {
         // This would select the 3 defined allocations in order
         let allocation_selected = (i % 3) as usize;
         let receipt = create_received_receipt(
-            &allocations.get(allocation_selected).unwrap(),
+            allocations.get(allocation_selected).unwrap(),
             &TAP_SIGNER.0,
             i,
             i + 1,