refactor(logging): switch to structured tracing; fix typos and minor renames

•  Replace string-interpolated logs with structured fields (tracing) for machine-parsable, consistent logs and lower formatting overhead.
•  main, metrics, routes, service: convert logs to structured fields (error, deployment, addr, config_path, etc.); fix typo “occoured” -> “occurred”.
•  tap-agent:
•  sender_account, sender_accounts_manager, sender_allocation, metrics, tracker/, tap/: widespread conversion to structured logs; clarify messages and add useful fields (allocation_id, sender, fees, counts, channel, code, etc.).
•  Derive Debug for DenyListVersion to improve log output.
•  No functional changes intended; only logging structure, readability, and typo fixes.

Author: neithanmo

crates/monitor/src/allocations.rs

@@ -88,9 +88,9 @@ pub async fn get_allocations(
         .collect();
 
     tracing::info!(
-        "Network subgraph query returned {} allocations for indexer {}",
-        result.len(),
-        indexer_address
+        allocations = result.len(),
+        indexer_address = ?indexer_address,
+        "Network subgraph query returned allocations for indexer"
     );
 
     Ok(result)

crates/monitor/src/attestation.rs

@@ -34,7 +34,7 @@ pub fn attestation_signers(
         dispute_manager_rx,
         move |(allocation, dispute)| {
             let indexer_mnemonic = indexer_mnemonic.clone();
-            modify_sigers(
+            modify_signers(
                 &indexer_mnemonic,
                 chain_id,
                 attestation_signers_map,
@@ -44,7 +44,7 @@ pub fn attestation_signers(
         },
     )
 }
-fn modify_sigers(
+fn modify_signers(
     indexer_mnemonic: &str,
     chain_id: ChainId,
     attestation_signers_map: &'static Mutex<HashMap<Address, AttestationSigner>>,
@@ -59,30 +59,34 @@ fn modify_sigers(
     for (id, allocation) in allocations.iter() {
         if !signers.contains_key(id) {
             tracing::debug!(
-                "Attempting to create attestation signer for allocation {}, deployment {}, createdAtEpoch {}",
-                allocation.id, allocation.subgraph_deployment.id, allocation.created_at_epoch
+                allocation_id = ?allocation.id,
+                deployment_id = ?allocation.subgraph_deployment.id,
+                created_at_epoch = allocation.created_at_epoch,
+                "Attempting to create attestation signer for allocation"
             );
 
             let signer =
                 AttestationSigner::new(indexer_mnemonic, allocation, chain_id, *dispute_manager);
             match signer {
                 Ok(signer) => {
                     tracing::debug!(
-                        "Successfully created attestation signer for allocation {}",
-                        allocation.id
+                        allocation_id = ?allocation.id,
+                        "Successfully created attestation signer for allocation"
                     );
                     signers.insert(*id, signer);
                 }
                 Err(e) => {
                     tracing::warn!(
-                        "Failed to establish signer for allocation {}, deployment {}, createdAtEpoch {}: {}",
-                        allocation.id, allocation.subgraph_deployment.id,
-                        allocation.created_at_epoch, e
+                        allocation_id = ?allocation.id,
+                        deployment_id = ?allocation.subgraph_deployment.id,
+                        created_at_epoch = allocation.created_at_epoch,
+                        error = %e,
+                        "Failed to establish signer for allocation"
                     );
                     tracing::debug!(
-                        "Signer creation error details for allocation {}: {}",
-                        allocation.id,
-                        e
+                        allocation_id = ?allocation.id,
+                        error = %e,
+                        "Signer creation error details"
                     );
                 }
             }

crates/monitor/src/client/subgraph_client.rs

@@ -199,8 +199,9 @@ impl SubgraphClient {
             match local_client.query::<Q>(variables.clone()).await {
                 Ok(response) => return Ok(response),
                 Err(err) => tracing::warn!(
-                    "Failed to query local subgraph deployment `{}`, trying remote deployment next: {}",
-                    local_client.query_url, err
+                    query_url = %local_client.query_url,
+                    error = %err,
+                    "Failed to query local subgraph deployment; trying remote deployment next"
                 ),
             }
         }
@@ -211,9 +212,9 @@ impl SubgraphClient {
             .await
             .map_err(|err| {
                 tracing::warn!(
-                    "Failed to query remote subgraph deployment `{}`: {}",
-                    self.remote_client.query_url,
-                    err
+                    query_url = %self.remote_client.query_url,
+                    error = %err,
+                    "Failed to query remote subgraph deployment"
                 );
 
                 err
@@ -227,18 +228,19 @@ impl SubgraphClient {
             match local_client.query_raw(query.clone()).await {
                 Ok(response) => return Ok(response),
                 Err(err) => tracing::warn!(
-                    "Failed to query local subgraph deployment `{}`, trying remote deployment next: {}",
-                    local_client.query_url, err
+                    query_url = %local_client.query_url,
+                    error = %err,
+                    "Failed to query local subgraph deployment; trying remote deployment next"
                 ),
             }
         }
 
         // Try the remote client
         self.remote_client.query_raw(query).await.map_err(|err| {
             tracing::warn!(
-                "Failed to query remote subgraph deployment `{}`: {}",
-                self.remote_client.query_url,
-                err
+                query_url = %self.remote_client.query_url,
+                error = %err,
+                "Failed to query remote subgraph deployment"
             );
 
             err

crates/monitor/src/escrow_accounts.rs

@@ -148,9 +148,9 @@ async fn get_escrow_accounts_v2(
     reject_thawing_signers: bool,
 ) -> anyhow::Result<EscrowAccounts> {
     tracing::trace!(
-        "Loading V2 escrow accounts for indexer {}, reject_thawing_signers: {}",
-        indexer_address,
-        reject_thawing_signers
+        indexer_address = ?indexer_address,
+        reject_thawing_signers,
+        "Loading V2 escrow accounts for indexer"
     );
     // Query V2 escrow accounts from the network subgraph which tracks PaymentsEscrow
     // and GraphTallyCollector contract events.
@@ -195,9 +195,8 @@ async fn get_escrow_accounts_v2(
             )
             .unwrap_or_else(|| {
                 tracing::warn!(
-                    "Balance minus total amount thawing underflowed for V2 account {}. \
-                                 Setting balance to 0, no V2 queries will be served for this payer.",
-                    account.payer.id
+                    payer = ?account.payer.id,
+                    "Balance minus total amount thawing underflowed for V2 account; setting balance to 0, no V2 queries will be served for this payer."
                 );
                 U256::from(0)
             });
@@ -261,9 +260,8 @@ async fn get_escrow_accounts_v1(
             )
             .unwrap_or_else(|| {
                 tracing::warn!(
-                    "Balance minus total amount thawing underflowed for account {}. \
-                                 Setting balance to 0, no queries will be served for this sender.",
-                    account.sender.id
+                    sender = ?account.sender.id,
+                    "Balance minus total amount thawing underflowed for account; setting balance to 0, no queries will be served for this sender."
                 );
                 U256::from(0)
             });
@@ -291,9 +289,9 @@ async fn get_escrow_accounts_v1(
     let escrow_accounts = EscrowAccounts::new(senders_balances.clone(), senders_to_signers.clone());
 
     tracing::debug!(
-        "V1 escrow accounts loaded: {} senders, {} signer->sender mappings",
-        senders_balances.len(),
-        escrow_accounts.signers_to_senders.len()
+        senders = senders_balances.len(),
+        mappings = escrow_accounts.signers_to_senders.len(),
+        "V1 escrow accounts loaded"
     );
 
     Ok(escrow_accounts)

crates/monitor/src/horizon_detection.rs

@@ -11,6 +11,7 @@ use indexer_query::horizon_detection::{self, HorizonDetectionQuery};
 
 use crate::client::SubgraphClient;
 
+
 /// Detects if Horizon (V2) contracts are active in the network.
 ///
 /// This function queries the network subgraph to check if any PaymentsEscrow accounts exist.
@@ -34,19 +35,11 @@ pub async fn is_horizon_active(network_subgraph: &SubgraphClient) -> Result<bool
 
     let account_count = response.payments_escrow_accounts.len();
 
-    // If the query succeeds, Horizon schema is available
-    // Account count doesn't matter - the watcher will detect accounts as they appear
     if account_count > 0 {
-        tracing::info!(
-            "Horizon (V2) schema available - found {} existing PaymentsEscrow accounts",
-            account_count
-        );
+        tracing::info!(accounts = account_count, "Horizon (V2) schema available - found existing PaymentsEscrow accounts");
     } else {
-        tracing::info!(
-            "Horizon (V2) schema available - no accounts found at startup, but will detect new accounts automatically"
-        );
+        tracing::info!("Horizon (V2) schema available - no accounts found at startup, but will detect new accounts automatically");
     }
 
-    // Always return true if query succeeded (schema exists)
     Ok(true)
 }

crates/service/src/main.rs

@@ -21,13 +21,13 @@ async fn main() -> ExitCode {
         // If profiling fails, log the error
         // but continue running the application
         // as profiling is just for development.
-        tracing::error!("Failed to setup profiling: {e}");
+        tracing::error!(error = %e, "Failed to setup profiling");
     } else {
         tracing::info!("Profiling setup complete.");
     }
 
     if let Err(e) = run().await {
-        tracing::error!("Indexer service error: {e}");
+        tracing::error!(error = %e, "Indexer service error");
         return ExitCode::from(1);
     }
 

crates/service/src/metrics.rs

@@ -49,7 +49,7 @@ pub fn serve_metrics(host_and_port: SocketAddr) {
                 match encoder.encode_to_string(&metric_families) {
                     Ok(s) => (StatusCode::OK, s),
                     Err(e) => {
-                        tracing::error!("Error encoding metrics: {}", e);
+                        tracing::error!(error = %e, "Error encoding metrics");
                         (
                             StatusCode::INTERNAL_SERVER_ERROR,
                             format!("Error encoding metrics: {e}"),

crates/service/src/routes/request_handler.rs

@@ -19,7 +19,7 @@ pub async fn request_handler(
     State(state): State<GraphNodeState>,
     req: String,
 ) -> Result<impl IntoResponse, SubgraphServiceError> {
-    tracing::trace!("Handling request for deployment `{deployment}`");
+    tracing::trace!(deployment = %deployment, "Handling request for deployment");
 
     let deployment_url = state
         .graph_node_query_base_url

crates/service/src/routes/static_subgraph.rs

@@ -17,7 +17,7 @@ pub async fn static_subgraph_request_handler(
         response.status(),
         response.headers().to_owned(),
         response.text().await.inspect_err(|e| {
-            tracing::warn!("Failed to read response body: {}", e);
+            tracing::warn!(error = %e, "Failed to read response body");
         })?,
     ))
 }
@@ -42,7 +42,7 @@ impl From<&StaticSubgraphError> for StatusCode {
 
 impl IntoResponse for StaticSubgraphError {
     fn into_response(self) -> axum::response::Response {
-        tracing::error!(%self, "StaticSubgraphError occoured.");
+        tracing::error!(%self, "StaticSubgraphError occurred.");
         (
             StatusCode::from(&self),
             Json(json! {{

crates/service/src/service.rs

@@ -53,10 +53,9 @@ pub async fn run() -> anyhow::Result<()> {
     let config = Config::parse(indexer_config::ConfigPrefix::Service, cli.config.as_ref())
         .map_err(|e| {
             tracing::error!(
-                "Invalid configuration file `{}`: {}, if a value is missing you can also use \
-                --config to fill the rest of the values",
-                cli.config.unwrap_or_default().display(),
-                e
+                config_path = %cli.config.unwrap_or_default().display(),
+                error = %e,
+                "Invalid configuration file; you can use --config to fill missing values",
             );
             anyhow!(e)
         })?;
@@ -190,8 +189,8 @@ pub async fn run() -> anyhow::Result<()> {
             }
             Err(e) => {
                 tracing::error!(
-                    "Failed to initialize V2 escrow accounts: {}. Service cannot continue.",
-                    e
+                    error = %e,
+                    "Failed to initialize V2 escrow accounts; service cannot continue",
                 );
                 std::process::exit(1);
             }
@@ -352,10 +351,10 @@ pub async fn run() -> anyhow::Result<()> {
             chain_id,
         };
 
-        info!("starting dips grpc server on {}", addr);
+        info!(address = %addr, "Starting DIPS gRPC server");
 
         tokio::spawn(async move {
-            info!("starting dips grpc server on {}", addr);
+            info!(address = %addr, "Starting DIPS gRPC server");
 
             start_dips_server(addr, dips).await;
         });