Skip to content

Commit b96d348

Browse files
committed
chore: add some todo comments
Signed-off-by: Gustavo Inacio <[email protected]>
1 parent 4e0c2ad commit b96d348

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

common/src/tap/checks/value_check.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ impl MinimumValue {
5050
'cost_models_update_notify'",
5151
);
5252

53+
5354
let watcher_cancel_token = tokio_util::sync::CancellationToken::new();
5455
tokio::spawn(Self::cost_models_watcher(
5556
pgpool.clone(),
@@ -69,6 +70,8 @@ impl MinimumValue {
6970
let cache = self.cost_model_cache.read().unwrap();
7071
let models = cache.get(&agora_query.deployment_id);
7172

73+
// TODO check global cost model
74+
7275
let expected_value = models
7376
.map(|cache| {
7477
let cache = cache.read().unwrap();
@@ -193,6 +196,9 @@ impl MinimumValue {
193196
pgpool: &PgPool,
194197
cost_model_cache: CostModelMap,
195198
) -> anyhow::Result<()> {
199+
// TODO make sure to load last cost model
200+
// plus all models that were created 60 secoonds from now
201+
//
196202
let models = sqlx::query!(
197203
r#"
198204
SELECT deployment, model, variables

0 commit comments

Comments
 (0)