Skip to content

Commit d1c87d4

Browse files
committed
refactor: remove sealed
Signed-off-by: Gustavo Inacio <[email protected]>
1 parent 264b33b commit d1c87d4

File tree

3 files changed

+9
-17
lines changed

3 files changed

+9
-17
lines changed

Cargo.lock

Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/tap-agent/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ tap_aggregator.workspace = true
5151
futures = { version = "0.3.30", default-features = false }
5252
bon = "3.3"
5353
test-assets = { path = "../test-assets", optional = true }
54-
sealed = "0.6.0"
5554

5655
[dev-dependencies]
5756
# Release-please breaks with cyclical dependencies if dev-dependencies

crates/tap-agent/src/tap/context.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,12 @@ mod receipt;
2626
pub use error::AdapterError;
2727
use tonic::{transport::Channel, Code, Status};
2828

29-
#[sealed::sealed]
30-
pub trait NetworkVersion: Send + Sync + 'static {
29+
// https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed
30+
mod private {
31+
pub trait Sealed {}
32+
}
33+
34+
pub trait NetworkVersion: Send + Sync + 'static + private::Sealed {
3135
type Rav: SolStruct
3236
+ Aggregate<TapReceipt>
3337
+ Serialize
@@ -50,7 +54,9 @@ pub trait NetworkVersion: Send + Sync + 'static {
5054
pub enum Legacy {}
5155
pub enum Horizon {}
5256

53-
#[sealed::sealed]
57+
impl private::Sealed for Legacy {}
58+
impl private::Sealed for Horizon {}
59+
5460
impl NetworkVersion for Legacy {
5561
type Rav = tap_graph::ReceiptAggregateVoucher;
5662
type AggregatorClient =
@@ -84,7 +90,6 @@ impl NetworkVersion for Legacy {
8490
}
8591
}
8692

87-
#[sealed::sealed]
8893
impl NetworkVersion for Horizon {
8994
type Rav = tap_graph::v2::ReceiptAggregateVoucher;
9095
type AggregatorClient =

0 commit comments

Comments
 (0)