fix(service): tap-agent start script to use settings from .env variable and remove logging from indexer start script

Author: neithanmo

contrib/README.md

@@ -0,0 +1,119 @@
+# Developer Setup Guide
+
+This guide provides the step to set up a development workflow for the indexer-service project testing.
+Including how to build and deploy the required containers, and how to use hot-reload for faster dev iterations.
+
+### Note
+
+The current implementation leverages local-network for the common services and uses its testing configuration. We're specifically using an older [commit](https://github.com/edgeandnode/local-network/commit/ae72f1b8d57f18e7055a7fa29b873fe5bb8d9879) due to permissions issues with more recent versions, which fail when cloning the repository because of private git dependencies.
+
+## Available Commands
+
+We provide the following Make/Just commands to streamline your development workflow:
+
+- `make setup` - Full setup of all services, dependencies and binary compilation
+- `make reload` - Rebuild Rust binaries and restart services after code changes
+- `make logs` - Watch log output from all services
+- `make down` - Stop all services
+- `make test-local` - Run integration tests against local services(Work in progress)
+
+## Initial Setup
+
+To get started with development:
+
+1. Clone the repository
+2. Run the full setup to initialize all services:
+
+```bash
+make setup
+```
+
+This will:
+
+- Clone the local-network repo if needed
+- Start core infrastructure services
+- Deploy contracts and required services
+- Set up and start the indexer services
+
+## Development Workflow
+
+After the initial setup, you can use the fast development workflow:
+
+1. Make changes to the Rust code in `crates/`
+2. Run the reload command to rebuild and restart indexer and tap-agent services:
+
+```bash
+make reload
+```
+
+This workflow is much faster because:
+
+- It only recompiles the Rust code
+- It doesn't rebuild Docker containers
+- It restarts only the necessary services
+
+The `reload` command will automatically show the logs after restarting, so you can see if your changes are working properly.
+
+## How It Works
+
+The development workflow uses volume mounts to avoid rebuilding containers:
+
+1. A base Docker image with all dependencies is created once
+2. Your code is compiled locally on your machine
+3. The compiled binaries are mounted into the containers
+4. Services are restarted with the new binaries
+
+This approach avoids the time-consuming container rebuild process while still maintaining a consistent containerized environment.
+
+## Viewing Logs
+
+To monitor the services during development:
+
+```bash
+make logs
+```
+
+This will show a live stream of logs from all services, which is useful for debugging.
+
+## Running Tests
+
+To run integration tests against your local environment:
+
+```bash
+make test-local
+```
+
+This is currently a work in progress, and additional testing strategies are still being defined and implemented.
+
+## Stopping Services
+
+When you're done working:
+
+```bash
+make down
+```
+
+This will stop and remove all the containers defined in the docker-compose file.
+
+## Testing Improvements
+
+The current testing setup has some limitations that could be addressed in the future:
+
+### Current Limitations
+
+- Bash script for testing (`run-test-local.sh`) are not optimal
+- Limited test coverage of complex edge cases
+- Manual verification required for some functionality
+
+## Complete End-to-End Environment
+
+Note that the current test environment is a simplified version intended to emulate real-world operation. For a complete end-to-end testing environment, additional services are required but not currently deployed:
+
+- `tap-escrow-manager` - Manages escrow accounts for payment channels
+- `subgraph-deploy` - Handles deployment of subgraphs for testing
+
+These services are commented out in the setup script for simplicity but would be needed in a full production environment or complete integration testing setup.
+
+### Note
+
+It would be worth to keep updating local-network dependency and try to conciliate future permissions errors

contrib/indexer-service/start.sh

@@ -40,7 +40,6 @@ ESCROW_DEPLOYMENT=$(curl -s "http://graph-node:8000/subgraphs/name/semiotic/tap"
 
 stdbuf -oL echo "Escrow subgraph deployment ID: $ESCROW_DEPLOYMENT"
 stdbuf -oL echo "Using test Network subgraph deployment ID: $NETWORK_DEPLOYMENT"
-stdbuf -oL echo "Using test Escrow subgraph deployment ID: $ESCROW_DEPLOYMENT"
 stdbuf -oL echo "Using test Verifier address: $VERIFIER_ADDRESS"
 stdbuf -oL echo "Using test Indexer address: $RECEIVER_ADDRESS"
 stdbuf -oL echo "Using TAPVerifier address from contracts.json: $VERIFIER_ADDRESS"

contrib/tap-agent/start.sh

@@ -5,21 +5,10 @@ set -eu
 if [ -f /opt/.env ]; then
     echo "Sourcing environment variables from .env file"
     . /opt/.env
-else
-    echo "WARNING: .env file not found!"
-    # Set default values
-    POSTGRES="5432"
-    GRAPH_NODE_GRAPHQL="8000"
-    GRAPH_NODE_STATUS="8030"
-    INDEXER_SERVICE="7601"
-    TAP_AGGREGATOR="7610"
 fi
 
-# Override with test values taken from test-assets/src/lib.rs
-INDEXER_ADDRESS="0xd75c4dbcb215a6cf9097cfbcc70aab2596b96a9c"
-INDEXER_MNEMONIC="abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about"
-ACCOUNT0_ADDRESS="0x9858EfFD232B4033E47d90003D41EC34EcaEda94" # TAP_SENDER address
-VERIFIER_ADDRESS="0x1111111111111111111111111111111111111111"
+# Extract TAPVerifier address from contracts.json
+VERIFIER_ADDRESS=$(jq -r '."1337".TAPVerifier.address' /opt/contracts.json)
 ALLOCATION_ID="0xfa44c72b753a66591f241c7dc04e8178c30e13af" # ALLOCATION_ID_0
 
 # Wait for postgres to be ready with timeout
@@ -123,18 +112,14 @@ fi
 
 echo "Escrow subgraph deployment ID: $ESCROW_DEPLOYMENT"
 
-# Get verifier address from contracts.json
-VERIFIER_ADDRESS=$(jq -r '."1337".TAPVerifier.address' /opt/contracts.json)
-echo "Verifier address: $VERIFIER_ADDRESS"
-
 # Copy the config template
 cp /opt/config/config.toml /opt/config.toml
 
 # Replace the placeholders with actual values
 sed -i "s/NETWORK_DEPLOYMENT_PLACEHOLDER/$NETWORK_DEPLOYMENT/g" /opt/config.toml
 sed -i "s/ESCROW_DEPLOYMENT_PLACEHOLDER/$ESCROW_DEPLOYMENT/g" /opt/config.toml
 sed -i "s/VERIFIER_ADDRESS_PLACEHOLDER/$VERIFIER_ADDRESS/g" /opt/config.toml
-sed -i "s/INDEXER_ADDRESS_PLACEHOLDER/$INDEXER_ADDRESS/g" /opt/config.toml
+sed -i "s/INDEXER_ADDRESS_PLACEHOLDER/$RECEIVER_ADDRESS/g" /opt/config.toml
 sed -i "s/INDEXER_MNEMONIC_PLACEHOLDER/$INDEXER_MNEMONIC/g" /opt/config.toml
 sed -i "s/ACCOUNT0_ADDRESS_PLACEHOLDER/$ACCOUNT0_ADDRESS/g" /opt/config.toml
 sed -i "s/TAP_AGGREGATOR_PORT_PLACEHOLDER/$TAP_AGGREGATOR/g" /opt/config.toml