Skip to content

docs: update example endpoints in Readme.md and create missing endpoint #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

docs: update example endpoints in Readme.md and create missing endpoint #408

wants to merge 8 commits into from

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Oct 25, 2024 •
edited
Loading

This PR Closes #308

Changes in this PR

  • Updated the curl requests and responses in Readme.md file
  • Added a missing supported field blockHashFromNumber for indexingStatus
  • Added a route /subgraph/health/<deployment-id> to check the health of subgraphs from local graph-node

@shiyasmohd shiyasmohd changed the title Update example endpoints in Readme.md and add missing endpoint Update example endpoints in Readme.md and create missing endpoint Oct 25, 2024
@coveralls
Copy link

coveralls commented Oct 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11518748754

Details

  • 0 of 57 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 72.069%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/indexer_service/http/indexer_service.rs 0 5 0.0%
common/src/indexer_service/http/health.rs 0 52 0.0%
Totals Coverage Status
Change from base Build 11518141737: -0.6%
Covered Lines: 5003
Relevant Lines: 6942
💛 - Coveralls

@shiyasmohd shiyasmohd changed the title Update example endpoints in Readme.md and create missing endpoint docs: update example endpoints in Readme.md and create missing endpoint Oct 25, 2024
@shiyasmohd shiyasmohd self-assigned this Oct 26, 2024
gusinacio
gusinacio suggested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is two different PRs:

  • feat: add health endpoint
  • docs: update examples

Could you split it in two so we have them nicely within release-please

@shiyasmohd
Copy link
Contributor Author

shiyasmohd commented Oct 29, 2024

Sure, I'll split this into 2 PRs

@shiyasmohd shiyasmohd closed this Oct 29, 2024
@shiyasmohd shiyasmohd mentioned this pull request Nov 3, 2024
Merged
@suchapalaver suchapalaver deleted the shiyasmohd/update-example-test-endpoints branch May 8, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shiyasmohd shiyasmohd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected results in testing example endpoint requests from readme.md

4 participants

@shiyasmohd @coveralls @gusinacio