Skip to content

Conversation

@gusinacio
Copy link
Contributor

Signed-off-by: Gustavo Inacio [email protected]Signed-off-by: Gustavo Inacio [email protected]

@gusinacio gusinacio force-pushed the gustavo/tap-307-create-middleware-for-auth branch 8 times, most recently from 72ead8e to b113495 Compare November 21, 2024 18:45
@gusinacio gusinacio force-pushed the gustavo/tap-306-create-middleware-for-metrics branch 2 times, most recently from d9610c8 to 1e6ad79 Compare November 22, 2024 00:12
@gusinacio gusinacio force-pushed the gustavo/tap-307-create-middleware-for-auth branch 3 times, most recently from 4b6f009 to 95be49d Compare November 22, 2024 00:21
@gusinacio gusinacio force-pushed the gustavo/tap-306-create-middleware-for-metrics branch from 1e6ad79 to 73bfe0d Compare November 22, 2024 00:22
@gusinacio gusinacio force-pushed the gustavo/tap-307-create-middleware-for-auth branch from 95be49d to 1cb7399 Compare November 22, 2024 00:42
Base automatically changed from gustavo/tap-306-create-middleware-for-metrics to main November 22, 2024 00:43
@gusinacio gusinacio force-pushed the gustavo/tap-307-create-middleware-for-auth branch from 1cb7399 to fecfc0b Compare November 22, 2024 00:43
@gusinacio gusinacio marked this pull request as ready for review November 22, 2024 01:01
@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 11979175958

Details

  • 276 of 312 (88.46%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.2%) to 76.143%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/service/src/routes/request_handler.rs 0 1 0.0%
crates/service/src/service.rs 0 2 0.0%
crates/service/src/error.rs 2 5 40.0%
crates/service/src/middleware/inject_context.rs 66 69 95.65%
crates/service/src/middleware/auth/bearer.rs 24 29 82.76%
crates/service/src/service/indexer_service.rs 0 22 0.0%
Totals Coverage Status
Change from base Build 11964248997: 2.2%
Covered Lines: 6364
Relevant Lines: 8358

💛 - Coveralls

@gusinacio gusinacio requested a review from anirudh2 November 22, 2024 19:43
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the gustavo/tap-307-create-middleware-for-auth branch from 200776a to f805565 Compare November 22, 2024 19:50
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All things addressed! Thanks!

@gusinacio gusinacio merged commit e481f7f into main Nov 22, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-307-create-middleware-for-auth branch November 22, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants