Skip to content

ci: fix cyclical dependency in release-please #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

ci: fix cyclical dependency in release-please #591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c074fdb
ci: fix cyclical dependency in release-please
gusinacio Jan 27, 2025
4364de3
chore: add comment about release-please trick
gusinacio Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions crates/tap-agent/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ lazy_static.workspace = true
thegraph-core.workspace = true
clap.workspace = true
tracing-subscriber.workspace = true
tonic.workspace = true
tonic.workspace = true
bigdecimal = { workspace = true, features = ["serde"] }
graphql_client.workspace = true

Expand All @@ -49,14 +49,17 @@ ractor = { version = "0.14", features = [
tap_aggregator.workspace = true
futures = { version = "0.3.30", default-features = false }
bon = "3.3"
test-assets = { path = "../test-assets" , optional=true}
test-assets = { path = "../test-assets", optional = true }

[dev-dependencies]
# Release-please breaks with cyclical dependencies if dev-dependencies
# import the current crate. For testing we import the current crate with the `test`
# feature enabled in order to enable test-only infrastructure within our app when running tests.
my-crate = { package = "indexer-tap-agent", path = ".", features = ["test"] }
tempfile = "3.8.0"
wiremock.workspace = true
wiremock-grpc = "0.0.3-alpha3"
test-assets = { path = "../test-assets" }
test-log = { version = "0.2.12", default-features = false }
bon = "3.3"
rstest = "0.24.0"
indexer-tap-agent = { path = ".", features = ["test"] }
Loading