refactor: changes to dips to better support payment collection in indexer-agent #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pull Request Test Coverage Report for Build 13208353292Details
💛 - Coveralls |
pcarranzav
force-pushed
the
pcv/dips-collection
branch
2 times, most recently
from
d8b88eb to
cfb8358
Compare
pcarranzav
changed the title
pcarranzav
force-pushed
the
pcv/dips-collection
branch
2 times, most recently
from
8b139f7 to
845f6f3
Compare
pcarranzav
force-pushed
the
pcv/dips-collection
branch
from
845f6f3 to
ecd0185
Compare
LNSD
previously approved these changes
Feb 12, 2025
| package graphprotocol.indexer.dips; | ||
|
|
||
| service DipsService { | ||
| service IndexerDipsService { |
Contributor
There was a problem hiding this comment.
I would suggest naming it GatewayDipsService.
Suggested change
| service IndexerDipsService { | |
| service GatewayDipsService { |
I want to rename the "Dipper" to DIPs Gateway at some point in the future.
Member
Author
There was a problem hiding this comment.
I imagine you mean in DipperService, rather than here, right?
gusinacio
reviewed
Feb 12, 2025
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| pub mod cost_model; | ||
| pub mod dips; |
Contributor
There was a problem hiding this comment.
You removed dips from the modules but didn't remove dips.rs file. Is there any reason?
Member
Author
There was a problem hiding this comment.
I moved it to database.rs on the dips crate, so it shows in git as moved rather than removed
Contributor
There was a problem hiding this comment.
You are right! Github tricked me
pcarranzav
force-pushed
the
pcv/dips-collection
branch
from
ecd0185 to
fa1c479
Compare
gusinacio
approved these changes
Feb 12, 2025
Contributor
gusinacio
left a comment
gusinacio
left a comment
There was a problem hiding this comment.
This PR affects directly DIPs with no changes in the rest of the application. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.