refactor: implement receipt traits for horizon #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusinacio
force-pushed
the
gustavo/impl-tap-manager-traits
branch
3 times, most recently
from
f779ee3 to
b76373c
Compare
Pull Request Test Coverage Report for Build 13246907631Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
suchapalaver
requested changes
Feb 10, 2025
Collaborator
suchapalaver
left a comment
suchapalaver
left a comment
There was a problem hiding this comment.
@gusinacio thanks! Let me know if you want to chat about the trait that looks like a static function. I wonder if breaking this PR up into its increments might help get all the intentions 🙏
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/impl-tap-manager-traits
branch
from
0a49cd2 to
f98ceaa
Compare
suchapalaver
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.