Skip to content

test: fix nextest flaky test #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

test: fix nextest flaky test #623

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c205c0b
test: fix nextest flaky test
gusinacio Feb 11, 2025
3354e35
Merge branch 'main' into gustavo/fix-nextest
gusinacio Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...f5748c361f3d4c4136b8d5b3a3c3af5fcc9e.json → ...469cd7bc10a39e7c94f2b3d57946e4a060ff.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 23 additions & 11 deletions crates/tap-agent/tests/sender_account_manager_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ use indexer_tap_agent::{
create_received_receipt, create_sender_accounts_manager, store_receipt, ALLOCATION_ID_0,
},
};
use ractor::ActorRef;
use ractor::{ActorRef, ActorStatus};
use serde_json::json;
use sqlx::PgPool;
use test_assets::{flush_messages, TAP_SENDER as SENDER, TAP_SIGNER as SIGNER};
use test_assets::{assert_while_retry, flush_messages, TAP_SENDER as SENDER, TAP_SIGNER as SIGNER};
use wiremock::{
matchers::{body_string_contains, method},
Mock, MockServer, ResponseTemplate,
Expand Down Expand Up @@ -74,17 +74,17 @@ async fn sender_account_manager_layer_test(pgpool: PgPool) {
flush_messages(&notify).await;

// verify if create sender account
let actor_ref =
let sender_account_ref =
ActorRef::<SenderAccountMessage>::where_is(format!("{}:{}", prefix.clone(), SENDER.1));
assert!(actor_ref.is_some());
assert!(sender_account_ref.is_some());

let receipt = create_received_receipt(&ALLOCATION_ID_0, &SIGNER.0, 1, 1, TRIGGER_VALUE - 10);
store_receipt(&pgpool, receipt.signed_receipt())
.await
.unwrap();

// we expect it to create a sender allocation
actor_ref
sender_account_ref
.clone()
.unwrap()
.cast(SenderAccountMessage::UpdateAllocationIds(
Expand All @@ -93,15 +93,28 @@ async fn sender_account_manager_layer_test(pgpool: PgPool) {
.collect(),
))
.unwrap();
flush_messages(&notify).await;

assert_while_retry!({
ActorRef::<SenderAllocationMessage>::where_is(format!(
"{}:{}:{}",
prefix, SENDER.1, ALLOCATION_ID_0,
))
.is_none()
});
let allocation_ref = ActorRef::<SenderAllocationMessage>::where_is(format!(
"{}:{}:{}",
prefix, SENDER.1, ALLOCATION_ID_0,
))
.unwrap();

// try to delete sender allocation_id
actor_ref
sender_account_ref
.clone()
.unwrap()
.cast(SenderAccountMessage::UpdateAllocationIds(HashSet::new()))
.unwrap();
flush_messages(&notify).await;
allocation_ref.wait(None).await.unwrap();
assert_eq!(allocation_ref.get_status(), ActorStatus::Stopped);

assert!(ActorRef::<SenderAllocationMessage>::where_is(format!(
"{}:{}:{}",
Expand All @@ -116,15 +129,14 @@ async fn sender_account_manager_layer_test(pgpool: PgPool) {
))
.unwrap();

flush_messages(&notify).await;
sender_account_ref.unwrap().wait(None).await.unwrap();
// verify if it gets removed
let actor_ref = ActorRef::<SenderAccountMessage>::where_is(format!("{}:{}", prefix, SENDER.1));
assert!(actor_ref.is_none());

//verify the rav is marked as last
let rav_marked_as_last = sqlx::query!(
r#"
SELECT * FROM scalar_tap_ravs WHERE last = true;
SELECT * FROM scalar_tap_ravs WHERE last;
"#,
)
.fetch_all(&pgpool)
Expand Down
Loading