Skip to content

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Feb 12, 2025

  • Add denylist table.
  • Filling the blanks where unimplemented!()

Copy link
Collaborator

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13295182357

Details

  • 8 of 52 (15.38%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 76.729%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/agent/sender_account.rs 8 52 15.38%
Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/agent/sender_account.rs 10 74.52%
Totals Coverage Status
Change from base Build 13293962248: -0.4%
Covered Lines: 8131
Relevant Lines: 10597

💛 - Coveralls

@gusinacio gusinacio enabled auto-merge (squash) February 13, 2025 14:20
@gusinacio gusinacio disabled auto-merge February 13, 2025 15:48
@gusinacio gusinacio merged commit 1e255e8 into main Feb 13, 2025
9 of 10 checks passed
@gusinacio gusinacio deleted the gustavo/v2-deny branch February 13, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants