Skip to content

refactor: listen to v2 receipts #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

refactor: listen to v2 receipts #628

merged 1 commit into from
Feb 13, 2025

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Feb 12, 2025 •
edited
Loading

  • Enable listening to horizon receipts, they should have the same structure since receipts are minimal and we don't need to carry all fields.

BEGIN_COMMIT_OVERRIDE
fix: send allocation creation message to correct sender account
END_COMMIT_OVERRIDE

@gusinacio gusinacio force-pushed the gustavo/listen-to-new-receipts branch from 5375b8d to 6c37d94 Compare February 12, 2025 21:51
@gusinacio gusinacio marked this pull request as ready for review February 12, 2025 21:51
@gusinacio gusinacio force-pushed the gustavo/listen-to-new-receipts branch from 6c37d94 to e0dff31 Compare February 12, 2025 22:00
suchapalaver
suchapalaver previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

carlosvdr
carlosvdr previously approved these changes Feb 13, 2025
View reviewed changes
@coveralls
Copy link

coveralls commented Feb 13, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13295700102

Details

  • 56 of 59 (94.92%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 77.146%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/agent/sender_accounts_manager.rs 56 59 94.92%
Files with Coverage Reduction New Missed Lines %
crates/service/src/tap/checks/deny_list_check.rs 1 95.2%
Totals Coverage Status
Change from base Build 13293962248: 0.07%
Covered Lines: 8169
Relevant Lines: 10589
💛 - Coveralls

@gusinacio
refactor: listen to v2 receipts
37b1bbd 
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio dismissed stale reviews from carlosvdr and suchapalaver via 37b1bbd February 13, 2025 15:51
@gusinacio gusinacio force-pushed the gustavo/listen-to-new-receipts branch from e0dff31 to 37b1bbd Compare February 13, 2025 15:51
suchapalaver
suchapalaver approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio enabled auto-merge (squash) February 13, 2025 15:59
@gusinacio gusinacio disabled auto-merge February 13, 2025 16:33
@gusinacio gusinacio merged commit 387d660 into main Feb 13, 2025
9 of 10 checks passed
@gusinacio gusinacio deleted the gustavo/listen-to-new-receipts branch February 13, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suchapalaver suchapalaver suchapalaver approved these changes

@carlosvdr carlosvdr Awaiting requested review from carlosvdr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gusinacio @coveralls @suchapalaver @carlosvdr