Skip to content

Conversation

@LNSD
Copy link
Contributor

@LNSD LNSD commented Mar 25, 2025

This pull request includes several changes to the crates/dips module, focusing on adding a protocol version constant, fixing a typo, improving error handling, and refactoring code for better maintainability. Below are the most significant changes:

  • Added a new constant PROTOCOL_VERSION to define the protocol version as 1 in crates/dips/src/lib.rs.
  • Enhanced the From<DipsError> implementation for tonic::Status to provide more detailed error messages by formatting the error value in crates/dips/src/lib.rs.

@LNSD LNSD requested review from mangas and pcarranzav March 25, 2025 09:42
@LNSD LNSD self-assigned this Mar 25, 2025
@coveralls
Copy link

coveralls commented Mar 25, 2025

Pull Request Test Coverage Report for Build 14056796261

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 76.265%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/dips/src/lib.rs 0 2 0.0%
crates/dips/src/server.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
crates/dips/src/lib.rs 1 93.71%
crates/watcher/src/lib.rs 4 92.71%
Totals Coverage Status
Change from base Build 14048151176: -0.03%
Covered Lines: 8711
Relevant Lines: 11422

💛 - Coveralls

@LNSD LNSD force-pushed the lnsd/feat-dips-error-reporting branch from 9d33490 to c1b62d5 Compare March 25, 2025 10:01
@LNSD LNSD merged commit 1dc2a79 into main Mar 25, 2025
10 checks passed
@LNSD LNSD deleted the lnsd/feat-dips-error-reporting branch March 25, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants