Skip to content

fix(dips): deserialize dips message signature from bytes #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix(dips): deserialize dips message signature from bytes #666

merged 1 commit into from
Mar 25, 2025

Conversation

@LNSD
Copy link
Contributor

@LNSD LNSD commented Mar 25, 2025 •
edited
Loading

This pull request includes changes to the Cargo.toml and lib.rs files in the crates/dips directory.

  • crates/dips/src/lib.rs: Refactored the signature handling in the SignedIndexingAgreementVoucher implementation to use Signature::try_from to fix the signature deserialization bug.

@LNSD LNSD requested review from mangas and pcarranzav March 25, 2025 12:23
@LNSD LNSD self-assigned this Mar 25, 2025
@LNSD LNSD marked this pull request as draft March 25, 2025 12:27
@LNSD LNSD marked this pull request as ready for review March 25, 2025 12:49
neithanmo
neithanmo requested changes Mar 25, 2025
View reviewed changes
@LNSD LNSD force-pushed the lnsd/fix-dips-signature-deserialization branch from 36e8c7f to a2d6d92 Compare March 25, 2025 16:27
@LNSD LNSD requested a review from neithanmo March 25, 2025 16:28
@LNSD LNSD force-pushed the lnsd/fix-dips-signature-deserialization branch from a2d6d92 to 6c01c03 Compare March 25, 2025 16:29
@LNSD LNSD removed the request for review from neithanmo March 25, 2025 16:31
@LNSD LNSD enabled auto-merge (squash) March 25, 2025 16:33
@coveralls
Copy link

coveralls commented Mar 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14065029783

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.267%
Totals Coverage Status
Change from base Build 14063520763: 0.0%
Covered Lines: 8715
Relevant Lines: 11427
💛 - Coveralls

@LNSD LNSD requested a review from neithanmo March 25, 2025 16:35
@LNSD LNSD merged commit c94e355 into main Mar 25, 2025
10 checks passed
@LNSD LNSD deleted the lnsd/fix-dips-signature-deserialization branch March 25, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcarranzav pcarranzav pcarranzav approved these changes

@neithanmo neithanmo neithanmo approved these changes

@mangas mangas Awaiting requested review from mangas

Assignees

@LNSD LNSD

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LNSD @coveralls @pcarranzav @neithanmo