Fix/v2 crash #685
Merged
Fix/v2 crash #685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a `horizon_enabled` boolean flag within `SenderAccountConfig`, populated from the main application configuration (`config.horizon.enabled`).
This flag gates Horizon-specific functionality within the TAP agent:
- In `SenderAccount`:
- Database operations (fetching RAVs, querying/updating denylist) for `SenderType::Horizon` are now conditional on this flag being true.
- The `todo!()` for querying unfinalized V2 transactions is now only relevant if Horizon is enabled.
- A temporary check (`FIXME`) is added to `deny_sender_if_insolvent` to bypass denial logic for Horizon senders if the feature is disabled via config.
- In `SenderAccountsManager`:
- Fetching pending V2 (Horizon) sender allocations is skipped if the flag is false.
- The `new_receipts_watcher` task for V2/Horizon is only spawned if the flag is true.
This allows Horizon-related features, which may still be under development, to be effectively disabled via configuration, simplifying testing and allowing for incremental rollout without impacting existing functionality if Horizon support is not desired or ready.
fix(config): add missing config field
Pull Request Test Coverage Report for Build 14360847977Details
💛 - Coveralls |
|
i run the test locally and renames the test function to make it clear that the rav being tested is V1. We need for sure to enable this local testnet integration test in our CI |
suchapalaver
approved these changes
Apr 9, 2025
TypeLevelConsoli
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a feature flag mechanism for Horizon support to prevent crashes. Key changes:
horizon.enabled = falseconfiguration option in all relevant config filesThis change allows systems to run without Horizon support until full implementation is complete. The flag is set to false by default for safety.