Add Profiling Support for Indexer/tap-agent services #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neithanmo
force-pushed
the
feat/profiling
branch
from
10cd7e9 to
263bc0c
Compare
Pull Request Test Coverage Report for Build 14718771698Details
💛 - Coveralls |
neithanmo
changed the title
neithanmo
force-pushed
the
feat/profiling
branch
from
7b4f00d to
7e08186
Compare
…al tools - Embedded continuous profiling using pprof in Rust code - External tools: flamegraph, valgrind, callgrind, strace - Docker support for all profiling methods - Just commands for easy profiling management Flamegraphs and profiles are saved to contrib/profiling/output.
Move duplicated profiling functionality from multiple crates into a single shared 'profiler' crate. Key changes: - Create new 'profiler' crate with optimized implementation - Use AtomicU64 instead of Mutex for snapshot counter - Add proper error handling with thiserror - Ensure proper directory structure for profiling output - Make profiling opt-in via a feature flag
neithanmo
force-pushed
the
feat/profiling
branch
from
7e08186 to
539e52d
Compare
suchapalaver
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive profiling support for the indexer service to help identify performance bottlenecks.
Changes
profilingWhy embedded profiler
as a result, embedding the profiler was the best option and it worked out of the box
Note
Profiler is disabled even during testing(unit and integration rust tests), because of a weird timing issue, it seems that spawning and setting up profiling threads caused issues with the
test_thawing_deposit_processtest. But this is still useful for end to end testing where it works just fine without huge side effects(as long as tests take into account the delay caused by the profiler during service startup).Next step is to prepare a test to run services under heavy load and see how they behave and look for possible bottlenecks.