Skip to content

Conversation

@neithanmo
Copy link
Collaborator

@neithanmo neithanmo commented May 10, 2025

This changes:

  • updates local network to latest release
  • Use Oneshot channels to ensure any database error is sent back to the caller(duplicated receipts by design do not trigger any error as database table allows that)
  • Update unit-test code accordingly to change above
  • Add an integration test that sends receipts directly to indexer to check that malformed receipts trigger errors
  • some minor refactors in the integration tests and helper function.

@coveralls
Copy link

coveralls commented May 10, 2025

Pull Request Test Coverage Report for Build 15004314170

Details

  • 51 of 158 (32.28%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 73.038%

Changes Missing Coverage Covered Lines Changed/Added Lines %
integration-tests/src/main.rs 0 1 0.0%
crates/service/src/tap/receipt_store.rs 51 53 96.23%
integration-tests/src/rav_tests.rs 0 37 0.0%
integration-tests/src/utils.rs 0 67 0.0%
Totals Coverage Status
Change from base Build 14970336708: -0.02%
Covered Lines: 8812
Relevant Lines: 12065

💛 - Coveralls

@neithanmo neithanmo force-pushed the fix/propagate_error branch from 72cd6b7 to 8d364fb Compare May 13, 2025 01:23
@neithanmo neithanmo marked this pull request as ready for review May 13, 2025 01:23
Copy link
Collaborator

@TypeLevelConsoli TypeLevelConsoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for this!
There is a small typo in the Copyright comment

@neithanmo neithanmo merged commit 0e85079 into main May 14, 2025
10 checks passed
@neithanmo neithanmo deleted the fix/propagate_error branch May 14, 2025 12:39
This was referenced May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants