fix: only mark as paid if really paid

Author: pcarranzav

packages/indexer-common/src/indexing-fees/dips.ts

@@ -97,12 +97,7 @@ export class DipsManager {
       },
     })
     for (const agreement of outstandingAgreements) {
-      if (agreement.last_allocation_id) {
-        await this.tryCollectPayment(agreement)
-      } else {
-        // This should never happen as we check for this in the query
-        this.logger.error(`Agreement ${agreement.id} has no last allocation id`)
-      }
+      await this.tryCollectPayment(agreement)
     }
   }
   async tryCollectPayment(agreement: IndexingAgreement) {
@@ -145,28 +140,25 @@ export class DipsManager {
           )
         }
         await this.network.queryFeeModels.scalarTapReceipts.create(tapReceipt)
+        // Mark the agreement as having had a payment collected
+        await this.models.IndexingAgreement.update(
+          {
+            last_payment_collected_at: new Date(),
+          },
+          {
+            where: {
+              id: agreement.id,
+            },
+          },
+        )
       } else {
-        this.logger.error(`Error collecting payment for agreement ${agreement.id}`, {
-          error: response.status,
-        })
+        throw new Error(`Payment request not accepted: ${response.status}`)
       }
     } catch (error) {
       this.logger.error(`Error collecting payment for agreement ${agreement.id}`, {
         error,
       })
     }
-
-    // Mark the agreement as having had a payment collected
-    await this.models.IndexingAgreement.update(
-      {
-        last_payment_collected_at: new Date(),
-      },
-      {
-        where: {
-          id: agreement.id,
-        },
-      },
-    )
   }
   async ensureAgreementRules() {
     if (!this.parent) {