feat: Add clickable transaction links and Python style guidelines (#15)

* feat: Add clickable transaction links to Slack notifications

- Enhanced Slack notifications to show clickable transaction hashes
- Modified blockchain_client to return full block explorer URLs instead of raw hashes
- Updated both success and failure notifications with defensive error handling
- Added production-ready error handling for transaction link formatting

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* docs: Add Python style guidelines and integrate with Claude

- Created comprehensive Python style guidelines document (STYLE_GUIDELINES.md)
- Defined 9 core style principles for consistent code formatting
- Integrated style guidelines into CLAUDE.md for AI coding consistency
- Added guidance for comment placement, spacing, and function separation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* style: Fix linting issues and apply code formatting

- Fix line length violations in slack_notifier.py comments
- Apply automated formatting via ruff and custom formatter
- Ensure all code passes CI linting requirements

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* test: Update Slack notification test for clickable link format

- Fix test expectation to match new clickable link format: <url|hash>
- Add style guideline for compressing long comments vs truncating

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>

Author: MoonBoi9001

CLAUDE.md

@@ -173,3 +173,6 @@ The system follows a clear data pipeline with daily scheduled execution:
 
 # Session Context Import
 @./SESSION_CONTEXT.md
+
+# Style Guidelines Import
+@./STYLE_GUIDELINES.md

STYLE_GUIDELINES.md

@@ -0,0 +1,47 @@
+# Python Style Guidelines
+
+This document defines the coding style guidelines for Python code in this repository. These guidelines should be followed to maintain consistency and readability across the codebase.
+
+## Core Style Guidelines
+
+### 1. Comments Before Logical Blocks
+Add descriptive comments above logical blocks when the purpose needs clarification or when explaining complex operations and error handling.
+
+### 2. Blank Lines Before Comments (Except After Docstrings)
+Include a blank line before each comment that is before a logical block, except when the comment directly follows a function's docstring.
+
+### 3. Blank Lines After Logical Sections Complete
+After a logical block completes (end of loops, after appending to lists, etc.), include a blank line before the next comment/section. This helps improve readability of the code.
+
+### 4. Comments Describe "What" Not "How"
+Comments should describe what the code accomplishes rather than implementation details.
+
+### 5. Spacing Within Control Structures
+Inside try/except blocks and if/else statements, include a blank line after each branch's code block completes.
+
+### 6. Comments for Primary and Fallback Logic
+Both the main execution path and fallback/error handling should have descriptive comments when their purpose isn't immediately self-evident.
+
+### 7. Comments for Final Actions
+Simple operations at the end of functions should have descriptive comments when the purpose needs clarification.
+
+### 8. Two Blank Lines Between Functions/Methods/Classes
+Two blank lines before all function/method/class definitions, whether top-level or nested.
+
+### 9. Compress long comments, don't truncate
+When comments exceed the 115-character line limit, compress them by removing unnecessary articles and prepositions while preserving full meaning, rather than truncating important information.
+
+### 10. Code clarity not guideline following perfection
+The code is more important than the style guidelines
+
+## Integration with Code Formatting Tools
+
+These style guidelines work in conjunction with automated formatting tools:
+
+- **Ruff**: Handles basic formatting, import sorting, and linting
+- **Custom formatter**: Applies additional spacing rules via `scripts/ruff_check_format_assets.sh`
+
+Always run the formatting script before committing:
+```bash
+./scripts/ruff_check_format_assets.sh
+```

src/models/blockchain_client.py

@@ -632,7 +632,8 @@ def batch_allow_indexers_issuance_eligibility(
                     data_bytes,
                 )
                 tx_hash = "0x" + tx_hash
-                transaction_hashes.append(tx_hash)
+                tx_url = f"{self.block_explorer_url}/tx/{tx_hash}"
+                transaction_hashes.append(tx_url)
                 logger.info(f"Successfully sent batch {i // batch_size + 1}, tx_hash: {tx_hash}")
 
             except Exception as e:

src/utils/slack_notifier.py

@@ -130,8 +130,26 @@ def send_success_notification(
 
         # Add transaction links if provided
         if transaction_links:
-            tx_links = "\n".join([f"Batch {i + 1}: {link}" for i, link in enumerate(transaction_links)])
-            fields.append({"title": "Transactions", "value": tx_links, "short": False})
+            tx_links = []
+
+            # For each transaction link, extract the transaction hash from the URL
+            for i, link in enumerate(transaction_links):
+                try:
+                    if "/tx/" in link:
+                        tx_hash = link.split("/tx/")[-1]
+                        tx_links.append(f"Batch {i + 1}: <{link}|{tx_hash}>")
+
+                    # Fallback: show the full link if format is unexpected
+                    else:
+                        tx_links.append(f"Batch {i + 1}: {link}")
+
+                # If transaction link not in expected format, add full link to list
+                except Exception as e:
+                    logger.warning(f"Failed to format transaction link: {link}, error: {e}")
+                    tx_links.append(f"Batch {i + 1}: {link}")
+
+            # Add the list of transaction links to the fields
+            fields.append({"title": "Transactions", "value": "\n".join(tx_links), "short": False})
 
         # Create message payload
         payload = self._create_payload("Service Quality Oracle - Success", fields, "good")
@@ -180,8 +198,26 @@ def send_failure_notification(
 
         # Add partial transaction links if any succeeded before failure
         if partial_transaction_links:
-            tx_links = "\n".join([f"Batch {i + 1}: {link}" for i, link in enumerate(partial_transaction_links)])
-            fields.append({"title": "Partial Transactions", "value": tx_links, "short": False})
+            tx_links = []
+
+            # For each partial transaction link, extract the transaction hash from the URL
+            for i, link in enumerate(partial_transaction_links):
+                try:
+                    if "/tx/" in link:
+                        tx_hash = link.split("/tx/")[-1]
+                        tx_links.append(f"Batch {i + 1}: <{link}|{tx_hash}>")
+
+                    # Fallback: show the full link if format is unexpected
+                    else:
+                        tx_links.append(f"Batch {i + 1}: {link}")
+
+                # If transaction link not in expected format, add full link to list
+                except Exception as e:
+                    logger.warning(f"Failed to format transaction link: {link}, error: {e}")
+                    tx_links.append(f"Batch {i + 1}: {link}")
+
+            # Add the list of partial transaction links to the fields
+            fields.append({"title": "Partial Transactions", "value": "\n".join(tx_links), "short": False})
 
         # Truncate error message if too long
         error_text = error_message[:1000] + "..." if len(error_message) > 1000 else error_message

tests/test_slack_notifier.py

@@ -103,7 +103,7 @@ def test_send_success_notification_builds_correct_payload(mock_requests: MagicMo
     assert fields["Status"] == "Successfully completed"
     assert fields["Eligible Indexers"] == "1"
     assert "123.4" in fields["Execution Time"]
-    assert "Batch 1: http://etherscan.io/tx/1" in fields["Transactions"]
+    assert "Batch 1: <http://etherscan.io/tx/1|1>" in fields["Transactions"]
 
 
 def test_send_failure_notification_builds_correct_payload(mock_requests: MagicMock):