NRT (#181)

sungam3r · web-flow · commit a390cb9a7236 · 2021-12-12T02:52:23.000+03:00
diff --git a/src/BasicSample/Program.cs b/src/BasicSample/Program.cs
@@ -14,7 +14,6 @@ namespace BasicSample
 {
     internal class Program
     {
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "main")]
         private static async Task Main()
         {
             using var serviceProvider = new ServiceCollection()
@@ -61,10 +60,10 @@ type Query {
     /// <summary>
     /// Custom context class that implements <see cref="IProvideClaimsPrincipal"/>.
     /// </summary>
-    public class GraphQLUserContext : Dictionary<string, object>, IProvideClaimsPrincipal
+    public class GraphQLUserContext : Dictionary<string, object?>, IProvideClaimsPrincipal
     {
         /// <inheritdoc />
-        public ClaimsPrincipal User { get; set; }
+        public ClaimsPrincipal? User { get; set; }
     }
 
     /// <summary>
@@ -92,11 +91,11 @@ public class User
         /// <summary>
         /// Resolver for 'User.id' field. Just a simple property.
         /// </summary>
-        public string Id { get; set; }
+        public string? Id { get; set; }
 
         /// <summary>
         /// Resolver for 'User.name' field. Just a simple property.
         /// </summary>
-        public string Name { get; set; }
+        public string? Name { get; set; }
     }
 }
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -16,6 +16,7 @@
     <DebugType>embedded</DebugType>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/GraphQL.Authorization.ApiTests/GraphQL.Authorization.approved.txt b/src/GraphQL.Authorization.ApiTests/GraphQL.Authorization.approved.txt
@@ -10,15 +10,15 @@ namespace GraphQL.Authorization
         public AuthorizationContext() { }
         public System.Collections.Generic.IEnumerable<string> Errors { get; }
         public bool HasErrors { get; }
-        public System.Collections.Generic.IReadOnlyDictionary<string, object> Inputs { get; set; }
-        public System.Security.Claims.ClaimsPrincipal User { get; set; }
-        public System.Collections.Generic.IDictionary<string, object> UserContext { get; set; }
+        public System.Collections.Generic.IReadOnlyDictionary<string, object>? Inputs { get; set; }
+        public System.Security.Claims.ClaimsPrincipal? User { get; set; }
+        public System.Collections.Generic.IDictionary<string, object?>? UserContext { get; set; }
         public void ReportError(string error) { }
     }
     public class AuthorizationEvaluator : GraphQL.Authorization.IAuthorizationEvaluator
     {
         public AuthorizationEvaluator(GraphQL.Authorization.AuthorizationSettings settings) { }
-        public System.Threading.Tasks.Task<GraphQL.Authorization.AuthorizationResult> Evaluate(System.Security.Claims.ClaimsPrincipal principal, System.Collections.Generic.IDictionary<string, object> userContext, System.Collections.Generic.IReadOnlyDictionary<string, object> inputs, System.Collections.Generic.IEnumerable<string> requiredPolicies) { }
+        public System.Threading.Tasks.Task<GraphQL.Authorization.AuthorizationResult> Evaluate(System.Security.Claims.ClaimsPrincipal? principal, System.Collections.Generic.IDictionary<string, object?>? userContext, System.Collections.Generic.IReadOnlyDictionary<string, object>? inputs, System.Collections.Generic.IEnumerable<string>? requiredPolicies) { }
     }
     public class AuthorizationPolicy : GraphQL.Authorization.IAuthorizationPolicy
     {
@@ -33,12 +33,12 @@ namespace GraphQL.Authorization
         public GraphQL.Authorization.AuthorizationPolicyBuilder RequireAuthenticatedUser() { }
         public GraphQL.Authorization.AuthorizationPolicyBuilder RequireClaim(string claimType) { }
         public GraphQL.Authorization.AuthorizationPolicyBuilder RequireClaim(string claimType, params string[] allowedValues) { }
-        public GraphQL.Authorization.AuthorizationPolicyBuilder RequireClaim(string claimType, System.Collections.Generic.IEnumerable<string> allowedValues, System.Collections.Generic.IEnumerable<string> displayValues) { }
+        public GraphQL.Authorization.AuthorizationPolicyBuilder RequireClaim(string claimType, System.Collections.Generic.IEnumerable<string>? allowedValues, System.Collections.Generic.IEnumerable<string>? displayValues) { }
     }
     public class AuthorizationResult
     {
         public AuthorizationResult() { }
-        public System.Collections.Generic.IEnumerable<string> Errors { get; }
+        public System.Collections.Generic.IEnumerable<string>? Errors { get; }
         public bool Succeeded { get; }
         public static GraphQL.Authorization.AuthorizationResult Fail(System.Collections.Generic.IEnumerable<string> errors) { }
         public static GraphQL.Authorization.AuthorizationResult Success() { }
@@ -50,27 +50,27 @@ namespace GraphQL.Authorization
         public void AddPolicy(string name, GraphQL.Authorization.IAuthorizationPolicy policy) { }
         public void AddPolicy(string name, System.Action<GraphQL.Authorization.AuthorizationPolicyBuilder> configure) { }
         public System.Collections.Generic.IEnumerable<GraphQL.Authorization.IAuthorizationPolicy> GetPolicies(System.Collections.Generic.IEnumerable<string> policies) { }
-        public GraphQL.Authorization.IAuthorizationPolicy GetPolicy(string name) { }
+        public GraphQL.Authorization.IAuthorizationPolicy? GetPolicy(string name) { }
     }
     public class AuthorizationValidationRule : GraphQL.Validation.IValidationRule
     {
         public AuthorizationValidationRule(GraphQL.Authorization.IAuthorizationEvaluator evaluator) { }
-        public System.Threading.Tasks.ValueTask<GraphQL.Validation.INodeVisitor> ValidateAsync(GraphQL.Validation.ValidationContext context) { }
+        public System.Threading.Tasks.ValueTask<GraphQL.Validation.INodeVisitor?> ValidateAsync(GraphQL.Validation.ValidationContext context) { }
     }
     public class ClaimAuthorizationRequirement : GraphQL.Authorization.IAuthorizationRequirement
     {
         public ClaimAuthorizationRequirement(string claimType) { }
         public ClaimAuthorizationRequirement(string claimType, System.Collections.Generic.IEnumerable<string> allowedValues) { }
         public ClaimAuthorizationRequirement(string claimType, params string[] allowedValues) { }
-        public ClaimAuthorizationRequirement(string claimType, System.Collections.Generic.IEnumerable<string> allowedValues, System.Collections.Generic.IEnumerable<string> displayValues) { }
+        public ClaimAuthorizationRequirement(string claimType, System.Collections.Generic.IEnumerable<string>? allowedValues, System.Collections.Generic.IEnumerable<string>? displayValues) { }
         public System.Collections.Generic.IEnumerable<string> AllowedValues { get; }
         public string ClaimType { get; }
-        public System.Collections.Generic.IEnumerable<string> DisplayValues { get; }
+        public System.Collections.Generic.IEnumerable<string>? DisplayValues { get; }
         public System.Threading.Tasks.Task Authorize(GraphQL.Authorization.AuthorizationContext context) { }
     }
     public interface IAuthorizationEvaluator
     {
-        System.Threading.Tasks.Task<GraphQL.Authorization.AuthorizationResult> Evaluate(System.Security.Claims.ClaimsPrincipal principal, System.Collections.Generic.IDictionary<string, object> userContext, System.Collections.Generic.IReadOnlyDictionary<string, object> inputs, System.Collections.Generic.IEnumerable<string> requiredPolicies);
+        System.Threading.Tasks.Task<GraphQL.Authorization.AuthorizationResult> Evaluate(System.Security.Claims.ClaimsPrincipal? principal, System.Collections.Generic.IDictionary<string, object?>? userContext, System.Collections.Generic.IReadOnlyDictionary<string, object>? inputs, System.Collections.Generic.IEnumerable<string>? requiredPolicies);
     }
     public interface IAuthorizationPolicy
     {
@@ -82,6 +82,6 @@ namespace GraphQL.Authorization
     }
     public interface IProvideClaimsPrincipal
     {
-        System.Security.Claims.ClaimsPrincipal User { get; }
+        System.Security.Claims.ClaimsPrincipal? User { get; }
     }
 }
diff --git a/src/GraphQL.Authorization.Tests/AuthorizationSchemaBuilderTests.cs b/src/GraphQL.Authorization.Tests/AuthorizationSchemaBuilderTests.cs
@@ -20,13 +20,13 @@ type Query {
 
             schema.Initialize();
 
-            var query = schema.AllTypes["Query"] as IObjectGraphType;
+            var query = (IObjectGraphType)schema.AllTypes["Query"]!;
             query.RequiresAuthorization().ShouldBeTrue();
-            query.GetPolicies().Single().ShouldBe("ClassPolicy");
+            query.GetPolicies()!.Single().ShouldBe("ClassPolicy");
 
             var field = query.Fields.Single(x => x.Name == "post");
             field.RequiresAuthorization().ShouldBeTrue();
-            field.GetPolicies().Single().ShouldBe("FieldPolicy");
+            field.GetPolicies()!.Single().ShouldBe("FieldPolicy");
         }
 
         [GraphQLMetadata("Query")]
diff --git a/src/GraphQL.Authorization.Tests/AuthorizationValidationRuleTests.cs b/src/GraphQL.Authorization.Tests/AuthorizationValidationRuleTests.cs
@@ -2,6 +2,7 @@
 using System.Linq;
 using GraphQL.Types;
 using GraphQL.Types.Relay.DataObjects;
+using Shouldly;
 using Xunit;
 
 namespace GraphQL.Authorization.Tests
@@ -246,6 +247,30 @@ public void passes_with_claim_on_variable_type()
             });
         }
 
+        [Fact]
+        public void passes_with_claim_on_variable_type_without_inputs_but_fails_later_either()
+        {
+            Settings.AddPolicy("FieldPolicy", builder => builder.RequireClaim("admin"));
+
+            ShouldFailRule(config =>
+            {
+                config.ValidateResult = result =>
+                {
+                    // no auth error on null inputs, only INVALID_VALUE
+                    result.Errors.Count.ShouldBe(1);
+                    result.Errors[0].Code.ShouldBe("INVALID_VALUE");
+                    result.Errors[0].Message.ShouldBe("Variable '$input' is invalid. No value provided for a non-null variable.");
+                };
+                config.Query = @"query Author($input: AuthorInputType!) { author(input: $input) }";
+                config.Schema = TypedSchema();
+                config.Inputs = null;
+                config.User = CreatePrincipal(claims: new Dictionary<string, string>
+                {
+                    { "Admin", "true" }
+                });
+            });
+        }
+
         [Fact]
         public void fails_on_missing_claim_on_variable_type()
         {
@@ -340,19 +365,19 @@ type Post {
         public class NestedQueryWithAttributes
         {
             [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "test")]
-            public Post Post(string id) => null;
+            public Post? Post(string id) => null;
 
-            public IEnumerable<Post> Posts() => null;
+            public IEnumerable<Post>? Posts() => null;
 
-            public IEnumerable<Post> PostsNonNull() => null;
+            public IEnumerable<Post>? PostsNonNull() => null;
 
-            public string Comment() => null;
+            public string? Comment() => null;
         }
 
         [GraphQLAuthorize("PostPolicy")]
         public class Post
         {
-            public string Id { get; set; }
+            public string? Id { get; set; }
         }
 
         public class PostGraphType : ObjectGraphType<Post>
@@ -365,11 +390,11 @@ public PostGraphType()
 
         public class Article
         {
-            public string Id { get; set; }
+            public string? Id { get; set; }
 
-            public string Author { get; set; }
+            public string? Author { get; set; }
 
-            public string Content { get; set; }
+            public string? Content { get; set; }
         }
 
         public class ArticleGraphType : ObjectGraphType<Article>
@@ -384,7 +409,7 @@ public ArticleGraphType()
 
         public class Author
         {
-            public string Name { get; set; }
+            public string? Name { get; set; }
         }
 
         private static ISchema TypedSchema()
diff --git a/src/GraphQL.Authorization.Tests/GraphQLUserContext.cs b/src/GraphQL.Authorization.Tests/GraphQLUserContext.cs
@@ -3,8 +3,8 @@
 
 namespace GraphQL.Authorization.Tests
 {
-    internal class GraphQLUserContext : Dictionary<string, object>, IProvideClaimsPrincipal
+    internal class GraphQLUserContext : Dictionary<string, object?>, IProvideClaimsPrincipal
     {
-        public ClaimsPrincipal User { get; set; }
+        public ClaimsPrincipal? User { get; set; }
     }
 }
diff --git a/src/GraphQL.Authorization.Tests/ValidationTestBase.cs b/src/GraphQL.Authorization.Tests/ValidationTestBase.cs
@@ -66,7 +66,7 @@ private static IValidationResult Validate(ValidationTestConfig config)
             return validator.ValidateAsync(config.Schema, document, document.Operations.First().Variables, config.Rules, userContext, config.Inputs, config.OperationName).GetAwaiter().GetResult().validationResult;
         }
 
-        internal static ClaimsPrincipal CreatePrincipal(string authenticationType = null, IDictionary<string, string> claims = null)
+        internal static ClaimsPrincipal CreatePrincipal(string? authenticationType = null, IDictionary<string, string>? claims = null)
         {
             var claimsList = new List<Claim>();
 
diff --git a/src/GraphQL.Authorization.Tests/ValidationTestConfig.cs b/src/GraphQL.Authorization.Tests/ValidationTestConfig.cs
@@ -8,17 +8,17 @@ namespace GraphQL.Authorization.Tests
 {
     public class ValidationTestConfig
     {
-        public string OperationName { get; set; }
+        public string OperationName { get; set; } = null!;
 
-        public string Query { get; set; }
+        public string Query { get; set; } = null!;
 
-        public ISchema Schema { get; set; }
+        public ISchema Schema { get; set; } = null!;
 
         public List<IValidationRule> Rules { get; set; } = new List<IValidationRule>();
 
-        public ClaimsPrincipal User { get; set; }
+        public ClaimsPrincipal? User { get; set; }
 
-        public Inputs Inputs { get; set; }
+        public Inputs? Inputs { get; set; }
 
         public Action<IValidationResult> ValidateResult = _ => { };
     }
diff --git a/src/GraphQL.Authorization/AuthorizationContext.cs b/src/GraphQL.Authorization/AuthorizationContext.cs
@@ -9,22 +9,22 @@ namespace GraphQL.Authorization
     /// </summary>
     public class AuthorizationContext
     {
-        private List<string> _errors;
+        private List<string>? _errors;
 
         /// <summary>
         /// Current user.
         /// </summary>
-        public ClaimsPrincipal User { get; set; }
+        public ClaimsPrincipal? User { get; set; }
 
         /// <summary>
         /// Arbitrary user defined context represented as dictionary.
         /// </summary>
-        public IDictionary<string, object> UserContext { get; set; }
+        public IDictionary<string, object?>? UserContext { get; set; }
 
         /// <summary>
         /// Represents a readonly dictionary of variable inputs to an executed document.
         /// </summary>
-        public IReadOnlyDictionary<string, object> Inputs { get; set; }
+        public IReadOnlyDictionary<string, object>? Inputs { get; set; }
 
         /// <summary>
         /// Returns a set of authorization errors.
diff --git a/src/GraphQL.Authorization/AuthorizationEvaluator.cs b/src/GraphQL.Authorization/AuthorizationEvaluator.cs
@@ -22,10 +22,10 @@ public AuthorizationEvaluator(AuthorizationSettings settings)
 
         /// <inheritdoc />
         public async Task<AuthorizationResult> Evaluate(
-            ClaimsPrincipal principal,
-            IDictionary<string, object> userContext,
-            IReadOnlyDictionary<string, object> inputs,
-            IEnumerable<string> requiredPolicies)
+            ClaimsPrincipal? principal,
+            IDictionary<string, object?>? userContext,
+            IReadOnlyDictionary<string, object>? inputs,
+            IEnumerable<string>? requiredPolicies)
         {
             if (requiredPolicies == null)
                 return AuthorizationResult.Success();
diff --git a/src/GraphQL.Authorization/AuthorizationPolicyBuilder.cs b/src/GraphQL.Authorization/AuthorizationPolicyBuilder.cs
@@ -50,7 +50,7 @@ public AuthorizationPolicyBuilder RequireClaim(string claimType, params string[]
         /// an error message for <see cref="AuthorizationContext.Errors"/>.
         /// </param>
         /// <returns>Reference to the same builder.</returns>
-        public AuthorizationPolicyBuilder RequireClaim(string claimType, IEnumerable<string> allowedValues, IEnumerable<string> displayValues)
+        public AuthorizationPolicyBuilder RequireClaim(string claimType, IEnumerable<string>? allowedValues, IEnumerable<string>? displayValues)
         {
             _requirements.Add(new ClaimAuthorizationRequirement(claimType, allowedValues, displayValues));
             return this;
diff --git a/src/GraphQL.Authorization/AuthorizationResult.cs b/src/GraphQL.Authorization/AuthorizationResult.cs
@@ -18,7 +18,7 @@ public class AuthorizationResult
         /// <summary>
         /// Returns a set of authorization errors if the authorization result is unsuccessful.
         /// </summary>
-        public IEnumerable<string> Errors { get; private set; }
+        public IEnumerable<string>? Errors { get; private set; }
 
         /// <summary>
         /// Creates successful authorization result.
diff --git a/src/GraphQL.Authorization/AuthorizationSettings.cs b/src/GraphQL.Authorization/AuthorizationSettings.cs
@@ -24,7 +24,7 @@ public class AuthorizationSettings
         /// <returns>Policies with matched names.</returns>
         public IEnumerable<IAuthorizationPolicy> GetPolicies(IEnumerable<string> policies)
         {
-            List<IAuthorizationPolicy> found = null;
+            List<IAuthorizationPolicy>? found = null;
 
             if (policies != null)
             {
@@ -44,7 +44,7 @@ public IEnumerable<IAuthorizationPolicy> GetPolicies(IEnumerable<string> policie
         /// </summary>
         /// <param name="name">Name of the required policy.</param>
         /// <returns>Required policy if exists, otherwise <see langword="null"/>.</returns>
-        public IAuthorizationPolicy GetPolicy(string name) => _policies.TryGetValue(name, out var policy) ? policy : null;
+        public IAuthorizationPolicy? GetPolicy(string name) => _policies.TryGetValue(name, out var policy) ? policy : null;
 
         /// <summary>
         /// Adds a policy with the specified name. If a policy with that name already exists then it will be replaced.
diff --git a/src/GraphQL.Authorization/AuthorizationValidationRule.cs b/src/GraphQL.Authorization/AuthorizationValidationRule.cs
diff --git a/src/GraphQL.Authorization/IAuthorizationEvaluator.cs b/src/GraphQL.Authorization/IAuthorizationEvaluator.cs
diff --git a/src/GraphQL.Authorization/IProvideClaimsPrincipal.cs b/src/GraphQL.Authorization/IProvideClaimsPrincipal.cs
diff --git a/src/GraphQL.Authorization/Requirements/ClaimAuthorizationRequirement.cs b/src/GraphQL.Authorization/Requirements/ClaimAuthorizationRequirement.cs
diff --git a/src/Harness/GraphQL.cs b/src/Harness/GraphQL.cs
diff --git a/src/Harness/Startup.cs b/src/Harness/Startup.cs

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ namespace BasicSample`
`14`	`14`	`{`
`15`	`15`	`internal class Program`
`16`	`16`	`{`
`17`		`- [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "main")]`
`18`	`17`	`private static async Task Main()`
`19`	`18`	`{`
`20`	`19`	`using var serviceProvider = new ServiceCollection()`
`@@ -61,10 +60,10 @@ type Query {`
`61`	`60`	`/// <summary>`
`62`	`61`	`/// Custom context class that implements <see cref="IProvideClaimsPrincipal"/>.`
`63`	`62`	`/// </summary>`
`64`		`- public class GraphQLUserContext : Dictionary<string, object>, IProvideClaimsPrincipal`
	`63`	`+ public class GraphQLUserContext : Dictionary<string, object?>, IProvideClaimsPrincipal`
`65`	`64`	`{`
`66`	`65`	`/// <inheritdoc />`
`67`		`- public ClaimsPrincipal User { get; set; }`
	`66`	`+ public ClaimsPrincipal? User { get; set; }`
`68`	`67`	`}`
`69`	`68`
`70`	`69`	`/// <summary>`
`@@ -92,11 +91,11 @@ public class User`
`92`	`91`	`/// <summary>`
`93`	`92`	`/// Resolver for 'User.id' field. Just a simple property.`
`94`	`93`	`/// </summary>`
`95`		`- public string Id { get; set; }`
	`94`	`+ public string? Id { get; set; }`
`96`	`95`
`97`	`96`	`/// <summary>`
`98`	`97`	`/// Resolver for 'User.name' field. Just a simple property.`
`99`	`98`	`/// </summary>`
`100`		`- public string Name { get; set; }`
	`99`	`+ public string? Name { get; set; }`
`101`	`100`	`}`
`102`	`101`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,15 +10,15 @@ namespace GraphQL.Authorization`
`10`	`10`	`public AuthorizationContext() { }`
`11`	`11`	`public System.Collections.Generic.IEnumerable<string> Errors { get; }`
`12`	`12`	`public bool HasErrors { get; }`
`13`		`- public System.Collections.Generic.IReadOnlyDictionary<string, object> Inputs { get; set; }`
`14`		`- public System.Security.Claims.ClaimsPrincipal User { get; set; }`
`15`		`- public System.Collections.Generic.IDictionary<string, object> UserContext { get; set; }`
	`13`	`+ public System.Collections.Generic.IReadOnlyDictionary<string, object>? Inputs { get; set; }`
	`14`	`+ public System.Security.Claims.ClaimsPrincipal? User { get; set; }`
	`15`	`+ public System.Collections.Generic.IDictionary<string, object?>? UserContext { get; set; }`
`16`	`16`	`public void ReportError(string error) { }`
`17`	`17`	`}`
`18`	`18`	`public class AuthorizationEvaluator : GraphQL.Authorization.IAuthorizationEvaluator`
`19`	`19`	`{`
`20`	`20`	`public AuthorizationEvaluator(GraphQL.Authorization.AuthorizationSettings settings) { }`
`21`		`- public System.Threading.Tasks.Task<GraphQL.Authorization.AuthorizationResult> Evaluate(System.Security.Claims.ClaimsPrincipal principal, System.Collections.Generic.IDictionary<string, object> userContext, System.Collections.Generic.IReadOnlyDictionary<string, object> inputs, System.Collections.Generic.IEnumerable<string> requiredPolicies) { }`
	`21`	`+ public System.Threading.Tasks.Task<GraphQL.Authorization.AuthorizationResult> Evaluate(System.Security.Claims.ClaimsPrincipal? principal, System.Collections.Generic.IDictionary<string, object?>? userContext, System.Collections.Generic.IReadOnlyDictionary<string, object>? inputs, System.Collections.Generic.IEnumerable<string>? requiredPolicies) { }`
`22`	`22`	`}`
`23`	`23`	`public class AuthorizationPolicy : GraphQL.Authorization.IAuthorizationPolicy`
`24`	`24`	`{`
`@@ -33,12 +33,12 @@ namespace GraphQL.Authorization`
`33`	`33`	`public GraphQL.Authorization.AuthorizationPolicyBuilder RequireAuthenticatedUser() { }`
`34`	`34`	`public GraphQL.Authorization.AuthorizationPolicyBuilder RequireClaim(string claimType) { }`
`35`	`35`	`public GraphQL.Authorization.AuthorizationPolicyBuilder RequireClaim(string claimType, params string[] allowedValues) { }`
`36`		`- public GraphQL.Authorization.AuthorizationPolicyBuilder RequireClaim(string claimType, System.Collections.Generic.IEnumerable<string> allowedValues, System.Collections.Generic.IEnumerable<string> displayValues) { }`
	`36`	`+ public GraphQL.Authorization.AuthorizationPolicyBuilder RequireClaim(string claimType, System.Collections.Generic.IEnumerable<string>? allowedValues, System.Collections.Generic.IEnumerable<string>? displayValues) { }`
`37`	`37`	`}`
`38`	`38`	`public class AuthorizationResult`
`39`	`39`	`{`
`40`	`40`	`public AuthorizationResult() { }`
`41`		`- public System.Collections.Generic.IEnumerable<string> Errors { get; }`
	`41`	`+ public System.Collections.Generic.IEnumerable<string>? Errors { get; }`
`42`	`42`	`public bool Succeeded { get; }`
`43`	`43`	`public static GraphQL.Authorization.AuthorizationResult Fail(System.Collections.Generic.IEnumerable<string> errors) { }`
`44`	`44`	`public static GraphQL.Authorization.AuthorizationResult Success() { }`
`@@ -50,27 +50,27 @@ namespace GraphQL.Authorization`
`50`	`50`	`public void AddPolicy(string name, GraphQL.Authorization.IAuthorizationPolicy policy) { }`
`51`	`51`	`public void AddPolicy(string name, System.Action<GraphQL.Authorization.AuthorizationPolicyBuilder> configure) { }`
`52`	`52`	`public System.Collections.Generic.IEnumerable<GraphQL.Authorization.IAuthorizationPolicy> GetPolicies(System.Collections.Generic.IEnumerable<string> policies) { }`
`53`		`- public GraphQL.Authorization.IAuthorizationPolicy GetPolicy(string name) { }`
	`53`	`+ public GraphQL.Authorization.IAuthorizationPolicy? GetPolicy(string name) { }`
`54`	`54`	`}`
`55`	`55`	`public class AuthorizationValidationRule : GraphQL.Validation.IValidationRule`
`56`	`56`	`{`
`57`	`57`	`public AuthorizationValidationRule(GraphQL.Authorization.IAuthorizationEvaluator evaluator) { }`
`58`		`- public System.Threading.Tasks.ValueTask<GraphQL.Validation.INodeVisitor> ValidateAsync(GraphQL.Validation.ValidationContext context) { }`
	`58`	`+ public System.Threading.Tasks.ValueTask<GraphQL.Validation.INodeVisitor?> ValidateAsync(GraphQL.Validation.ValidationContext context) { }`
`59`	`59`	`}`
`60`	`60`	`public class ClaimAuthorizationRequirement : GraphQL.Authorization.IAuthorizationRequirement`
`61`	`61`	`{`
`62`	`62`	`public ClaimAuthorizationRequirement(string claimType) { }`
`63`	`63`	`public ClaimAuthorizationRequirement(string claimType, System.Collections.Generic.IEnumerable<string> allowedValues) { }`
`64`	`64`	`public ClaimAuthorizationRequirement(string claimType, params string[] allowedValues) { }`
`65`		`- public ClaimAuthorizationRequirement(string claimType, System.Collections.Generic.IEnumerable<string> allowedValues, System.Collections.Generic.IEnumerable<string> displayValues) { }`
	`65`	`+ public ClaimAuthorizationRequirement(string claimType, System.Collections.Generic.IEnumerable<string>? allowedValues, System.Collections.Generic.IEnumerable<string>? displayValues) { }`
`66`	`66`	`public System.Collections.Generic.IEnumerable<string> AllowedValues { get; }`
`67`	`67`	`public string ClaimType { get; }`
`68`		`- public System.Collections.Generic.IEnumerable<string> DisplayValues { get; }`
	`68`	`+ public System.Collections.Generic.IEnumerable<string>? DisplayValues { get; }`
`69`	`69`	`public System.Threading.Tasks.Task Authorize(GraphQL.Authorization.AuthorizationContext context) { }`
`70`	`70`	`}`
`71`	`71`	`public interface IAuthorizationEvaluator`
`72`	`72`	`{`
`73`		`- System.Threading.Tasks.Task<GraphQL.Authorization.AuthorizationResult> Evaluate(System.Security.Claims.ClaimsPrincipal principal, System.Collections.Generic.IDictionary<string, object> userContext, System.Collections.Generic.IReadOnlyDictionary<string, object> inputs, System.Collections.Generic.IEnumerable<string> requiredPolicies);`
	`73`	`+ System.Threading.Tasks.Task<GraphQL.Authorization.AuthorizationResult> Evaluate(System.Security.Claims.ClaimsPrincipal? principal, System.Collections.Generic.IDictionary<string, object?>? userContext, System.Collections.Generic.IReadOnlyDictionary<string, object>? inputs, System.Collections.Generic.IEnumerable<string>? requiredPolicies);`
`74`	`74`	`}`
`75`	`75`	`public interface IAuthorizationPolicy`
`76`	`76`	`{`
`@@ -82,6 +82,6 @@ namespace GraphQL.Authorization`
`82`	`82`	`}`
`83`	`83`	`public interface IProvideClaimsPrincipal`
`84`	`84`	`{`
`85`		`- System.Security.Claims.ClaimsPrincipal User { get; }`
	`85`	`+ System.Security.Claims.ClaimsPrincipal? User { get; }`
`86`	`86`	`}`
`87`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,8 @@`
`3`	`3`
`4`	`4`	`namespace GraphQL.Authorization.Tests`
`5`	`5`	`{`
`6`		`- internal class GraphQLUserContext : Dictionary<string, object>, IProvideClaimsPrincipal`
	`6`	`+ internal class GraphQLUserContext : Dictionary<string, object?>, IProvideClaimsPrincipal`
`7`	`7`	`{`
`8`		`- public ClaimsPrincipal User { get; set; }`
	`8`	`+ public ClaimsPrincipal? User { get; set; }`
`9`	`9`	`}`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ private static IValidationResult Validate(ValidationTestConfig config)`
`66`	`66`	`return validator.ValidateAsync(config.Schema, document, document.Operations.First().Variables, config.Rules, userContext, config.Inputs, config.OperationName).GetAwaiter().GetResult().validationResult;`
`67`	`67`	`}`
`68`	`68`
`69`		`- internal static ClaimsPrincipal CreatePrincipal(string authenticationType = null, IDictionary<string, string> claims = null)`
	`69`	`+ internal static ClaimsPrincipal CreatePrincipal(string? authenticationType = null, IDictionary<string, string>? claims = null)`
`70`	`70`	`{`
`71`	`71`	`var claimsList = new List<Claim>();`
`72`	`72`
Original file line number	Diff line number	Diff line change
`@@ -8,17 +8,17 @@ namespace GraphQL.Authorization.Tests`
`8`	`8`	`{`
`9`	`9`	`public class ValidationTestConfig`
`10`	`10`	`{`
`11`		`- public string OperationName { get; set; }`
	`11`	`+ public string OperationName { get; set; } = null!;`
`12`	`12`
`13`		`- public string Query { get; set; }`
	`13`	`+ public string Query { get; set; } = null!;`
`14`	`14`
`15`		`- public ISchema Schema { get; set; }`
	`15`	`+ public ISchema Schema { get; set; } = null!;`
`16`	`16`
`17`	`17`	`public List<IValidationRule> Rules { get; set; } = new List<IValidationRule>();`
`18`	`18`
`19`		`- public ClaimsPrincipal User { get; set; }`
	`19`	`+ public ClaimsPrincipal? User { get; set; }`
`20`	`20`
`21`		`- public Inputs Inputs { get; set; }`
	`21`	`+ public Inputs? Inputs { get; set; }`
`22`	`22`
`23`	`23`	`public Action<IValidationResult> ValidateResult = _ => { };`
`24`	`24`	`}`