test websocket serialization

Author: rose-a

src/GraphQL.Client.Serializer.Newtonsoft/GraphQLWebSocketRequest.cs

@@ -17,7 +17,7 @@ public GraphQLWebSocketRequest()
 		public GraphQLWebSocketRequest(Abstractions.Websocket.GraphQLWebSocketRequest other) {
 			Id = other.Id;
 			Type = other.Type;
-			Payload = new Newtonsoft.GraphQLRequest(other.Payload);
+			Payload = new GraphQLRequest(other.Payload); // create serializer-specific type
 		}
 	}
 }

src/GraphQL.Client.Serializer.Newtonsoft/NewtonsoftJsonSerializer.cs

@@ -33,7 +33,7 @@ public string SerializeToString(GraphQL.GraphQLRequest request) {
 		}
 
 		public byte[] SerializeToBytes(Abstractions.Websocket.GraphQLWebSocketRequest request) {
-			var json = JsonConvert.SerializeObject(request, Options.JsonSerializerSettings);
+			var json = JsonConvert.SerializeObject(new GraphQLWebSocketRequest(request), Options.JsonSerializerSettings);
 			return Encoding.UTF8.GetBytes(json);
 		}
 

tests/GraphQL.Client.Serializer.Tests/BaseSerializeNoCamelCaseTest.cs

@@ -31,6 +31,14 @@ public void SerializeToStringTest(string expectedJson, GraphQLRequest request) {
 			json.Should().Be(expectedJson.RemoveWhitespace());
 		}
 
+		[Theory]
+		[ClassData(typeof(SerializeToBytesTestData))]
+		public void SerializeToBytesTest(string expectedJson, GraphQLWebSocketRequest request) {
+			var json = Encoding.UTF8.GetString(Serializer.SerializeToBytes(request)).RemoveWhitespace();
+			json.Should().Be(expectedJson.RemoveWhitespace());
+		}
+
+
 		[Fact]
 		public async void WorksWithoutCamelCaseNamingStrategy() {
 

tests/GraphQL.Client.Serializer.Tests/BaseSerializerTest.cs

@@ -1,4 +1,6 @@
 using System.Collections.Generic;
+using System.Linq;
+using System.Text;
 using FluentAssertions;
 using GraphQL.Client.Abstractions;
 using GraphQL.Client.Abstractions.Websocket;
@@ -32,6 +34,13 @@ public void SerializeToStringTest(string expectedJson, GraphQLRequest request) {
 			json.Should().BeEquivalentTo(expectedJson.RemoveWhitespace());
 		}
 
+		[Theory]
+		[ClassData(typeof(SerializeToBytesTestData))]
+		public void SerializeToBytesTest(string expectedJson, GraphQLWebSocketRequest request) {
+			var json = Encoding.UTF8.GetString(Serializer.SerializeToBytes(request)).RemoveWhitespace();
+			json.Should().BeEquivalentTo(expectedJson.RemoveWhitespace());
+		}
+
 		[Fact]
 		public async void CanDeserializeExtensions() {
 

tests/GraphQL.Client.Serializer.Tests/TestData/SerializeToBytesTestData.cs

@@ -0,0 +1,32 @@
+using System.Collections;
+using System.Collections.Generic;
+using GraphQL.Client.Abstractions.Websocket;
+using GraphQL.Client.Tests.Common.Chat;
+
+namespace GraphQL.Client.Serializer.Tests.TestData {
+	public class SerializeToBytesTestData : IEnumerable<object[]> {
+		public IEnumerator<object[]> GetEnumerator() {
+			yield return new object[] {
+				"{\"id\":\"1234567\",\"type\":\"start\",\"payload\":{\"query\":\"simplequerystring\",\"operationName\":null,\"variables\":null}}",
+				new GraphQLWebSocketRequest {
+					Id = "1234567",
+					Type = GraphQLWebSocketMessageType.GQL_START,
+					Payload = new GraphQLRequest("simplequerystring")
+				}
+			};
+			yield return new object[] {
+				"{\"id\":\"34476567\",\"type\":\"start\",\"payload\":{\"query\":\"simplequerystring\",\"operationName\":null,\"variables\":{\"camelCaseProperty\":\"camelCase\",\"PascalCaseProperty\":\"PascalCase\"}}}",
+				new GraphQLWebSocketRequest {
+					Id = "34476567",
+					Type = GraphQLWebSocketMessageType.GQL_START,
+					Payload = new GraphQLRequest("simple query string", new { camelCaseProperty = "camelCase", PascalCaseProperty = "PascalCase"})
+				}
+				
+			};
+		}
+
+		IEnumerator IEnumerable.GetEnumerator() {
+			return GetEnumerator();
+		}
+	}
+}