Merge pull request #213 from graphql-dotnet/refactor-observable-tester

Refactor observable tester

Author: rose-a

.github/workflows/branches-ubuntu.yml

@@ -6,7 +6,8 @@ on:
       - 'release/**'
       - 'releases/**'
 env:
-  DOTNET_CLI_TELEMETRY_OPTOUT: true
+  DOTNET_CLI_TELEMETRY_OPTOUT: true  
+  MSBUILDSINGLELOADCONTEXT: 1
 jobs:
   generateVersionInfo:  
     name: GenerateVersionInfo

.github/workflows/main-ubuntu.yml

@@ -10,6 +10,8 @@ on:
       - V*
 env:
   DOTNET_CLI_TELEMETRY_OPTOUT: true
+  MSBUILDSINGLELOADCONTEXT: 1
+
 jobs:
   generateVersionInfo:  
     name: GenerateVersionInfo

dotnet-tools.json

@@ -8,7 +8,7 @@
       ]
     },
     "gitversion.tool": {
-      "version": "5.1.3",
+      "version": "5.2.4",
       "commands": [
         "dotnet-gitversion"
       ]

src/GraphQL.Client.Abstractions.Websocket/GraphQL.Client.Abstractions.Websocket.csproj

@@ -4,7 +4,6 @@
 	<PropertyGroup>
     <Description>Abstractions for the Websocket transport used in GraphQL.Client</Description>
 	  <TargetFramework>netstandard2.0</TargetFramework>
-	  <LangVersion>8.0</LangVersion>
 	</PropertyGroup>
 
 	<ItemGroup>

src/GraphQL.Client.Serializer.Newtonsoft/GraphQL.Client.Serializer.Newtonsoft.csproj

@@ -4,7 +4,6 @@
   <PropertyGroup>
     <Description>A serializer implementation for GraphQL.Client using Newtonsoft.Json as underlying JSON library</Description>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
-	  <LangVersion>8.0</LangVersion>
   </PropertyGroup>
 
   <ItemGroup>

src/GraphQL.Client.Serializer.SystemTextJson/GraphQL.Client.Serializer.SystemTextJson.csproj

@@ -1,10 +1,10 @@
 <Project Sdk="Microsoft.NET.Sdk">
-	<Import Project="../src.props" />
+
+  <Import Project="../src.props" />
 
   <PropertyGroup>
     <Description>A serializer implementation for GraphQL.Client using System.Text.Json as underlying JSON library</Description>
     <TargetFrameworks>netstandard2.0;netcoreapp3.1</TargetFrameworks>
-	  <LangVersion>8.0</LangVersion>
   </PropertyGroup>
 
 	<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0'">

src/GraphQL.Client/GraphQL.Client.csproj

@@ -15,16 +15,7 @@
 		<DefineConstants>NETFRAMEWORK</DefineConstants>
 	</PropertyGroup>
 
-	<ItemGroup>
-	  <Compile Remove="GraphQLSerializationExtensions.cs" />
-	</ItemGroup>
-
-	<ItemGroup>
-	  <None Include="GraphQLSerializationExtensions.cs" />
-	</ItemGroup>
-
-
-	<ItemGroup>
+  <ItemGroup>
 		<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.0" PrivateAssets="All" />
 	</ItemGroup>
 
@@ -37,7 +28,4 @@
 	  <ProjectReference Include="..\GraphQL.Client.Abstractions\GraphQL.Client.Abstractions.csproj" />
 	</ItemGroup>
 
-	
-
-
 </Project>

src/GraphQL.Client/GraphQLHttpClient.cs

@@ -129,11 +129,9 @@ private async Task<GraphQLHttpResponse<TResponse>> SendHttpPostRequestAsync<TRes
             var preprocessedRequest = await Options.PreprocessRequest(request, this);
             using var httpRequestMessage = GenerateHttpRequestMessage(preprocessedRequest);
             using var httpResponseMessage = await HttpClient.SendAsync(httpRequestMessage, cancellationToken);
-            if (!httpResponseMessage.IsSuccessStatusCode)
-            {
-                throw new GraphQLHttpException(httpResponseMessage);
-            }
 
+            httpResponseMessage.EnsureSuccessStatusCode();
+            
             var bodyStream = await httpResponseMessage.Content.ReadAsStreamAsync();
             var response = await JsonSerializer.DeserializeFromUtf8StreamAsync<TResponse>(bodyStream, cancellationToken);
             return response.ToGraphQLHttpResponse(httpResponseMessage.Headers, httpResponseMessage.StatusCode);

src/GraphQL.Client/GraphQLSerializationExtensions.cs

@@ -7,4 +7,5 @@
 		<RootNamespace>GraphQL</RootNamespace>
 		<TargetFrameworks>netstandard2.0</TargetFrameworks>
 	</PropertyGroup>
+
 </Project>