Fix doubled whitespace for inline fragments (#355)

Author: sungam3r

.github/workflows/codeql-analysis.yml

@@ -18,25 +18,26 @@ jobs:
         with:
           show-progress: false
 
-    - name: Setup .NET SDK
-      uses: actions/setup-dotnet@v3
-      with:
-         dotnet-version: 7.0.x
-
-    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v2
-      with:
-        queries: security-and-quality
-        languages: csharp
-
-    - name: Install dependencies
-      working-directory: src
-      run: dotnet restore
-
-    - name: Build only parser project
-      # https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/troubleshooting-the-codeql-workflow#reduce-the-amount-of-code-being-analyzed-in-a-single-workflow
-      working-directory: src/GraphQLParser
-      run: dotnet build --no-restore
-
-    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v2
+      - name: Setup .NET SDK
+        uses: actions/setup-dotnet@v3
+        with:
+           dotnet-version: 7.0.x
+
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          queries: security-and-quality
+          languages: csharp
+          config-file: ./.github/codeql-config.yml
+
+      - name: Install dependencies
+        working-directory: src
+        run: dotnet restore
+
+      - name: Build only parser project
+        # https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/troubleshooting-the-codeql-workflow#reduce-the-amount-of-code-being-analyzed-in-a-single-workflow
+        working-directory: src/GraphQLParser
+        run: dotnet build --no-restore
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2

src/GraphQLParser.Tests/Visitors/SDLSorterTests.SortsSchemaDefinition.approved.ExecutableSortTests.graphql

@@ -5,7 +5,7 @@
   field1(arg1: [3, 1, 2], arg2: "value1", arg3: {sub1: 2, sub2: 1, sub3: 3})
   field2
   field3 @dir1(arg1: [3, 1, 2], arg2: "value1", arg3: {sub1: 2, sub2: 1, sub3: 3}) @dir2 @dir3
-  ...  {
+  ... {
     field4
   }
   ... on Type2 {

src/GraphQLParser.Tests/Visitors/SDLSorterTests.SortsSchemaDefinition.approved.KitchenSink.graphql

@@ -12,10 +12,10 @@
 query queryName($foo: ComplexType, $site: Site = MOBILE) {
   whoever123is: node(id: [123, 456]) {
     id
-    ...  @skip(unless: $foo) {
+    ... @skip(unless: $foo) {
       id
     }
-    ...  {
+    ... {
       id
     }
     ... on User @defer {

src/GraphQLParser/Visitors/SDLPrinter.cs

@@ -206,7 +206,6 @@ protected override async ValueTask VisitFragmentDefinitionAsync(GraphQLFragmentD
         await VisitAsync(fragmentDefinition.Comments, context).ConfigureAwait(false);
         await context.WriteAsync("fragment ").ConfigureAwait(false);
         await VisitAsync(fragmentDefinition.FragmentName, context).ConfigureAwait(false);
-        await context.WriteAsync(" ").ConfigureAwait(false);
         await VisitAsync(fragmentDefinition.TypeCondition, context).ConfigureAwait(false);
         await VisitAsync(fragmentDefinition.Directives, context).ConfigureAwait(false);
         await VisitAsync(fragmentDefinition.SelectionSet, context).ConfigureAwait(false);
@@ -234,7 +233,7 @@ protected override async ValueTask VisitInlineFragmentAsync(GraphQLInlineFragmen
 
         await WriteIndentAsync(context).ConfigureAwait(false);
 
-        await context.WriteAsync("... ").ConfigureAwait(false);
+        await context.WriteAsync("...").ConfigureAwait(false);
         await VisitAsync(inlineFragment.TypeCondition, context).ConfigureAwait(false);
         await VisitAsync(inlineFragment.Directives, context).ConfigureAwait(false);
         await VisitAsync(inlineFragment.SelectionSet, context).ConfigureAwait(false);
@@ -244,7 +243,7 @@ protected override async ValueTask VisitInlineFragmentAsync(GraphQLInlineFragmen
     protected override async ValueTask VisitTypeConditionAsync(GraphQLTypeCondition typeCondition, TContext context)
     {
         await VisitAsync(typeCondition.Comments, context).ConfigureAwait(false);
-        await context.WriteAsync("on ").ConfigureAwait(false);
+        await context.WriteAsync(TryPeekParent(context, out _) ? " on " : "on ").ConfigureAwait(false);
         await VisitAsync(typeCondition.Type, context).ConfigureAwait(false);
     }
 
@@ -1117,8 +1116,8 @@ private static async ValueTask WriteIndentAsync(TContext context)
             await context.WriteAsync("  ").ConfigureAwait(false);
     }
 
-    // Returns parent if called inside ViisitXXX i.e. after context.Parents.Push(node);
-    // Returns grand-parent if called inside ViisitAsync i.e. before context.Parents.Push(node);
+    // Returns parent if called inside VisitXXX i.e. after context.Parents.Push(node);
+    // Returns grand-parent if called inside VisitAsync i.e. before context.Parents.Push(node);
     private static bool TryPeekParent(TContext context, [NotNullWhen(true)] out ASTNode? node)
     {
         node = null;