Remove DefaultErrorInfoProvider (#761)

Author: Shane32

samples/Samples.Server/CustomErrorInfoProvider.cs

@@ -1,22 +1,19 @@
 using System.Text;
 using GraphQL.Execution;
-using GraphQL.Server;
 using GraphQL.Server.Authorization.AspNetCore;
 using Microsoft.AspNetCore.Authorization;
-using Microsoft.Extensions.Options;
 
 namespace GraphQL.Samples.Server
 {
     /// <summary>
     /// Custom <see cref="ErrorInfoProvider"/> implementing a dedicated error message for the sample <see cref="IAuthorizationRequirement"/>
     /// used in this MS article: https://docs.microsoft.com/en-us/aspnet/core/security/authorization/policies
     /// </summary>
-    public class CustomErrorInfoProvider : DefaultErrorInfoProvider
+    public class CustomErrorInfoProvider : ErrorInfoProvider
     {
         private readonly IAuthorizationErrorMessageBuilder _messageBuilder;
 
-        public CustomErrorInfoProvider(IOptions<ErrorInfoProviderOptions> options, IAuthorizationErrorMessageBuilder messageBuilder)
-            : base(options)
+        public CustomErrorInfoProvider(IAuthorizationErrorMessageBuilder messageBuilder)
         {
             _messageBuilder = messageBuilder;
         }

src/Core/DefaultErrorInfoProvider.cs

@@ -329,9 +329,9 @@ private static bool TryGetEncoding(string charset, out System.Text.Encoding enco
             try
             {
                 // Remove at most a single set of quotes.
-                if (charset.Length > 2 && charset[0] == '\"' && charset[charset.Length - 1] == '\"')
+                if (charset.Length > 2 && charset[0] == '\"' && charset[^1] == '\"')
                 {
-                    encoding = System.Text.Encoding.GetEncoding(charset.Substring(1, charset.Length - 2));
+                    encoding = System.Text.Encoding.GetEncoding(charset[1..^1]);
                 }
                 else
                 {

src/Transports.AspNetCore/GraphQLHttpMiddleware.cs

@@ -8,10 +8,6 @@ namespace GraphQL.Server
         public virtual System.Threading.Tasks.Task<GraphQL.ExecutionResult> ExecuteAsync(GraphQL.Transport.GraphQLRequest request, System.Collections.Generic.IDictionary<string, object> context, System.IServiceProvider requestServices, System.Threading.CancellationToken cancellationToken = default) { }
         protected virtual GraphQL.ExecutionOptions GetOptions(GraphQL.Transport.GraphQLRequest request, System.Collections.Generic.IDictionary<string, object> context, System.IServiceProvider requestServices, System.Threading.CancellationToken cancellationToken) { }
     }
-    public class DefaultErrorInfoProvider : GraphQL.Execution.ErrorInfoProvider
-    {
-        public DefaultErrorInfoProvider(Microsoft.Extensions.Options.IOptions<GraphQL.Execution.ErrorInfoProviderOptions> options) { }
-    }
     [System.Obsolete]
     public class DefaultGraphQLExecuter<TSchema> : GraphQL.Server.IGraphQLExecuter, GraphQL.Server.IGraphQLExecuter<TSchema>
         where TSchema : GraphQL.Types.ISchema

tests/ApiApprovalTests/GraphQL.Server.Core.approved.txt

@@ -20,13 +20,15 @@ public ChatSpec()
             _transport = new TestableSubscriptionTransport();
             _transportReader = _transport.Reader as TestableReader;
             _transportWriter = _transport.Writer as TestableWriter;
+#pragma warning disable CS0618 // Type or member is obsolete
             _subscriptions = new SubscriptionManager(
                 new BasicGraphQLExecuter<ChatSchema>(
                     new ChatSchema(_chat, new DefaultServiceProvider()),
                     new SubscriptionDocumentExecuter(),
                     Options.Create(new GraphQLOptions { })
                     ),
                 new NullLoggerFactory());
+#pragma warning restore CS0618 // Type or member is obsolete
 
             _server = new SubscriptionServer(
                 _transport,