Skip to content

Commit 9febda2

Browse files
authored
Fix CI to send coverage results on push (#529)
1 parent 43f2d7c commit 9febda2

File tree

3 files changed

+10
-17
lines changed

3 files changed

+10
-17
lines changed

.github/workflows/test.yml

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,31 +5,24 @@ on:
55
branches:
66
- master
77
- develop
8-
8+
paths:
9+
- src/**
10+
- .github/workflows/**
911
# Upload code coverage results when PRs are merged
1012
push:
1113
branches:
1214
- master
1315
- develop
16+
paths:
17+
- src/**
18+
- .github/workflows/**
1419

1520
env:
1621
DOTNET_NOLOGO: true
1722
DOTNET_CLI_TELEMETRY_OPTOUT: true
1823

1924
jobs:
20-
should_test:
21-
runs-on: ubuntu-latest
22-
outputs:
23-
should_skip: ${{ steps.skip_check.outputs.should_skip }}
24-
steps:
25-
- id: skip_check
26-
uses: fkirc/[email protected]
27-
with:
28-
github_token: ${{ github.token }}
29-
paths_ignore: '["README.md", "LICENSE.md", ".gitignore"]'
3025
test:
31-
needs: should_test
32-
if: ${{ needs.should_test.outputs.should_skip != 'true' }}
3326
strategy:
3427
matrix:
3528
os: [ubuntu-latest, windows-latest]
@@ -79,8 +72,8 @@ jobs:
7972
if: always()
8073
steps:
8174
- name: Pass build check
82-
if: ${{ needs.test.result == 'success' || needs.test.result == 'skipped' }}
75+
if: ${{ needs.test.result == 'success' }}
8376
run: exit 0
8477
- name: Fail build check
85-
if: ${{ needs.test.result != 'success' && needs.test.result != 'skipped' }}
78+
if: ${{ needs.test.result != 'success' }}
8679
run: exit 1

src/Authorization.AspNetCore/AuthorizationError.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public static void AppendFailureHeader(StringBuilder error, OperationType? opera
7575
{
7676
error.Append("You are not authorized to run this ")
7777
.Append(GetOperationType(operationType))
78-
.Append(".");
78+
.Append('.');
7979
}
8080

8181
/// <summary>

tests/Authorization.AspNetCore.Tests/AuthorizationValidationRuleTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ public void fails_on_missing_claim_on_connection_type()
264264
});
265265
}
266266

267-
private ISchema BasicSchema<T>()
267+
private static ISchema BasicSchema<T>()
268268
{
269269
string defs = @"
270270
type Query {

0 commit comments

Comments
 (0)