Dispose of WebSocket when done with it (#671)

Author: Shane32

src/Transports.Subscriptions.WebSockets/WebSocketConnection.cs

@@ -18,9 +18,16 @@ public WebSocketConnection(
 
         public async Task Connect()
         {
-            await _server.OnConnect();
-            await _server.OnDisconnect();
-            await _transport.CloseAsync();
+            try
+            {
+                await _server.OnConnect();
+                await _server.OnDisconnect();
+                await _transport.CloseAsync();
+            }
+            finally
+            {
+                _transport.Dispose();
+            }
         }
     }
 }

src/Transports.Subscriptions.WebSockets/WebSocketTransport.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Net.WebSockets;
 using System.Threading;
 using System.Threading.Tasks;
@@ -7,7 +8,7 @@
 
 namespace GraphQL.Server.Transports.WebSockets
 {
-    public class WebSocketTransport : IMessageTransport
+    public class WebSocketTransport : IMessageTransport, IDisposable
     {
         private readonly WebSocket _socket;
 
@@ -47,5 +48,10 @@ private Task AbortAsync()
             _socket.Abort();
             return Task.CompletedTask;
         }
+
+        public void Dispose()
+        {
+            _socket.Dispose();
+        }
     }
 }

tests/ApiApprovalTests/GraphQL.Server.Transports.Subscriptions.WebSockets.approved.txt

@@ -39,13 +39,14 @@ namespace GraphQL.Server.Transports.WebSockets
         protected System.Threading.Tasks.Dataflow.IPropagatorBlock<string, GraphQL.Server.Transports.Subscriptions.Abstractions.OperationMessage> CreateReaderJsonTransformer() { }
         public void LinkTo(System.Threading.Tasks.Dataflow.ITargetBlock<GraphQL.Server.Transports.Subscriptions.Abstractions.OperationMessage> target) { }
     }
-    public class WebSocketTransport : GraphQL.Server.Transports.Subscriptions.Abstractions.IMessageTransport
+    public class WebSocketTransport : GraphQL.Server.Transports.Subscriptions.Abstractions.IMessageTransport, System.IDisposable
     {
         public WebSocketTransport(System.Net.WebSockets.WebSocket socket, GraphQL.IDocumentWriter documentWriter) { }
         public System.Net.WebSockets.WebSocketCloseStatus? CloseStatus { get; }
         public GraphQL.Server.Transports.Subscriptions.Abstractions.IReaderPipeline Reader { get; }
         public GraphQL.Server.Transports.Subscriptions.Abstractions.IWriterPipeline Writer { get; }
         public System.Threading.Tasks.Task CloseAsync() { }
+        public void Dispose() { }
     }
     public class WebSocketWriterPipeline : GraphQL.Server.Transports.Subscriptions.Abstractions.IWriterPipeline
     {