Skip to content

Commit 2e67175

Browse files
committed
Fix extension error returns
1 parent 95d168a commit 2e67175

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

extensions.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ func handleExtensionsExecutionDidStart(p *ExecuteParams) ([]gqlerrors.FormattedE
165165
func() {
166166
defer func() {
167167
if r := recover(); r != nil {
168-
errs = append(errs, gqlerrors.FormatError(fmt.Errorf("%s.ResolveFieldDidStart: %v", ext.Name(), r.(error))))
168+
errs = append(errs, gqlerrors.FormatError(fmt.Errorf("%s.ExecutionDidStart: %v", ext.Name(), r.(error))))
169169
}
170170
}()
171171
ctx, finishFn = ext.ExecutionDidStart(p.Context)
@@ -187,7 +187,7 @@ func handleExtensionsExecutionDidStart(p *ExecuteParams) ([]gqlerrors.FormattedE
187187
finishFn(result)
188188
}()
189189
}
190-
return errs
190+
return extErrs
191191
}
192192
}
193193

@@ -226,13 +226,12 @@ func handleExtensionsResolveFieldDidStart(exts []Extension, p *executionContext,
226226
finishFn(val, err)
227227
}()
228228
}
229-
return errs
229+
return extErrs
230230
}
231231
}
232232

233233
func addExtensionResults(p *ExecuteParams, result *Result) {
234234
if len(p.Schema.extensions) != 0 {
235-
result.Extensions = map[string]interface{}{}
236235
for _, ext := range p.Schema.extensions {
237236
func() {
238237
defer func() {
@@ -241,11 +240,12 @@ func addExtensionResults(p *ExecuteParams, result *Result) {
241240
}
242241
}()
243242
if ext.HasResult() {
243+
if result.Extensions == nil {
244+
result.Extensions = make(map[string]interface{})
245+
}
244246
result.Extensions[ext.Name()] = ext.GetResult(p.Context)
245247
}
246248
}()
247249
}
248-
} else {
249-
result.Extensions = nil
250250
}
251251
}

0 commit comments

Comments
 (0)