node16 fixes

Author: enisdenjo

src/commands/build.ts

@@ -41,6 +41,12 @@ const filesToExcludeFromDist = [
   '**/temp',
 ];
 
+function compilerOptionsToArgs(options: Record<string, unknown>): string[] {
+  return Object.entries(options)
+    .filter(([, value]) => !!value)
+    .flatMap(([key, value]) => [`--${key}`, `${value}`]);
+}
+
 function assertTypeScriptBuildResult(
   result: Awaited<ReturnType<typeof execa>>,
   reporter: ConsolaInstance,
@@ -65,13 +71,14 @@ async function buildTypeScript(
     assertTypeScriptBuildResult(
       await execa('npx', [
         'tsc',
-        ...(tsconfig ? ['--project', tsconfig] : []),
-        '--module node16', // not nodenext because this keeps up with latest node and we dont want to break something suddenly
-        '--sourceMap false',
-        '--inlineSourceMap false',
-        ...(options.incremental ? ['--incremental'] : []),
-        '--outDir',
-        outDir,
+        ...compilerOptionsToArgs({
+          project: tsconfig,
+          module: 'node16',
+          sourceMap: false,
+          inlineSourceMap: false,
+          incremental: options.incremental,
+          outDir,
+        }),
       ]),
       reporter,
     );

test/integration.spec.ts

@@ -33,7 +33,7 @@ it('can bundle a simple project', async () => {
     export default _default;
   `);
   expect(await fse.readFile(indexMjsFilePath, 'utf8')).toMatchInlineSnapshot(`
-    export var someNumber = 1;
+    export const someNumber = 1;
     export default 'kek';
   `);
   expect(await fse.readFile(readmeFilePath, 'utf8')).toMatchInlineSnapshot('Hello!');
@@ -355,7 +355,7 @@ it('can build an esm only project', async () => {
   `);
 
   expect(await fse.readFile(indexJsFilePath, 'utf8')).toMatchInlineSnapshot(
-    'export var someNumber = 1;',
+    `export const someNumber = 1;`,
   );
   expect(await fse.readFile(indexDtsFilePath, 'utf8')).toMatchInlineSnapshot(
     'export declare const someNumber = 1;',
@@ -732,7 +732,7 @@ it('can bundle a tsconfig-build-json project', async () => {
   `);
   await expect(fse.readFile(path.resolve(baseDistPath, 'esm', 'index.js'), 'utf8')).resolves
     .toMatchInlineSnapshot(`
-    export var hello = 1;
+    export const hello = 1;
     export default 'there';
   `);
 
@@ -776,7 +776,7 @@ it('can bundle a simple project with additional exports', async () => {
   `);
   await expect(fse.readFile(path.join(dist, 'esm', 'index.js'), 'utf8')).resolves
     .toMatchInlineSnapshot(`
-    export var someLetter = 'a';
+    export const someLetter = 'a';
     export default { b: 'c' };
   `);
 
@@ -798,7 +798,7 @@ it('can bundle a simple project with additional exports', async () => {
   `);
   await expect(fse.readFile(path.join(dist, 'esm', 'sub', 'index.js'), 'utf8')).resolves
     .toMatchInlineSnapshot(`
-    export var someOtherLetter = 'd';
+    export const someOtherLetter = 'd';
     export default { e: 'f' };
   `);