Skip to content

Commit ccf0d52

Browse files
authored
chore: use Promise.withResolvers instead of createDeferred (#6724)
1 parent d30cd0e commit ccf0d52

File tree

2 files changed

+2
-29
lines changed

2 files changed

+2
-29
lines changed

packages/services/api/src/modules/app-deployments/providers/persisted-document-scheduler.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export class PersistedDocumentScheduler {
8888

8989
return async function batchProcess(data: BatchProcessEvent['data']) {
9090
const id = crypto.randomUUID();
91-
const d = createDeferred<BatchProcessedEvent>();
91+
const d = Promise.withResolvers<BatchProcessedEvent>();
9292
const timeout = setTimeout(() => {
9393
task.reject(new Error('Timeout, worker did not respond within time.'));
9494
}, 20_000);
@@ -132,18 +132,3 @@ export class PersistedDocumentScheduler {
132132
return this.getRandomWorker()(data);
133133
}
134134
}
135-
136-
function createDeferred<T = void>() {
137-
let resolve: (value: T) => void;
138-
let reject: (error: unknown) => void;
139-
const promise = new Promise<T>((res, rej) => {
140-
resolve = res;
141-
reject = rej;
142-
});
143-
144-
return {
145-
resolve: (value: T) => resolve(value),
146-
reject: (error: unknown) => reject(error),
147-
promise,
148-
};
149-
}

packages/services/api/src/modules/shared/lib/task-runner.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ const scheduleTask = (args: {
6363
args.logger.info(`Completed running task "${args.name}" to run at ${runsAt}.`);
6464
deferred.resolve();
6565
}, args.runInMilliSeconds);
66-
const deferred = createDeferred();
66+
const deferred = Promise.withResolvers<void>();
6767

6868
return {
6969
done: deferred.promise,
@@ -75,15 +75,3 @@ const scheduleTask = (args: {
7575
},
7676
};
7777
};
78-
79-
const createDeferred = () => {
80-
let resolve: () => void;
81-
const promise = new Promise<void>(r => {
82-
resolve = r;
83-
});
84-
85-
return {
86-
resolve: () => resolve(),
87-
promise,
88-
};
89-
};

0 commit comments

Comments
 (0)