Bump Hive Gateway and no cross-origin credentials #7305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @enisdenjo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Hive Gateway to its latest version and refining its configuration for improved stability, observability, and security. It integrates the gateway as a development dependency to leverage type-checking, standardizes logging and tracing configurations, and explicitly defines cross-origin resource sharing (CORS) policies to enhance security by disallowing credentials in cross-origin requests. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/apollo |
0.42.1-alpha-20251121224840-463cd46692859e161dc91b249d1ddc7f953ede14 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/cli |
0.53.5-alpha-20251121224840-463cd46692859e161dc91b249d1ddc7f953ede14 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/core |
0.15.1-alpha-20251121224840-463cd46692859e161dc91b249d1ddc7f953ede14 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/envelop |
0.38.1-alpha-20251121224840-463cd46692859e161dc91b249d1ddc7f953ede14 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.43.1-alpha-20251121224840-463cd46692859e161dc91b249d1ddc7f953ede14 |
npm ↗︎ unpkg ↗︎ |
hive |
8.9.0-alpha-20251121224840-463cd46692859e161dc91b249d1ddc7f953ede14 |
npm ↗︎ unpkg ↗︎ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The changes look good. Bumping the gateway version and adding it as a dev dependency to enable type-checking is a solid improvement. The configuration updates, especially the stricter CORS policy, are also positive. I have one suggestion to make the environment variable handling more robust.
Contributor
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7305.hive-storybook.pages.dev |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-7305.hive-landing-page.pages.dev |
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: Docker Bake metadata{
"apollo-router": {
"buildx.build.provenance": {
"builder": {
"id": ""
},
"buildType": "https://mobyproject.org/buildkit@v1",
"materials": [
{
"uri": "pkg:docker/docker/dockerfile@1",
"digest": {
"sha256": "b6afd42430b15f2d2a4c5a02b919e98a525b785b1aaff16747d2f623364e39b6"
}
},
{
"uri": "pkg:docker/debian@bookworm-slim?platform=linux%2Famd64",
"digest": {
"sha256": "b4aa902587c2e61ce789849cb54c332b0400fe27b1ee33af4669e1f7e7c3e22f"
}
},
{
"uri": "pkg:docker/[email protected]?platform=linux%2Famd64",
"digest": {
"sha256": "64232e656c058f4468e8d024e990acff04f0fd5a5c0a88a574dc37773d7325c9"
}
}
],
"invocation": {
"configSource": {
"entryPoint": "router.dockerfile"
},
"parameters": {
"frontend": "gateway.v0",
"args": {
"build-arg:IMAGE_DESCRIPTION": "Apollo Router for GraphQL Hive.",
"build-arg:IMAGE_TITLE": "graphql-hive/apollo-router",
"build-arg:PORT": "4000",
"build-arg:RELEASE": "2a6a5644c433cb140172519f1b54386305dec18e",
"cmdline": "docker/dockerfile:1",
"context:config": "local:config",
"context:router_pkg": "local:router_pkg",
"context:sdk_rs_pkg": "local:sdk_rs_pkg",
"frontend.caps": "moby.buildkit.frontend.contexts+forward",
"source": "docker/dockerfile:1"
},
"locals": [
{
"name": "config"
},
{
"name": "context"
},
{
"name": "dockerfile"
},
{
"name": "router_pkg"
},
{
"name": "sdk_rs_pkg"
}
]
},
"environment": {
"platform": "linux/amd64",
"ProvenanceCustomEnv": null
}
}
},
"buildx.build.ref": "builder-274404ca-4438-4de7-b42a-a49e4dfed791/builder-274404ca-4438-4de7-b42a-a49e4dfed7910/4k57qykre3hnmojg30u7ge09k",
"containerimage.config.digest": "sha256:c604dd48cb1df7d1234a08524c6bba9250fc9cca2e93c7802ed37786dd903a1a",
"containerimage.descriptor": {
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"digest": "sha256:a48407d345c8273f039a43bf3cddc197ab02ba952ef4f91340822b6312ad2baa",
"size": 2069,
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
"containerimage.digest": "sha256:a48407d345c8273f039a43bf3cddc197ab02ba952ef4f91340822b6312ad2baa",
"image.name": "ghcr.io/graphql-hive/apollo-router:2a6a5644c433cb140172519f1b54386305dec18e-amd64,ghcr.io/graphql-hive/apollo-router:protect-amd64"
},
"buildx.build.warnings": [
{
"vertex": "sha256:8ac80a3424cc85915a651d2d0adfbffbb23c969cdb7da53af67f52ed8ab13c3a",
"level": 1,
"short": "VW5kZWZpbmVkVmFyOiBVc2FnZSBvZiB1bmRlZmluZWQgdmFyaWFibGUgJyRJTUFHRV9ERVNDUklQVElPTicgKGxpbmUgNTkp",
"detail": [
"VmFyaWFibGVzIHNob3VsZCBiZSBkZWZpbmVkIGJlZm9yZSB0aGVpciB1c2U="
],
"url": "https://docs.docker.com/go/dockerfile/rule/undefined-var/",
"sourceInfo": {
"filename": "router.dockerfile",
"data": "IyBzeW50YXg9ZG9ja2VyL2RvY2tlcmZpbGU6MQpGUk9NIHNjcmF0Y2ggQVMgcm91dGVyX3BrZwpGUk9NIHNjcmF0Y2ggQVMgc2RrX3JzX3BrZwpGUk9NIHNjcmF0Y2ggQVMgY29uZmlnCgpGUk9NIHJ1c3Q6MS45MC1zbGltLWJvb2t3b3JtIEFTIGJ1aWxkCgojIFJlcXVpcmVkIGJ5IEFwb2xsbyBSb3V0ZXIKUlVOIGFwdC1nZXQgdXBkYXRlClJVTiBhcHQtZ2V0IC15IGluc3RhbGwgbnBtIHByb3RvYnVmLWNvbXBpbGVyIGNtYWtlClJVTiBybSAtcmYgL3Zhci9saWIvYXB0L2xpc3RzLyoKUlVOIHVwZGF0ZS1jYS1jZXJ0aWZpY2F0ZXMKUlVOIHJ1c3R1cCBjb21wb25lbnQgYWRkIHJ1c3RmbXQKCldPUktESVIgL3Vzci9zcmMKIyBDcmVhdGUgYmxhbmsgcHJvamVjdHMKUlVOIFVTRVI9cm9vdCBjYXJnbyBuZXcgcm91dGVyClJVTiBVU0VSPXJvb3QgY2FyZ28gbmV3IHNkay1ycwoKIyBDb3B5IENhcmdvIGZpbGVzCkNPUFkgLS1mcm9tPXJvdXRlcl9wa2cgQ2FyZ28udG9tbCAvdXNyL3NyYy9yb3V0ZXIvCkNPUFkgLS1mcm9tPXNka19yc19wa2cgQ2FyZ28udG9tbCAvdXNyL3NyYy9zZGstcnMvCkNPUFkgLS1mcm9tPWNvbmZpZyBDYXJnby5sb2NrIC91c3Ivc3JjL3JvdXRlci8KCldPUktESVIgL3Vzci9zcmMvc2RrLXJzCiMgR2V0IHRoZSBkZXBlbmRlbmNpZXMgY2FjaGVkLCBzbyB3ZSBjYW4gdXNlIGR1bW15IGlucHV0IGZpbGVzIHNvIENhcmdvIHdvbnQgZmFpbApSVU4gZWNobyAnZm4gbWFpbigpIHsgcHJpbnRsbiEoIiIpOyB9JyA+IC4vc3JjL21haW4ucnMKUlVOIGVjaG8gJ2ZuIG1haW4oKSB7IHByaW50bG4hKCIiKTsgfScgPiAuL3NyYy9saWIucnMKUlVOIGNhcmdvIGJ1aWxkIC0tcmVsZWFzZQoKIyBDb3B5IGluIHRoZSBhY3R1YWwgc291cmNlIGNvZGUKQ09QWSAtLWZyb209c2RrX3JzX3BrZyBzcmMgLi9zcmMKUlVOIHRvdWNoIC4vc3JjL21haW4ucnMKUlVOIHRvdWNoIC4vc3JjL2xpYi5ycwoKV09SS0RJUiAvdXNyL3NyYy9yb3V0ZXIKIyBHZXQgdGhlIGRlcGVuZGVuY2llcyBjYWNoZWQsIHNvIHdlIGNhbiB1c2UgZHVtbXkgaW5wdXQgZmlsZXMgc28gQ2FyZ28gd29udCBmYWlsClJVTiBlY2hvICdmbiBtYWluKCkgeyBwcmludGxuISgiIik7IH0nID4gLi9zcmMvbWFpbi5ycwpSVU4gZWNobyAnZm4gbWFpbigpIHsgcHJpbnRsbiEoIiIpOyB9JyA+IC4vc3JjL2xpYi5ycwpSVU4gY2FyZ28gYnVpbGQgLS1yZWxlYXNlCgojIENvcHkgaW4gdGhlIGFjdHVhbCBzb3VyY2UgY29kZQpDT1BZIC0tZnJvbT1yb3V0ZXJfcGtnIHNyYyAuL3NyYwpSVU4gdG91Y2ggLi9zcmMvbWFpbi5ycwpSVU4gdG91Y2ggLi9zcmMvbGliLnJzCgojIFJlYWwgYnVpbGQgdGhpcyB0aW1lClJVTiBjYXJnbyBidWlsZCAtLXJlbGVhc2UKCiMgUnVudGltZQpGUk9NIGRlYmlhbjpib29rd29ybS1zbGltIEFTIHJ1bnRpbWUKClJVTiBhcHQtZ2V0IHVwZGF0ZQpSVU4gYXB0LWdldCAteSBpbnN0YWxsIGNhLWNlcnRpZmljYXRlcwpSVU4gcm0gLXJmIC92YXIvbGliL2FwdC9saXN0cy8qCgpMQUJFTCBvcmcub3BlbmNvbnRhaW5lcnMuaW1hZ2UudGl0bGU9JElNQUdFX1RJVExFCkxBQkVMIG9yZy5vcGVuY29udGFpbmVycy5pbWFnZS52ZXJzaW9uPSRSRUxFQVNFCkxBQkVMIG9yZy5vcGVuY29udGFpbmVycy5pbWFnZS5kZXNjcmlwdGlvbj0kSU1BR0VfREVTQ1JJUFRJT04KTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLmF1dGhvcnM9IlRoZSBHdWlsZCIKTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLnZlbmRvcj0iS2FtaWwgS2lzaWVsYSIKTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLnVybD0iaHR0cHM6Ly9naXRodWIuY29tL2dyYXBocWwtaGl2ZS9jb25zb2xlIgpMQUJFTCBvcmcub3BlbmNvbnRhaW5lcnMuaW1hZ2Uuc291cmNlPSJodHRwczovL2dpdGh1Yi5jb20vZ3JhcGhxbC1oaXZlL2NvbnNvbGUiCgpSVU4gbWtkaXIgLXAgL2Rpc3QvY29uZmlnClJVTiBta2RpciAvZGlzdC9zY2hlbWEKCiMgQ29weSBpbiB0aGUgcmVxdWlyZWQgZmlsZXMgZnJvbSBvdXIgYnVpbGQgaW1hZ2UKQ09QWSAtLWZyb209YnVpbGQgLS1jaG93bj1yb290OnJvb3QgL3Vzci9zcmMvcm91dGVyL3RhcmdldC9yZWxlYXNlL3JvdXRlciAvZGlzdApDT1BZIC0tZnJvbT1yb3V0ZXJfcGtnIHJvdXRlci55YW1sIC9kaXN0L2NvbmZpZy9yb3V0ZXIueWFtbAoKV09SS0RJUiAvZGlzdAoKRU5WIEFQT0xMT19ST1VURVJfQ09ORklHX1BBVEg9Ii9kaXN0L2NvbmZpZy9yb3V0ZXIueWFtbCIKCkVOVFJZUE9JTlQgWyIuL3JvdXRlciJdCg==",
"language": "Dockerfile"
},
"range": [
{
"start": {
"line": 59
},
"end": {
"line": 59
}
}
]
},
{
"vertex": "sha256:8ac80a3424cc85915a651d2d0adfbffbb23c969cdb7da53af67f52ed8ab13c3a",
"level": 1,
"short": "VW5kZWZpbmVkVmFyOiBVc2FnZSBvZiB1bmRlZmluZWQgdmFyaWFibGUgJyRJTUFHRV9USVRMRScgKGxpbmUgNTcp",
"detail": [
"VmFyaWFibGVzIHNob3VsZCBiZSBkZWZpbmVkIGJlZm9yZSB0aGVpciB1c2U="
],
"url": "https://docs.docker.com/go/dockerfile/rule/undefined-var/",
"sourceInfo": {
"filename": "router.dockerfile",
"data": "IyBzeW50YXg9ZG9ja2VyL2RvY2tlcmZpbGU6MQpGUk9NIHNjcmF0Y2ggQVMgcm91dGVyX3BrZwpGUk9NIHNjcmF0Y2ggQVMgc2RrX3JzX3BrZwpGUk9NIHNjcmF0Y2ggQVMgY29uZmlnCgpGUk9NIHJ1c3Q6MS45MC1zbGltLWJvb2t3b3JtIEFTIGJ1aWxkCgojIFJlcXVpcmVkIGJ5IEFwb2xsbyBSb3V0ZXIKUlVOIGFwdC1nZXQgdXBkYXRlClJVTiBhcHQtZ2V0IC15IGluc3RhbGwgbnBtIHByb3RvYnVmLWNvbXBpbGVyIGNtYWtlClJVTiBybSAtcmYgL3Zhci9saWIvYXB0L2xpc3RzLyoKUlVOIHVwZGF0ZS1jYS1jZXJ0aWZpY2F0ZXMKUlVOIHJ1c3R1cCBjb21wb25lbnQgYWRkIHJ1c3RmbXQKCldPUktESVIgL3Vzci9zcmMKIyBDcmVhdGUgYmxhbmsgcHJvamVjdHMKUlVOIFVTRVI9cm9vdCBjYXJnbyBuZXcgcm91dGVyClJVTiBVU0VSPXJvb3QgY2FyZ28gbmV3IHNkay1ycwoKIyBDb3B5IENhcmdvIGZpbGVzCkNPUFkgLS1mcm9tPXJvdXRlcl9wa2cgQ2FyZ28udG9tbCAvdXNyL3NyYy9yb3V0ZXIvCkNPUFkgLS1mcm9tPXNka19yc19wa2cgQ2FyZ28udG9tbCAvdXNyL3NyYy9zZGstcnMvCkNPUFkgLS1mcm9tPWNvbmZpZyBDYXJnby5sb2NrIC91c3Ivc3JjL3JvdXRlci8KCldPUktESVIgL3Vzci9zcmMvc2RrLXJzCiMgR2V0IHRoZSBkZXBlbmRlbmNpZXMgY2FjaGVkLCBzbyB3ZSBjYW4gdXNlIGR1bW15IGlucHV0IGZpbGVzIHNvIENhcmdvIHdvbnQgZmFpbApSVU4gZWNobyAnZm4gbWFpbigpIHsgcHJpbnRsbiEoIiIpOyB9JyA+IC4vc3JjL21haW4ucnMKUlVOIGVjaG8gJ2ZuIG1haW4oKSB7IHByaW50bG4hKCIiKTsgfScgPiAuL3NyYy9saWIucnMKUlVOIGNhcmdvIGJ1aWxkIC0tcmVsZWFzZQoKIyBDb3B5IGluIHRoZSBhY3R1YWwgc291cmNlIGNvZGUKQ09QWSAtLWZyb209c2RrX3JzX3BrZyBzcmMgLi9zcmMKUlVOIHRvdWNoIC4vc3JjL21haW4ucnMKUlVOIHRvdWNoIC4vc3JjL2xpYi5ycwoKV09SS0RJUiAvdXNyL3NyYy9yb3V0ZXIKIyBHZXQgdGhlIGRlcGVuZGVuY2llcyBjYWNoZWQsIHNvIHdlIGNhbiB1c2UgZHVtbXkgaW5wdXQgZmlsZXMgc28gQ2FyZ28gd29udCBmYWlsClJVTiBlY2hvICdmbiBtYWluKCkgeyBwcmludGxuISgiIik7IH0nID4gLi9zcmMvbWFpbi5ycwpSVU4gZWNobyAnZm4gbWFpbigpIHsgcHJpbnRsbiEoIiIpOyB9JyA+IC4vc3JjL2xpYi5ycwpSVU4gY2FyZ28gYnVpbGQgLS1yZWxlYXNlCgojIENvcHkgaW4gdGhlIGFjdHVhbCBzb3VyY2UgY29kZQpDT1BZIC0tZnJvbT1yb3V0ZXJfcGtnIHNyYyAuL3NyYwpSVU4gdG91Y2ggLi9zcmMvbWFpbi5ycwpSVU4gdG91Y2ggLi9zcmMvbGliLnJzCgojIFJlYWwgYnVpbGQgdGhpcyB0aW1lClJVTiBjYXJnbyBidWlsZCAtLXJlbGVhc2UKCiMgUnVudGltZQpGUk9NIGRlYmlhbjpib29rd29ybS1zbGltIEFTIHJ1bnRpbWUKClJVTiBhcHQtZ2V0IHVwZGF0ZQpSVU4gYXB0LWdldCAteSBpbnN0YWxsIGNhLWNlcnRpZmljYXRlcwpSVU4gcm0gLXJmIC92YXIvbGliL2FwdC9saXN0cy8qCgpMQUJFTCBvcmcub3BlbmNvbnRhaW5lcnMuaW1hZ2UudGl0bGU9JElNQUdFX1RJVExFCkxBQkVMIG9yZy5vcGVuY29udGFpbmVycy5pbWFnZS52ZXJzaW9uPSRSRUxFQVNFCkxBQkVMIG9yZy5vcGVuY29udGFpbmVycy5pbWFnZS5kZXNjcmlwdGlvbj0kSU1BR0VfREVTQ1JJUFRJT04KTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLmF1dGhvcnM9IlRoZSBHdWlsZCIKTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLnZlbmRvcj0iS2FtaWwgS2lzaWVsYSIKTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLnVybD0iaHR0cHM6Ly9naXRodWIuY29tL2dyYXBocWwtaGl2ZS9jb25zb2xlIgpMQUJFTCBvcmcub3BlbmNvbnRhaW5lcnMuaW1hZ2Uuc291cmNlPSJodHRwczovL2dpdGh1Yi5jb20vZ3JhcGhxbC1oaXZlL2NvbnNvbGUiCgpSVU4gbWtkaXIgLXAgL2Rpc3QvY29uZmlnClJVTiBta2RpciAvZGlzdC9zY2hlbWEKCiMgQ29weSBpbiB0aGUgcmVxdWlyZWQgZmlsZXMgZnJvbSBvdXIgYnVpbGQgaW1hZ2UKQ09QWSAtLWZyb209YnVpbGQgLS1jaG93bj1yb290OnJvb3QgL3Vzci9zcmMvcm91dGVyL3RhcmdldC9yZWxlYXNlL3JvdXRlciAvZGlzdApDT1BZIC0tZnJvbT1yb3V0ZXJfcGtnIHJvdXRlci55YW1sIC9kaXN0L2NvbmZpZy9yb3V0ZXIueWFtbAoKV09SS0RJUiAvZGlzdAoKRU5WIEFQT0xMT19ST1VURVJfQ09ORklHX1BBVEg9Ii9kaXN0L2NvbmZpZy9yb3V0ZXIueWFtbCIKCkVOVFJZUE9JTlQgWyIuL3JvdXRlciJdCg==",
"language": "Dockerfile"
},
"range": [
{
"start": {
"line": 57
},
"end": {
"line": 57
}
}
]
},
{
"vertex": "sha256:8ac80a3424cc85915a651d2d0adfbffbb23c969cdb7da53af67f52ed8ab13c3a",
"level": 1,
"short": "VW5kZWZpbmVkVmFyOiBVc2FnZSBvZiB1bmRlZmluZWQgdmFyaWFibGUgJyRSRUxFQVNFJyAobGluZSA1OCk=",
"detail": [
"VmFyaWFibGVzIHNob3VsZCBiZSBkZWZpbmVkIGJlZm9yZSB0aGVpciB1c2U="
],
"url": "https://docs.docker.com/go/dockerfile/rule/undefined-var/",
"sourceInfo": {
"filename": "router.dockerfile",
"data": "IyBzeW50YXg9ZG9ja2VyL2RvY2tlcmZpbGU6MQpGUk9NIHNjcmF0Y2ggQVMgcm91dGVyX3BrZwpGUk9NIHNjcmF0Y2ggQVMgc2RrX3JzX3BrZwpGUk9NIHNjcmF0Y2ggQVMgY29uZmlnCgpGUk9NIHJ1c3Q6MS45MC1zbGltLWJvb2t3b3JtIEFTIGJ1aWxkCgojIFJlcXVpcmVkIGJ5IEFwb2xsbyBSb3V0ZXIKUlVOIGFwdC1nZXQgdXBkYXRlClJVTiBhcHQtZ2V0IC15IGluc3RhbGwgbnBtIHByb3RvYnVmLWNvbXBpbGVyIGNtYWtlClJVTiBybSAtcmYgL3Zhci9saWIvYXB0L2xpc3RzLyoKUlVOIHVwZGF0ZS1jYS1jZXJ0aWZpY2F0ZXMKUlVOIHJ1c3R1cCBjb21wb25lbnQgYWRkIHJ1c3RmbXQKCldPUktESVIgL3Vzci9zcmMKIyBDcmVhdGUgYmxhbmsgcHJvamVjdHMKUlVOIFVTRVI9cm9vdCBjYXJnbyBuZXcgcm91dGVyClJVTiBVU0VSPXJvb3QgY2FyZ28gbmV3IHNkay1ycwoKIyBDb3B5IENhcmdvIGZpbGVzCkNPUFkgLS1mcm9tPXJvdXRlcl9wa2cgQ2FyZ28udG9tbCAvdXNyL3NyYy9yb3V0ZXIvCkNPUFkgLS1mcm9tPXNka19yc19wa2cgQ2FyZ28udG9tbCAvdXNyL3NyYy9zZGstcnMvCkNPUFkgLS1mcm9tPWNvbmZpZyBDYXJnby5sb2NrIC91c3Ivc3JjL3JvdXRlci8KCldPUktESVIgL3Vzci9zcmMvc2RrLXJzCiMgR2V0IHRoZSBkZXBlbmRlbmNpZXMgY2FjaGVkLCBzbyB3ZSBjYW4gdXNlIGR1bW15IGlucHV0IGZpbGVzIHNvIENhcmdvIHdvbnQgZmFpbApSVU4gZWNobyAnZm4gbWFpbigpIHsgcHJpbnRsbiEoIiIpOyB9JyA+IC4vc3JjL21haW4ucnMKUlVOIGVjaG8gJ2ZuIG1haW4oKSB7IHByaW50bG4hKCIiKTsgfScgPiAuL3NyYy9saWIucnMKUlVOIGNhcmdvIGJ1aWxkIC0tcmVsZWFzZQoKIyBDb3B5IGluIHRoZSBhY3R1YWwgc291cmNlIGNvZGUKQ09QWSAtLWZyb209c2RrX3JzX3BrZyBzcmMgLi9zcmMKUlVOIHRvdWNoIC4vc3JjL21haW4ucnMKUlVOIHRvdWNoIC4vc3JjL2xpYi5ycwoKV09SS0RJUiAvdXNyL3NyYy9yb3V0ZXIKIyBHZXQgdGhlIGRlcGVuZGVuY2llcyBjYWNoZWQsIHNvIHdlIGNhbiB1c2UgZHVtbXkgaW5wdXQgZmlsZXMgc28gQ2FyZ28gd29udCBmYWlsClJVTiBlY2hvICdmbiBtYWluKCkgeyBwcmludGxuISgiIik7IH0nID4gLi9zcmMvbWFpbi5ycwpSVU4gZWNobyAnZm4gbWFpbigpIHsgcHJpbnRsbiEoIiIpOyB9JyA+IC4vc3JjL2xpYi5ycwpSVU4gY2FyZ28gYnVpbGQgLS1yZWxlYXNlCgojIENvcHkgaW4gdGhlIGFjdHVhbCBzb3VyY2UgY29kZQpDT1BZIC0tZnJvbT1yb3V0ZXJfcGtnIHNyYyAuL3NyYwpSVU4gdG91Y2ggLi9zcmMvbWFpbi5ycwpSVU4gdG91Y2ggLi9zcmMvbGliLnJzCgojIFJlYWwgYnVpbGQgdGhpcyB0aW1lClJVTiBjYXJnbyBidWlsZCAtLXJlbGVhc2UKCiMgUnVudGltZQpGUk9NIGRlYmlhbjpib29rd29ybS1zbGltIEFTIHJ1bnRpbWUKClJVTiBhcHQtZ2V0IHVwZGF0ZQpSVU4gYXB0LWdldCAteSBpbnN0YWxsIGNhLWNlcnRpZmljYXRlcwpSVU4gcm0gLXJmIC92YXIvbGliL2FwdC9saXN0cy8qCgpMQUJFTCBvcmcub3BlbmNvbnRhaW5lcnMuaW1hZ2UudGl0bGU9JElNQUdFX1RJVExFCkxBQkVMIG9yZy5vcGVuY29udGFpbmVycy5pbWFnZS52ZXJzaW9uPSRSRUxFQVNFCkxBQkVMIG9yZy5vcGVuY29udGFpbmVycy5pbWFnZS5kZXNjcmlwdGlvbj0kSU1BR0VfREVTQ1JJUFRJT04KTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLmF1dGhvcnM9IlRoZSBHdWlsZCIKTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLnZlbmRvcj0iS2FtaWwgS2lzaWVsYSIKTEFCRUwgb3JnLm9wZW5jb250YWluZXJzLmltYWdlLnVybD0iaHR0cHM6Ly9naXRodWIuY29tL2dyYXBocWwtaGl2ZS9jb25zb2xlIgpMQUJFTCBvcmcub3BlbmNvbnRhaW5lcnMuaW1hZ2Uuc291cmNlPSJodHRwczovL2dpdGh1Yi5jb20vZ3JhcGhxbC1oaXZlL2NvbnNvbGUiCgpSVU4gbWtkaXIgLXAgL2Rpc3QvY29uZmlnClJVTiBta2RpciAvZGlzdC9zY2hlbWEKCiMgQ29weSBpbiB0aGUgcmVxdWlyZWQgZmlsZXMgZnJvbSBvdXIgYnVpbGQgaW1hZ2UKQ09QWSAtLWZyb209YnVpbGQgLS1jaG93bj1yb290OnJvb3QgL3Vzci9zcmMvcm91dGVyL3RhcmdldC9yZWxlYXNlL3JvdXRlciAvZGlzdApDT1BZIC0tZnJvbT1yb3V0ZXJfcGtnIHJvdXRlci55YW1sIC9kaXN0L2NvbmZpZy9yb3V0ZXIueWFtbAoKV09SS0RJUiAvZGlzdAoKRU5WIEFQT0xMT19ST1VURVJfQ09ORklHX1BBVEg9Ii9kaXN0L2NvbmZpZy9yb3V0ZXIueWFtbCIKCkVOVFJZUE9JTlQgWyIuL3JvdXRlciJdCg==",
"language": "Dockerfile"
},
"range": [
{
"start": {
"line": 58
},
"end": {
"line": 58
}
}
]
}
]
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
serviceVersionfor hive tracing is 0.0.0, should we do something about it? it was unset previouslyansi-colorto the buildOptions.external list of a bunch of services because they were failing to build.ansi-coloris a dep of the gateway. Is it ok? Why is it even attempting to buildansi-color?