fix(response-cache): extra __typename props in the execution result (#1873)

Author: ardatan

.changeset/dull-maps-care.md

@@ -0,0 +1,5 @@
+---
+'@envelop/response-cache': patch
+---
+
+Do not revisit cached parser result which adds extra \_\_typename properties in the execution result

packages/plugins/response-cache/src/plugin.ts

@@ -251,7 +251,7 @@ export function useResponseCache<PluginContext extends Record<string, any> = {}>
   return {
     onParse() {
       return ({ result, replaceParseResult }) => {
-        if (result.kind === Kind.DOCUMENT) {
+        if (!originalDocumentMap.has(result) && result.kind === Kind.DOCUMENT) {
           const newDocument = addTypeNameToDocument(result);
           replaceParseResult(newDocument);
         }

packages/plugins/response-cache/test/response-cache.spec.ts

@@ -1466,7 +1466,6 @@ describe('useResponseCache', () => {
   });
 
   it.skip('cache is purged upon mutation even when error is included in the mutation execution result', async () => {
-    3;
     const spy = jest.fn(() => [
       {
         id: 1,
@@ -2003,6 +2002,51 @@ describe('useResponseCache', () => {
         ttl: Infinity,
       });
     });
+
+    it('works with parse caching', async () => {
+      const schema = makeExecutableSchema({
+        typeDefs: /* GraphQL */ `
+          type Query {
+            foo: String
+          }
+        `,
+        resolvers: {
+          Query: {
+            foo: () => 'bar',
+          },
+        },
+      });
+      const operation = /* GraphQL */ `
+        query {
+          foo
+        }
+      `;
+      const testkit = createTestkit(
+        [
+          useResponseCache({
+            session: () => null,
+            ttl: 0,
+          }),
+          useParserCache(),
+        ],
+        schema,
+      );
+
+      const result = await testkit.execute(operation);
+      assertSingleExecutionValue(result);
+      expect(result).toEqual({
+        data: {
+          foo: 'bar',
+        },
+      });
+      const cachedResult = await testkit.execute(operation);
+      assertSingleExecutionValue(result);
+      expect(cachedResult).toEqual({
+        data: {
+          foo: 'bar',
+        },
+      });
+    });
   });
 
   describe('ignoring and ttl per type for types without id field', () => {
@@ -2194,6 +2238,7 @@ describe('useResponseCache', () => {
           onExecute({ setExecuteFn }) {
             setExecuteFn(() => ({
               data: {
+                __typename: 'Query',
                 foo: 'bar',
               },
               extensions: {
@@ -2249,6 +2294,7 @@ describe('useResponseCache', () => {
           onExecute({ setExecuteFn }) {
             setExecuteFn(() => ({
               data: {
+                __typename: 'Query',
                 foo: 'bar',
               },
               extensions: {