-
Notifications
You must be signed in to change notification settings - Fork 133
Open
Labels
kind/enhancementNew feature or requestNew feature or requeststage/4-pull-requestA pull request has been opened that aims to solve the issueA pull request has been opened that aims to solve the issue
Description
Issue workflow progress
Progress of the issue based on the
Contributor Workflow
- 1. The issue provides a
minimal reproduction available on
Stackblitz.- Please install the latest
@envelop/*
packages that you are using. - Please make sure the reproduction is as small as possible.
- Please install the latest
- 2. A failing test has been provided
- 3. A local solution has been provided
- 4. A pull request is pending review
Describe the bug
The useErrorHandler
plugin does not check for incremental responses in the execution phase, so any errors that happen in incremental payloads are missed.
To Reproduce Steps to reproduce the behavior:
- Add
@defer
directive to schema - Add
useErrorHandler
plugin that logs execution phase errors - Query a field that throws an error with the
@defer
directive - Error handler is never called
Stackblitz repro: https://stackblitz.com/edit/node-eeltu1?file=start.js
If you run npm run start
, no errors will be logged. If the @defer
directive is removed from the query, then it is logged.
Environment:
- OS: Mac
- NodeJS: 20.7.0
@envelop/*
versions:@envelop/core
:5.0.0
Metadata
Metadata
Assignees
Labels
kind/enhancementNew feature or requestNew feature or requeststage/4-pull-requestA pull request has been opened that aims to solve the issueA pull request has been opened that aims to solve the issue