Add a use case when fields of elements in a union conflict (#96)

ardatan · kamilkisiela · web-flow · commit 3bb84adc1768 · 2025-06-12T09:29:39.000+02:00
Related graphql-hive/gateway#471 --------- Co-authored-by: Kamil Kisiela <kamil.kisiela@gmail.com>
diff --git a/README.md b/README.md
@@ -10,12 +10,12 @@ This repository contains a set of tests to evaluate and compare the compatibilit
 
 |                             Gateway                             | Compatibility |  Test Cases  | Test Suites |
 | :-------------------------------------------------------------: | :-----------: | :----------: | :---------: |
-| [Hive Gateway](https://the-guild.dev/graphql/hive/docs/gateway) |    100.00%    |    🟢 186    |    🟢 41    |
-|         [Apollo Router](https://www.apollographql.com/)         |    97.85%     | 🟢 182 ❌ 4  | 🟢 39 ❌ 2  |
-|        [Apollo Gateway](https://www.apollographql.com/)         |    97.31%     | 🟢 181 ❌ 5  | 🟢 38 ❌ 3  |
-|             [Cosmo Router](https://wundergraph.com)             |    95.16%     | 🟢 177 ❌ 9  | 🟢 36 ❌ 5  |
-|            [Grafbase Gateway](https://grafbase.com)             |    90.86%     | 🟢 169 ❌ 17 | 🟢 35 ❌ 6  |
-|                [Inigo Gateway](https://inigo.io)                |    48.92%     | 🟢 91 ❌ 95  | 🟢 12 ❌ 29 |
+| [Hive Gateway](https://the-guild.dev/graphql/hive/docs/gateway) |    100.00%    |    🟢 187    |    🟢 41    |
+|         [Apollo Router](https://www.apollographql.com/)         |    97.86%     | 🟢 183 ❌ 4  | 🟢 39 ❌ 2  |
+|        [Apollo Gateway](https://www.apollographql.com/)         |    97.33%     | 🟢 182 ❌ 5  | 🟢 38 ❌ 3  |
+|             [Cosmo Router](https://wundergraph.com)             |    95.19%     | 🟢 178 ❌ 9  | 🟢 36 ❌ 5  |
+|            [Grafbase Gateway](https://grafbase.com)             |    90.91%     | 🟢 170 ❌ 17 | 🟢 35 ❌ 6  |
+|                [Inigo Gateway](https://inigo.io)                |    48.66%     | 🟢 91 ❌ 96  | 🟢 12 ❌ 29 |
 
 <!-- gateways:end -->
 
diff --git a/REPORT.md b/REPORT.md
@@ -4,12 +4,12 @@
 
 |                             Gateway                             | Compatibility |  Test Cases  | Test Suites |
 | :-------------------------------------------------------------: | :-----------: | :----------: | :---------: |
-| [Hive Gateway](https://the-guild.dev/graphql/hive/docs/gateway) |    100.00%    |    🟢 186    |    🟢 41    |
-|         [Apollo Router](https://www.apollographql.com/)         |    97.85%     | 🟢 182 ❌ 4  | 🟢 39 ❌ 2  |
-|        [Apollo Gateway](https://www.apollographql.com/)         |    97.31%     | 🟢 181 ❌ 5  | 🟢 38 ❌ 3  |
-|             [Cosmo Router](https://wundergraph.com)             |    95.16%     | 🟢 177 ❌ 9  | 🟢 36 ❌ 5  |
-|            [Grafbase Gateway](https://grafbase.com)             |    90.86%     | 🟢 169 ❌ 17 | 🟢 35 ❌ 6  |
-|                [Inigo Gateway](https://inigo.io)                |    48.92%     | 🟢 91 ❌ 95  | 🟢 12 ❌ 29 |
+| [Hive Gateway](https://the-guild.dev/graphql/hive/docs/gateway) |    100.00%    |    🟢 187    |    🟢 41    |
+|         [Apollo Router](https://www.apollographql.com/)         |    97.86%     | 🟢 183 ❌ 4  | 🟢 39 ❌ 2  |
+|        [Apollo Gateway](https://www.apollographql.com/)         |    97.33%     | 🟢 182 ❌ 5  | 🟢 38 ❌ 3  |
+|             [Cosmo Router](https://wundergraph.com)             |    95.19%     | 🟢 178 ❌ 9  | 🟢 36 ❌ 5  |
+|            [Grafbase Gateway](https://grafbase.com)             |    90.91%     | 🟢 170 ❌ 17 | 🟢 35 ❌ 6  |
+|                [Inigo Gateway](https://inigo.io)                |    48.66%     | 🟢 91 ❌ 96  | 🟢 12 ❌ 29 |
 
 ## Detailed Results
 
@@ -27,7 +27,7 @@ You can look at the full list of tests [here](./src/test-suites/). Every test id
 <details>
 <summary>Results</summary>
 <a href="./src/test-suites/abstract-types">abstract-types</a>
-<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
+<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/child-type-mismatch">child-type-mismatch</a>
 <pre>🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/circular-reference-interface">circular-reference-interface</a>
@@ -120,7 +120,7 @@ You can look at the full list of tests [here](./src/test-suites/). Every test id
 <details>
 <summary>Results</summary>
 <a href="./src/test-suites/abstract-types">abstract-types</a>
-<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
+<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/child-type-mismatch">child-type-mismatch</a>
 <pre>🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/circular-reference-interface">circular-reference-interface</a>
@@ -213,7 +213,7 @@ You can look at the full list of tests [here](./src/test-suites/). Every test id
 <details>
 <summary>Results</summary>
 <a href="./src/test-suites/abstract-types">abstract-types</a>
-<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
+<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/child-type-mismatch">child-type-mismatch</a>
 <pre>🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/circular-reference-interface">circular-reference-interface</a>
@@ -306,7 +306,7 @@ You can look at the full list of tests [here](./src/test-suites/). Every test id
 <details>
 <summary>Results</summary>
 <a href="./src/test-suites/abstract-types">abstract-types</a>
-<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
+<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/child-type-mismatch">child-type-mismatch</a>
 <pre>❌❌❌🟢</pre>
 <a href="./src/test-suites/circular-reference-interface">circular-reference-interface</a>
@@ -399,7 +399,7 @@ You can look at the full list of tests [here](./src/test-suites/). Every test id
 <details>
 <summary>Results</summary>
 <a href="./src/test-suites/abstract-types">abstract-types</a>
-<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
+<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/child-type-mismatch">child-type-mismatch</a>
 <pre>🟢🟢🟢🟢</pre>
 <a href="./src/test-suites/circular-reference-interface">circular-reference-interface</a>
@@ -492,7 +492,7 @@ You can look at the full list of tests [here](./src/test-suites/). Every test id
 <details>
 <summary>Results</summary>
 <a href="./src/test-suites/abstract-types">abstract-types</a>
-<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢❌❌</pre>
+<pre>🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢🟢❌❌❌</pre>
 <a href="./src/test-suites/child-type-mismatch">child-type-mismatch</a>
 <pre>❌❌❌🟢</pre>
 <a href="./src/test-suites/circular-reference-interface">circular-reference-interface</a>
diff --git a/gateways/apollo-gateway/results.txt b/gateways/apollo-gateway/results.txt
@@ -1,5 +1,5 @@
 abstract-types
-.................
+..................
 child-type-mismatch
 ....
 circular-reference-interface
@@ -82,6 +82,6 @@ union-intersection
 ............
 
 ---
-Total: 186
-Passed: 181
+Total: 187
+Passed: 182
 Failed: 5
diff --git a/gateways/apollo-router/results.txt b/gateways/apollo-router/results.txt
@@ -1,5 +1,5 @@
 abstract-types
-.................
+..................
 child-type-mismatch
 ....
 circular-reference-interface
@@ -82,6 +82,6 @@ union-intersection
 ............
 
 ---
-Total: 186
-Passed: 182
+Total: 187
+Passed: 183
 Failed: 4
diff --git a/gateways/cosmo-router/results.txt b/gateways/cosmo-router/results.txt
@@ -1,5 +1,5 @@
 abstract-types
-.................
+..................
 child-type-mismatch
 XXX.
 circular-reference-interface
@@ -82,6 +82,6 @@ union-intersection
 ............
 
 ---
-Total: 186
-Passed: 177
+Total: 187
+Passed: 178
 Failed: 9
diff --git a/gateways/grafbase-gateway/results.txt b/gateways/grafbase-gateway/results.txt
@@ -1,5 +1,5 @@
 abstract-types
-.................
+..................
 child-type-mismatch
 ....
 circular-reference-interface
@@ -82,6 +82,6 @@ union-intersection
 ........X..X
 
 ---
-Total: 186
-Passed: 169
+Total: 187
+Passed: 170
 Failed: 17
diff --git a/gateways/hive-gateway/results.txt b/gateways/hive-gateway/results.txt
@@ -1,5 +1,5 @@
 abstract-types
-.................
+..................
 child-type-mismatch
 ....
 circular-reference-interface
@@ -82,6 +82,6 @@ union-intersection
 ............
 
 ---
-Total: 186
-Passed: 186
+Total: 187
+Passed: 187
 Failed: 0
diff --git a/gateways/inigo-gateway/results.txt b/gateways/inigo-gateway/results.txt
@@ -1,5 +1,5 @@
 abstract-types
-...............XX
+...............XXX
 child-type-mismatch
 XXX.
 circular-reference-interface
@@ -82,6 +82,6 @@ union-intersection
 XXXXXXXXX.XX
 
 ---
-Total: 186
+Total: 187
 Passed: 91
-Failed: 95
+Failed: 96
diff --git a/src/test-suites/abstract-types/agency.subgraph.ts b/src/test-suites/abstract-types/agency.subgraph.ts
@@ -9,11 +9,17 @@ export default createSubgraph("agency", {
     type Agency @key(fields: "id") {
       id: ID!
       companyName: String
+      email: Email
+    }
+
+    type Email {
+      address: String
     }
 
     type Group @key(fields: "id") {
       id: ID!
       name: String
+      email: String
     }
 
     extend union PublisherType = Agency | Group
@@ -26,7 +32,7 @@ export default createSubgraph("agency", {
     },
     Group: {
       __resolveReference(key: { id: string }) {
-        return { id: key.id, name: "Group " + key.id };
+        return { id: key.id, name: "Group " + key.id, email: "group" + key.id + "@example.com" };
       },
     },
   },
diff --git a/src/test-suites/abstract-types/data.ts b/src/test-suites/abstract-types/data.ts
@@ -113,5 +113,8 @@ export const agencies = [
   {
     id: "a1",
     companyName: "Agency 1",
+    email: {
+      address: 'a1@example.com'
+    }
   },
 ] as const;
diff --git a/src/test-suites/abstract-types/test.ts b/src/test-suites/abstract-types/test.ts
diff --git a/website/data.json b/website/data.json
diff --git a/website/index.html b/website/index.html

Original file line number	Diff line number	Diff line change
`@@ -113,5 +113,8 @@ export const agencies = [`
`113`	`113`	`{`
`114`	`114`	`id: "a1",`
`115`	`115`	`companyName: "Agency 1",`
	`116`	`+ email: {`
	`117`	`+ address: '[email protected]'`
	`118`	`+ }`
`116`	`119`	`},`
`117`	`120`	`] as const;`