actual test

Author: enisdenjo

src/test-suites/i-will-name-you-later/a.subgraph.ts

@@ -1,5 +1,5 @@
 import { createSubgraph } from "../../subgraph.js";
-import { comments, posts } from "./data.js";
+import { authors, posts } from "./data.js";
 
 export default createSubgraph("a", {
   typeDefs: /* GraphQL */ `
@@ -15,13 +15,14 @@ export default createSubgraph("a", {
 
     type Post @key(fields: "id") {
       id: ID!
-      isJohn: Boolean @external
-      isNotJohn: Boolean @requires(fields: "isJohn")
+      byNovice: Boolean! @external
+      byExpert: Boolean! @requires(fields: "byNovice")
     }
 
     type Author @key(fields: "id") {
       id: ID!
       name: String!
+      yearsOfExperience: Int!
     }
   `,
   resolvers: {
@@ -31,49 +32,39 @@ export default createSubgraph("a", {
       },
     },
     Post: {
-      __resolveReference(key: { id: string }) {
-        const post = posts.find((post) => post.id === key.id);
-
+      __resolveReference(ref: { id: string; byNovice?: boolean }) {
+        const post = posts.find((post) => post.id === ref.id);
         if (!post) {
           return null;
         }
-
+        if (ref.byNovice == null) {
+          return {
+            id: post.id,
+          };
+        }
         return {
           id: post.id,
+          byNovice: ref.byNovice,
         };
       },
-      comments(post: { id: string }, { limit }: { limit: number }) {
-        return comments
-          .filter((comment) => comment.postId === post.id)
-          .slice(0, limit)
-          .map((c) => ({
-            id: c.id,
-            authorId: c.authorId,
-            body: c.body,
-          }));
+      byExpert(post: { byNovice: boolean }) {
+        if (post.byNovice == null) {
+          // ensuring requires is not skipped
+          return null;
+        }
+        return !post.byNovice;
       },
     },
-    Comment: {
-      __resolveReference(ref: {
-        id: string;
-        sameCommentOnOtherPosts?: { comments: { id: string }[] }[];
-      }) {
-        const comment = comments.find((c) => c.id === ref.id);
-
-        if (!comment) {
+    Author: {
+      __resolveReference(ref: { id: string }) {
+        const author = authors.find((author) => author.id === ref.id);
+        if (!author) {
           return null;
         }
-
         return {
-          id: comment.id,
-          authorId: comment.authorId,
-          body: comment.body,
-          isCommentSpam: ref.sameCommentOnOtherPosts?.length
-            ? ref.sameCommentOnOtherPosts?.every((p) =>
-                // making sure that the ref contains the full "@requires"
-                p.comments.every((c) => c.id)
-              )
-            : false,
+          id: author.id,
+          name: author.name,
+          yearsOfExperience: author.yearsOfExperience,
         };
       },
     },

src/test-suites/i-will-name-you-later/b.subgraph.ts

@@ -1,5 +1,5 @@
 import { createSubgraph } from "../../subgraph.js";
-import { authors, comments, posts } from "./data.js";
+import { posts } from "./data.js";
 
 export default createSubgraph("b", {
   typeDefs: /* GraphQL */ `
@@ -11,89 +11,35 @@ export default createSubgraph("b", {
 
     type Post @key(fields: "id") {
       id: ID!
-      author: Author
-      isJohn: Boolean @requires(fields: "author { name }")
+      author: Author!
+      byNovice: Boolean! @requires(fields: "author { yearsOfExperience }")
     }
 
     type Author @key(fields: "id") {
       id: ID!
-      name: String! @external
+      yearsOfExperience: Int! @external
     }
   `,
   resolvers: {
     Post: {
-      __resolveReference(key: {
+      __resolveReference(ref: {
         id: string;
-        comments?: Array<{ authorId: string }>;
+        author?: { yearsOfExperience: number };
       }) {
-        const post = posts.find((p) => p.id === key.id);
-
+        const post = posts.find((post) => post.id === ref.id);
         if (!post) {
           return null;
         }
-
-        if (key.comments) {
-          if (key.comments.length !== 3) {
-            throw new Error("Expected 3 comments");
-          }
-
-          return {
-            id: post.id,
-            authorId: key.comments?.[2].authorId,
-          };
-        }
-
         return {
           id: post.id,
+          author: {
+            id: post.author.id,
+            ...ref.author,
+          },
         };
       },
-      author(post: { authorId?: string }) {
-        if (!post.authorId) {
-          return null;
-        }
-
-        const author = authors.find((a) => a.id === post.authorId);
-
-        if (!author) {
-          return null;
-        }
-
-        return {
-          id: author.id,
-          name: author.name,
-        };
-      },
-      comments(post: { id: string }, { limit }: { limit: number }) {
-        const coms = comments
-          .filter((comment) => comment.postId === post.id)
-          .slice(0, limit)
-          .map((c) => ({
-            id: c.id,
-          }));
-
-        return coms;
-      },
-    },
-    Comment: {
-      __resolveReference(key: { id: string }) {
-        const comment = comments.find((c) => c.id === key.id);
-
-        if (!comment) {
-          return null;
-        }
-
-        return {
-          id: comment.id,
-        };
-      },
-      sameCommentOnOtherPosts({ id: commentId }: { id: string }) {
-        const comment = comments.find((c) => c.id === commentId);
-        if (!comment) {
-          return [];
-        }
-        return comments
-          .filter((c) => c.body === comment.body && c.postId !== comment.postId)
-          .map((c) => ({ id: c.postId }));
+      byNovice(post: { author: { yearsOfExperience: number } }) {
+        return post.author.yearsOfExperience < 10;
       },
     },
   },

src/test-suites/i-will-name-you-later/data.ts

@@ -1,81 +1,25 @@
-export const products = [
+export const authors = [
   {
-    upc: "p1",
-    name: "p-name-1",
-    price: 11,
-    weight: 1,
-    category: {
-      averagePrice: 11,
-    },
+    id: "a1",
+    name: "John",
+    yearsOfExperience: 5,
   },
   {
-    upc: "p2",
-    name: "p-name-2",
-    price: 22,
-    weight: 2,
-    category: {
-      averagePrice: 22,
-    },
+    id: "a2",
+    name: "Jane",
+    yearsOfExperience: 20,
   },
 ];
 
 export const posts = [
   {
     id: "p1",
     body: "p1-body",
+    author: authors[0],
   },
   {
     id: "p2",
     body: "p2-body",
-  },
-];
-
-export const comments = [
-  {
-    id: "c1",
-    postId: "p1",
-    authorId: "a2",
-    body: "c1-body",
-  },
-  {
-    id: "c2",
-    postId: "p1",
-    authorId: "a2",
-    body: "c2-body",
-  },
-  {
-    id: "c3",
-    postId: "p1",
-    authorId: "a2",
-    body: "c3-body",
-  },
-  {
-    id: "c4",
-    postId: "p2",
-    authorId: "a1",
-    body: "c4-body",
-  },
-  {
-    id: "c5",
-    postId: "p2",
-    authorId: "a1",
-    body: "c5-body",
-  },
-  {
-    id: "c6",
-    postId: "p2",
-    authorId: "a1",
-    body: "c6-body",
-  },
-];
-
-export const authors = [
-  {
-    id: "a1",
-    name: "a1-name",
-  },
-  {
-    id: "a2",
-    name: "a2-name",
+    author: authors[1],
   },
 ];

src/test-suites/i-will-name-you-later/test.ts

@@ -5,24 +5,39 @@ export default [
     /* GraphQL */ `
       {
         feed {
-          author {
-            id
-          }
+          byNovice
         }
       }
     `,
     {
       data: {
         feed: [
           {
-            author: {
-              id: "a2",
-            },
+            byNovice: true,
           },
           {
-            author: {
-              id: "a1",
-            },
+            byNovice: false,
+          },
+        ],
+      },
+    }
+  ),
+  createTest(
+    /* GraphQL */ `
+      {
+        feed {
+          byExpert
+        }
+      }
+    `,
+    {
+      data: {
+        feed: [
+          {
+            byExpert: false,
+          },
+          {
+            byExpert: true,
           },
         ],
       },