legacylogger tests and fixes

Author: enisdenjo

packages/logger/src/LegacyLogger.ts

@@ -18,7 +18,11 @@ export class LegacyLogger {
 
   #log(level: LogLevel, ...[maybeMsgOrArg, ...restArgs]: any[]) {
     if (typeof maybeMsgOrArg === 'string') {
-      this.#logger.log(level, restArgs, maybeMsgOrArg);
+      if (restArgs.length) {
+        this.#logger.log(level, restArgs, maybeMsgOrArg);
+      } else {
+        this.#logger.log(level, maybeMsgOrArg);
+      }
     } else {
       if (restArgs.length) {
         this.#logger.log(level, [maybeMsgOrArg, ...restArgs]);
@@ -53,9 +57,11 @@ export class LegacyLogger {
   }
 
   child(name: string | Record<string, string | number>): LegacyLogger {
-    name = stringifyName(name);
-    if (this.#logger.prefix?.includes(name)) {
-      // TODO: why do we do this?
+    name =
+      stringifyName(name) +
+      // append space if object is strigified to space out the prefix
+      (typeof name === 'object' ? ' ' : '');
+    if (this.#logger.prefix === name) {
       return this;
     }
     return LegacyLogger.from(this.#logger.child(name));

packages/logger/tests/LegacyLogger.test.ts

@@ -0,0 +1,90 @@
+import { LegacyLogger } from '@graphql-hive/logger';
+import { expect, it } from 'vitest';
+import { Logger, LoggerOptions } from '../src/Logger';
+import { MemoryLogWriter } from '../src/writers';
+
+function createTLogger(opts?: Partial<LoggerOptions>) {
+  const writer = new MemoryLogWriter();
+  return [
+    LegacyLogger.from(
+      new Logger({ ...opts, writers: opts?.writers ? opts.writers : [writer] }),
+    ),
+    writer,
+  ] as const;
+}
+
+it('should correctly write legacy logger logs', () => {
+  const [log, writer] = createTLogger();
+
+  log.info('hello world');
+  log.info({ hello: 'world' });
+  log.info('hello', { wor: 'ld' });
+  log.info('hello', [{ wor: 'ld' }]);
+  log.info('hello', { w: 'o' }, { rl: 'd' });
+  log.info('hello', 'world');
+
+  log.child('child ').info('hello child');
+  log.child({ chi: 'ld' }).info('hello chi ld');
+
+  expect(writer.logs).toMatchInlineSnapshot(`
+    [
+      {
+        "level": "info",
+        "msg": "hello world",
+      },
+      {
+        "attrs": {
+          "hello": "world",
+        },
+        "level": "info",
+      },
+      {
+        "attrs": [
+          {
+            "wor": "ld",
+          },
+        ],
+        "level": "info",
+        "msg": "hello",
+      },
+      {
+        "attrs": [
+          [
+            {
+              "wor": "ld",
+            },
+          ],
+        ],
+        "level": "info",
+        "msg": "hello",
+      },
+      {
+        "attrs": [
+          {
+            "w": "o",
+          },
+          {
+            "rl": "d",
+          },
+        ],
+        "level": "info",
+        "msg": "hello",
+      },
+      {
+        "attrs": [
+          "world",
+        ],
+        "level": "info",
+        "msg": "hello",
+      },
+      {
+        "level": "info",
+        "msg": "child hello child",
+      },
+      {
+        "level": "info",
+        "msg": "chi=ld hello chi ld",
+      },
+    ]
+  `);
+});