Skip to content

Commit 25314f6

Browse files
committed
typoes explanations and stuff
1 parent ac3ca06 commit 25314f6

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

internal/perf/src/heapsnapshot.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ export interface HeapSnapshotDiff {
1010
* consecutively and filters the results to only include objects that have a positive
1111
* size delta (grew in size) in **every** snapshot, possibly indicating a leak.
1212
*
13+
* To make accurete results, there should be at least three heap snapshots provided.
14+
*
1315
* Note that this is a heuristic and may not always indicate a leak, some objects may
1416
* legitimately grow in size or count over time.
1517
*/

internal/perf/src/memtest.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ const supportedFlags = [
2727
* Allows controlling the memtest runs with the `MEMTEST` environment variable.
2828
*
2929
* {@link supportedFlags Supported flags} are:
30-
* - `rapid` Runs the loadtest for `10s` and the calmdown for `5s` instead of the defaults.
3130
* - `short` Runs the loadtest for `30s` and the calmdown for `10s` instead of the defaults.
3231
* - `cleanheapsnaps` Remove any existing heap snapshot (`*.heapsnapshot`) files before the test.
3332
* - `noheapsnaps` Disable taking heap snapshots.
@@ -66,7 +65,8 @@ export interface MemtestOptions
6665
* Whether to take heap snapshots on the end of the `idle` phase and then at the end
6766
* of the `calmdown` {@link LoadtestPhase phase} in each of the {@link runs}.
6867
*
69-
* Ignores the `default` and runs with `false` if {@link flags MEMTEST has the `noheapsnaps` flag}.
68+
* Ignores the _@default_ and runs with `false` if {@link flags MEMTEST} has the `noheapsnaps`
69+
* flag provided.
7070
*
7171
* @default true
7272
*/
@@ -80,24 +80,26 @@ export interface MemtestOptions
8080
/**
8181
* Duration of the loadtest for each {@link runs run} in milliseconds.
8282
*
83-
* Ignores the `default` and runs for `10s`.
83+
* Ignores the _@default_ and runs for `10s` if {@link flags MEMTEST} has the `short`
84+
* flag provided.
8485
*
8586
* @default 30_000
8687
*/
8788
duration?: number;
8889
/**
8990
* Calmdown duration after loadtesting {@link runs run} in milliseconds.
9091
*
91-
* Ignores the `default` and runs for `5s` if {@link flags MEMTEST} has the `short`
92-
* flag.
92+
* Ignores the _@default_ and runs for `5s` if {@link flags MEMTEST} has the `short`
93+
* flag provided.
9394
*
9495
* @default 10_000
9596
*/
9697
calmdown?: number;
9798
/**
9899
* How many times to run the loadtests?
99100
*
100-
* Ignores the `default` and does `10` runs if {@link flags MEMTEST has the `moreruns` flag}.
101+
* Ignores the _@default_ and does `10` runs if {@link flags MEMTEST} has the `moreruns`
102+
* flag provided.
101103
*
102104
* @default 5
103105
*/

internal/perf/tests/heapsnapshot.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ it.skipIf(
6868
// no need to test in bun (also, bun does not support increasing timeouts per test)
6969
globalThis.Bun,
7070
)(
71-
'should detect a small leak in a forver growing array',
71+
'should detect a small leak in a forever growing array',
7272
{
7373
// parsing snapshots can take a while, so we increase the timeout
7474
timeout: 30_000,

0 commit comments

Comments
 (0)