fix(@graphql-mesh/transport-http): infinite loop on subscriptions without kind (#1385)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: EmrysMyrddin

.changeset/fast-parrots-breathe.md

@@ -0,0 +1,5 @@
+---
+'@graphql-mesh/transport-http': patch
+---
+
+Fix an infinite loop when providing options for subscriptions transport of subgraphs using HTTP transport for both queries/mutations and subscrpitions.

packages/transports/http/src/index.ts

@@ -107,6 +107,9 @@ export default {
               options: {
                 ...payload.transportEntry.options,
                 ...payload.transportEntry.options?.subscriptions?.options,
+                // Make sure to remove subscription option to avoid infinite loop.
+                // This option doesn't make sense here but is present in `transportEntry.options`
+                subscriptions: undefined,
               },
             }),
           (resolvedSubscriptionsExecutor) => {

packages/transports/http/tests/http.spec.ts

@@ -1,5 +1,6 @@
+import { TransportEntry } from '@graphql-mesh/transport-common';
 import type { MeshFetch } from '@graphql-mesh/types';
-import { buildSchema, parse } from 'graphql';
+import { buildSchema, OperationTypeNode, parse } from 'graphql';
 import { describe, expect, it, vi } from 'vitest';
 import httpTransport from '../src';
 
@@ -14,22 +15,25 @@ describe('HTTP Transport', () => {
       }),
     );
     const expectedToken = 'wowmuchsecret';
-    const executor = httpTransport.getSubgraphExecutor({
-      subgraphName,
-      transportEntry: {
-        kind: 'http',
-        subgraph: subgraphName,
-        headers: [['x-test', '{context.myToken}']],
-      },
-      fetch,
-      // @ts-expect-error - transport kind is const in httpTransport but string is expected
-      transportExecutorFactoryGetter: () => httpTransport.getSubgraphExecutor,
-      subgraph: buildSchema(/* GraphQL */ `
-        type Query {
-          test: String
-        }
-      `),
+    const getTransportExecutor = (transportEntry: TransportEntry) =>
+      httpTransport.getSubgraphExecutor({
+        subgraphName,
+        transportEntry,
+        fetch,
+        getTransportExecutor,
+        subgraph: buildSchema(/* GraphQL */ `
+          type Query {
+            test: String
+          }
+        `),
+      });
+
+    const executor = getTransportExecutor({
+      kind: 'http',
+      subgraph: subgraphName,
+      headers: [['x-test', '{context.myToken}']],
     });
+
     await executor({
       document: parse(/* GraphQL */ `
         query {
@@ -46,4 +50,48 @@ describe('HTTP Transport', () => {
       },
     });
   });
+
+  it('should allow to specify subscription specific options', async () => {
+    const fetch = vi.fn<MeshFetch>();
+
+    const getTransportExecutor = (transportEntry: TransportEntry) =>
+      httpTransport.getSubgraphExecutor({
+        subgraphName,
+        transportEntry,
+        fetch,
+        getTransportExecutor,
+        subgraph: buildSchema(/* GraphQL */ `
+          type Subscription {
+            test: String
+          }
+        `),
+      });
+
+    const executor = getTransportExecutor({
+      kind: 'http',
+      subgraph: subgraphName,
+      options: {
+        subscriptions: {
+          kind: 'http',
+          subgraph: subgraphName,
+          options: {
+            method: 'POST',
+          },
+        },
+      },
+    });
+
+    await executor({
+      operationType: OperationTypeNode.SUBSCRIPTION,
+      document: parse(/* GraphQL */ `
+        subscription {
+          test
+        }
+      `),
+    });
+
+    expect(fetch.mock.calls[0]?.[1]).toMatchObject({
+      method: 'POST',
+    });
+  });
 });