Skip to content

Commit 344dd9d

Browse files
authored
Expected heavy frame in whatwg-node wrapping (#1295)
1 parent 33f526e commit 344dd9d

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

e2e/federation-subscriptions-passthrough/federation-subscriptions-passthrough.memtest.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,6 @@ describe('upstream subscriptions via http callbacks', () => {
5757
}
5858
`,
5959
allowFailingRequests: true,
60-
expectedHeavyFrame: (frame) =>
61-
// allocates a lot but all is freed confirmed through heap snapshot
62-
frame.callstack.some((frame) =>
63-
frame.name.includes('wrapIncomingMessageWithPassthrough'),
64-
),
6560
},
6661
async () => {
6762
const availablePort = await getAvailablePort();

internal/perf/src/memtest.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,14 @@ export function memtest(opts: MemtestOptions, setup: () => Promise<Server>) {
230230
frame.callstack.some(
231231
(stack) => stack.name === 'handleMaybePromise',
232232
)
233+
) &&
234+
!(
235+
// allocates a lot but all is freed confirmed through heap snapshot
236+
frame.callstack.some(
237+
(frame) =>
238+
frame.file?.includes('@whatwg-node/node-fetch') &&
239+
frame.name.includes('wrapIncomingMessageWithPassthrough'),
240+
)
233241
),
234242
)
235243
.filter((frame) => {

0 commit comments

Comments
 (0)