copy error count and code for parse, validate and execute

Author: EmrysMyrddin

packages/plugins/opentelemetry/src/hive-span-processor.ts

@@ -151,9 +151,12 @@ export class HiveTracingSpanProcessor implements SpanProcessor {
       return;
     }
 
-    if (span.name === 'graphql.execute') {
+    if (SPANS_WITH_ERRORS.includes(span.name)) {
       copyAttribute(span, operationSpan, SEMATTRS_HIVE_GRAPHQL_ERROR_CODES);
       copyAttribute(span, operationSpan, SEMATTRS_HIVE_GRAPHQL_ERROR_COUNT);
+    }
+
+    if (span.name === 'graphql.execute') {
       copyAttribute(
         span,
         operationSpan,
@@ -196,3 +199,9 @@ function copyAttribute(
 ) {
   target.attributes[targetAttrName] = source.attributes[sourceAttrName];
 }
+
+const SPANS_WITH_ERRORS = [
+  'graphql.parse',
+  'graphql.validate',
+  'graphql.execute',
+];

packages/plugins/opentelemetry/tests/useOpenTelemetry.spec.ts

@@ -770,9 +770,8 @@ describe('useOpenTelemetry', () => {
         });
       });
 
-      it('should handle validation error with hive processor', async () => {
+      it.only('should handle validation error with hive processor', async () => {
         disableAll();
-        const spanExporter = new MockSpanExporter();
         const traceProvider = new BasicTracerProvider({
           spanProcessors: [
             new HiveTracingSpanProcessor({
@@ -798,9 +797,15 @@ describe('useOpenTelemetry', () => {
         });
 
         const operationSpan = spanExporter.assertRoot('graphql.operation test');
-        operationSpan.span.attributes['graphql.operation.name'] === 'test';
-        operationSpan.span.attributes['graphql.operation.type'] === 'query';
-        operationSpan.span.attributes['hive.graphql.error.count'] === 1;
+        expect(operationSpan.span.attributes['graphql.operation.name']).toBe(
+          'test',
+        );
+        expect(operationSpan.span.attributes['graphql.operation.type']).toBe(
+          'query',
+        );
+        expect(
+          operationSpan.span.attributes[SEMATTRS_HIVE_GRAPHQL_ERROR_COUNT],
+        ).toBe(1);
       });
     });