actually use nodesdk when node

Author: enisdenjo

e2e/opentelemetry/gateway.config.ts

@@ -44,8 +44,11 @@ if (process.env['DISABLE_OPENTELEMETRY_SETUP'] !== '1') {
   });
 
   // The NodeSDK only actually work in Node. For other envs, it's better to use our own configurator
-  const runner = process.env['E2E_GATEWAY_RUNNER'];
-  if (runner === 'node' || runner === 'docker') {
+  if (
+    typeof process !== 'undefined' &&
+    process.versions &&
+    process.versions.node
+  ) {
     const sdk = new NodeSDK({
       // Use spanProcessor instead of spanExporter to remove batching for test speed
       spanProcessors: [new tracing.SimpleSpanProcessor(exporter)],

e2e/opentelemetry/opentelemetry.e2e.ts

@@ -1,6 +1,6 @@
 import os from 'os';
 import { createExampleSetup, createTenv, type Container } from '@internal/e2e';
-import { isCI } from '@internal/testing';
+import { isCI, isNode } from '@internal/testing';
 import { fetch } from '@whatwg-node/fetch';
 import { beforeAll, beforeEach, describe, expect, it } from 'vitest';
 
@@ -639,7 +639,7 @@ describe('OpenTelemetry', () => {
             return expect(tags).toContainEqual({ key, value });
           });
 
-          if (gatewayRunner === 'node' || gatewayRunner === 'docker') {
+          if (isNode()) {
             const expectedTags = [
               'process.owner',
               'host.arch',
@@ -753,7 +753,7 @@ describe('OpenTelemetry', () => {
             return expect(tags).toContainEqual({ key, value });
           });
 
-          if (gatewayRunner === 'node' || gatewayRunner === 'docker') {
+          if (isNode()) {
             const expectedTags = [
               'process.owner',
               'host.arch',

internal/env/src/node.ts

@@ -18,3 +18,10 @@ export function isNotPlatform(...platforms: NodeJS.Platform[]): boolean {
   }
   return true;
 }
+
+/** Returns `true` if the runtime environment is Node.js. */
+export function isNode() {
+  return (
+    typeof process !== 'undefined' && process.versions && process.versions.node
+  );
+}