fix(no-unreachable-types): ignore directives with Request Definitions… (#1108)

* fix(no-unreachable-types): ignore directives with Request Definitions locations

* fix ts issue on graphql 15

Author: dimaMachina

.changeset/serious-chairs-compete.md

@@ -0,0 +1,5 @@
+---
+'@graphql-eslint/eslint-plugin': patch
+---
+
+fix(no-unreachable-types): ignore directives with Request Definitions locations

packages/plugin/src/rules/no-unreachable-types.ts

@@ -1,4 +1,4 @@
-import { ASTNode, ASTVisitor, GraphQLSchema, isInterfaceType, Kind, NameNode, visit } from 'graphql';
+import { ASTNode, ASTVisitor, GraphQLSchema, isInterfaceType, Kind, NameNode, visit, DirectiveLocation } from 'graphql';
 import lowerCase from 'lodash.lowercase';
 import { GraphQLESLintRule } from '../types';
 import { getTypeName, requireGraphQLSchemaFromContext } from '../utils';
@@ -26,6 +26,17 @@ type ReachableTypes = Set<string>;
 
 let reachableTypesCache: ReachableTypes;
 
+const RequestDirectiveLocations = new Set<string>([
+  DirectiveLocation.QUERY,
+  DirectiveLocation.MUTATION,
+  DirectiveLocation.SUBSCRIPTION,
+  DirectiveLocation.FIELD,
+  DirectiveLocation.FRAGMENT_DEFINITION,
+  DirectiveLocation.FRAGMENT_SPREAD,
+  DirectiveLocation.INLINE_FRAGMENT,
+  DirectiveLocation.VARIABLE_DEFINITION,
+]);
+
 function getReachableTypes(schema: GraphQLSchema): ReachableTypes {
   // We don't want cache reachableTypes on test environment
   // Otherwise reachableTypes will be same for all tests
@@ -74,6 +85,13 @@ function getReachableTypes(schema: GraphQLSchema): ReachableTypes {
       visit(type.astNode, visitor);
     }
   }
+
+  for (const node of schema.getDirectives()) {
+    if (node.locations.some(location => RequestDirectiveLocations.has(location))) {
+      reachableTypes.add(node.name);
+    }
+  }
+
   reachableTypesCache = reachableTypes;
   return reachableTypesCache;
 }

packages/plugin/tests/no-unreachable-types.spec.ts

@@ -132,6 +132,20 @@ ruleTester.runGraphQLTests('no-unreachable-types', rule, {
         directive @good on SCHEMA
       `),
     },
+    {
+      name: 'should ignore directive with request locations',
+      ...useSchema(/* GraphQL */ `
+        directive @q on QUERY
+        directive @w on MUTATION
+        directive @e on SUBSCRIPTION
+        directive @r on FIELD
+        directive @t on FRAGMENT_DEFINITION
+        directive @y on FRAGMENT_SPREAD
+        directive @u on INLINE_FRAGMENT
+        directive @i on VARIABLE_DEFINITION
+        type Query
+      `),
+    },
   ],
   invalid: [
     {