add test for known-fragment-names rule with import nested fragments + update graphql-tools/import package (#665)

Dimitri POSTOLOV · web-flow · commit 1914d6ab6c91 · 2021-11-12T17:55:11.000+01:00
* add failing test false positive case for `known-fragment-names` rule

* chore: update deps
diff --git a/.changeset/short-dolphins-brush.md b/.changeset/short-dolphins-brush.md
@@ -0,0 +1,5 @@
+---
+'@graphql-eslint/eslint-plugin': minor
+---
+
+fix false positive case in `known-fragment-names` when import nested fragment
diff --git a/examples/basic/package.json b/examples/basic/package.json
@@ -13,6 +13,6 @@
   },
   "devDependencies": {
     "@graphql-eslint/eslint-plugin": "2.4.1",
-    "eslint": "8.1.0"
+    "eslint": "8.2.0"
   }
 }
diff --git a/examples/code-file/package.json b/examples/code-file/package.json
@@ -13,6 +13,6 @@
   },
   "devDependencies": {
     "@graphql-eslint/eslint-plugin": "2.4.1",
-    "eslint": "8.1.0"
+    "eslint": "8.2.0"
   }
 }
diff --git a/examples/graphql-config-code-file/package.json b/examples/graphql-config-code-file/package.json
@@ -10,10 +10,10 @@
   },
   "dependencies": {
     "graphql": "16.0.1",
-    "graphql-tag": "^2.12.5"
+    "graphql-tag": "2.12.6"
   },
   "devDependencies": {
     "@graphql-eslint/eslint-plugin": "2.4.1",
-    "eslint": "8.1.0"
+    "eslint": "8.2.0"
   }
 }
diff --git a/examples/graphql-config/package.json b/examples/graphql-config/package.json
@@ -13,6 +13,6 @@
   },
   "devDependencies": {
     "@graphql-eslint/eslint-plugin": "2.4.1",
-    "eslint": "8.1.0"
+    "eslint": "8.2.0"
   }
 }
diff --git a/examples/prettier/package.json b/examples/prettier/package.json
@@ -13,7 +13,7 @@
   },
   "devDependencies": {
     "@graphql-eslint/eslint-plugin": "2.4.1",
-    "eslint": "8.1.0",
+    "eslint": "8.2.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-prettier": "4.0.0",
     "prettier": "2.4.1"
diff --git a/packages/plugin/package.json b/packages/plugin/package.json
@@ -27,13 +27,13 @@
   },
   "dependencies": {
     "@babel/code-frame": "7.16.0",
-    "@graphql-tools/code-file-loader": "^7.0.2",
-    "@graphql-tools/graphql-tag-pluck": "^7.0.2",
-    "@graphql-tools/import": "^6.3.1",
-    "@graphql-tools/utils": "^8.0.2",
-    "graphql-config": "^4.0.1",
+    "@graphql-tools/code-file-loader": "7.2.2",
+    "@graphql-tools/graphql-tag-pluck": "7.1.3",
+    "@graphql-tools/import": "6.6.1",
+    "@graphql-tools/utils": "8.5.3",
+    "graphql-config": "4.1.0",
     "graphql-depth-limit": "1.1.0",
-    "lodash.lowercase": "^4.3.0"
+    "lodash.lowercase": "4.3.0"
   },
   "devDependencies": {
     "@types/babel__code-frame": "7.0.3",
diff --git a/packages/plugin/tests/known-fragment-names.spec.ts b/packages/plugin/tests/known-fragment-names.spec.ts
@@ -1,10 +1,9 @@
 import { join } from 'path';
-import { GraphQLRuleTester } from '../src';
-import { GRAPHQL_JS_VALIDATIONS } from '../src/rules/graphql-js-validation';
+import { GraphQLRuleTester, rules } from '../src';
 
 const ruleTester = new GraphQLRuleTester();
 
-ruleTester.runGraphQLTests('known-fragment-names', GRAPHQL_JS_VALIDATIONS['known-fragment-names'], {
+ruleTester.runGraphQLTests('known-fragment-names', rules['known-fragment-names'], {
   valid: [
     {
       filename: join(__dirname, 'mocks/user.graphql'),
diff --git a/packages/plugin/tests/mocks/user-fields-with-nested-fragment.gql b/packages/plugin/tests/mocks/user-fields-with-nested-fragment.gql
@@ -0,0 +1,24 @@
+fragment UserFields on User {
+  ...AnotherUserFields
+  posts {
+    ...PostFields
+  }
+}
+
+fragment AnotherUserFields on User {
+  firstName
+}
+
+fragment PostFields on Post {
+  id
+  ...AnotherPostFields
+}
+
+fragment AnotherPostFields on Post {
+  title
+  ...YetAnotherPostFields
+}
+
+fragment YetAnotherPostFields on Post {
+  content
+}
diff --git a/packages/plugin/tests/mocks/user.graphql b/packages/plugin/tests/mocks/user.graphql
@@ -1,4 +1,4 @@
-#import "./user-fields.graphql"
+#import './user-fields-with-nested-fragment.gql'
 
 query User {
   user {
diff --git a/packages/plugin/tests/no-unused-fragments.spec.ts b/packages/plugin/tests/no-unused-fragments.spec.ts
@@ -7,11 +7,14 @@ const ruleTester = new GraphQLRuleTester();
 ruleTester.runGraphQLTests('no-unused-fragments', GRAPHQL_JS_VALIDATIONS['no-unused-fragments'], {
   valid: [
     {
-      filename: join(__dirname, 'mocks/user-fields.graphql'),
-      code: ruleTester.fromMockFile('user-fields.graphql'),
+      filename: join(__dirname, 'mocks/user-fields-with-nested-fragment.gql'),
+      code: ruleTester.fromMockFile('user-fields-with-nested-fragment.gql'),
       parserOptions: {
         schema: join(__dirname, 'mocks/user-schema.graphql'),
-        operations: [join(__dirname, 'mocks/user-fields.graphql'), join(__dirname, 'mocks/user.graphql')],
+        operations: [
+          join(__dirname, 'mocks/user-fields-with-nested-fragment.gql'),
+          join(__dirname, 'mocks/user.graphql'),
+        ],
       },
     },
     {
diff --git a/yarn.lock b/yarn.lock

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@graphql-eslint/eslint-plugin': minor
 +---
++
 +fix false positive case in `known-fragment-names` when import nested fragment
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@`
`13`	`13`	`},`
`14`	`14`	`"devDependencies": {`
`15`	`15`	`"@graphql-eslint/eslint-plugin": "2.4.1",`
`16`		`- "eslint": "8.1.0"`
	`16`	`+ "eslint": "8.2.0"`
`17`	`17`	`}`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,10 +10,10 @@`
`10`	`10`	`},`
`11`	`11`	`"dependencies": {`
`12`	`12`	`"graphql": "16.0.1",`
`13`		`- "graphql-tag": "^2.12.5"`
	`13`	`+ "graphql-tag": "2.12.6"`
`14`	`14`	`},`
`15`	`15`	`"devDependencies": {`
`16`	`16`	`"@graphql-eslint/eslint-plugin": "2.4.1",`
`17`		`- "eslint": "8.1.0"`
	`17`	`+ "eslint": "8.2.0"`
`18`	`18`	`}`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-#import "./user-fields.graphql"`
	`1`	`+#import './user-fields-with-nested-fragment.gql'`
`2`	`2`
`3`	`3`	`query User {`
`4`	`4`	`user {`