Skip to content

Commit 2e95055

Browse files
author
Dimitri POSTOLOV
authored
enable no-only-tests rule (#619)
1 parent 5e3c6ee commit 2e95055

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ module.exports = {
3030
'unicorn/prefer-array-some': 'error',
3131
'unicorn/prefer-includes': 'error',
3232
'eslint-plugin/test-case-shorthand-strings': 'error',
33+
'eslint-plugin/no-only-tests': 'error',
3334
'eslint-plugin/require-meta-docs-url': [
3435
'error',
3536
{ pattern: 'https://github.com/dotansimha/graphql-eslint/blob/master/docs/rules/{{name}}.md' },

packages/plugin/tests/executable-definitions.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const WITH_SCHEMA = {
2525

2626
const ruleTester = new GraphQLRuleTester();
2727

28-
ruleTester.runGraphQLTests('executable-definitions', GRAPHQL_JS_VALIDATIONS['executable-definitions'] as any, {
28+
ruleTester.runGraphQLTests('executable-definitions', GRAPHQL_JS_VALIDATIONS['executable-definitions'], {
2929
valid: [
3030
{
3131
...WITH_SCHEMA,

patches/eslint-plugin-eslint-plugin+3.5.3.patch

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
diff --git a/node_modules/eslint-plugin-eslint-plugin/lib/rules/no-only-tests.js b/node_modules/eslint-plugin-eslint-plugin/lib/rules/no-only-tests.js
2+
index 78f0c6d..f4f98b1 100644
3+
--- a/node_modules/eslint-plugin-eslint-plugin/lib/rules/no-only-tests.js
4+
+++ b/node_modules/eslint-plugin-eslint-plugin/lib/rules/no-only-tests.js
5+
@@ -30,7 +30,7 @@ module.exports = {
6+
7+
const onlyProperty = test.properties.find(
8+
property =>
9+
- property.key.type === 'Identifier' &&
10+
+ property.key?.type === 'Identifier' &&
11+
property.key.name === 'only' &&
12+
property.value.type === 'Literal' &&
13+
property.value.value
114
diff --git a/node_modules/eslint-plugin-eslint-plugin/lib/rules/require-meta-docs-url.js b/node_modules/eslint-plugin-eslint-plugin/lib/rules/require-meta-docs-url.js
215
index ed7d67a..af8ea5c 100644
316
--- a/node_modules/eslint-plugin-eslint-plugin/lib/rules/require-meta-docs-url.js

0 commit comments

Comments
 (0)