Skip to content

Commit 4419976

Browse files
authored
update VSCode integration section in readme (#1071)
1 parent 4e24c05 commit 4419976

File tree

6 files changed

+7
-22
lines changed

6 files changed

+7
-22
lines changed

.github/workflows/canary.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ jobs:
5252
path: '**/node_modules'
5353
key: ${{runner.os}}-16-16-node-modules-${{hashFiles('yarn.lock')}}
5454
restore-keys: |
55-
${{runner.os}}-16-16-node-modules-${{hashFiles('yarn.lock')}}
5655
${{runner.os}}-16-16-node-modules-
5756
5857
- name: Install Dependencies
@@ -61,7 +60,7 @@ jobs:
6160
- name: Release Canary
6261
id: canary
6362
uses: kamilkisiela/release-canary@master
64-
if: github.repository == B2o5T/graphql-eslint
63+
if: github.repository == 'B2o5T/graphql-eslint'
6564
with:
6665
npm-token: ${{secrets.NODE_AUTH_TOKEN}}
6766
npm-script: 'yarn release:canary'
@@ -76,15 +75,15 @@ jobs:
7675
```
7776
${{steps.canary.outputs.changesetsPublishedPackages}}
7877
```
79-
bot-token: ${{secrets.GH_API_TOKEN}}
8078
bot: theguild-bot
79+
bot-token: ${{secrets.GH_API_TOKEN}}
8180
github-token: ${{secrets.GITHUB_TOKEN}}
8281

8382
- name: Publish an empty message
8483
if: steps.canary.outputs.released == 'false'
8584
uses: kamilkisiela/pr-comment@master
8685
with:
87-
message: The latest changes of this PR are not available as alpha, since there are no linked `changesets` for this PR.
88-
bot-token: ${{secrets.GH_API_TOKEN}}
8986
bot: theguild-bot
87+
bot-token: ${{secrets.GH_API_TOKEN}}
9088
github-token: ${{secrets.GITHUB_TOKEN}}
89+
message: The latest changes of this PR are not available as alpha, since there are no linked `changesets` for this PR.

.github/workflows/release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242
path: '**/node_modules'
4343
key: ${{runner.os}}-16-16-node-modules-${{hashFiles('yarn.lock')}}
4444
restore-keys: |
45-
${{runner.os}}-16-16-node-modules-${{hashFiles('yarn.lock')}}
4645
${{runner.os}}-16-16-node-modules-
4746
4847
- name: Install Dependencies

.github/workflows/tests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ jobs:
2727
path: '**/node_modules'
2828
key: ${{runner.os}}-16-16-node-modules-${{hashFiles('yarn.lock')}}
2929
restore-keys: |
30-
${{runner.os}}-16-16-node-modules-${{hashFiles('yarn.lock')}}
3130
${{runner.os}}-16-16-node-modules-
3231
3332
- name: Install Dependencies
@@ -60,7 +59,6 @@ jobs:
6059
path: '**/node_modules'
6160
key: ${{runner.os}}-16-${{matrix.graphql_version}}-node-modules-${{hashFiles('yarn.lock')}}
6261
restore-keys: |
63-
${{runner.os}}-16-${{matrix.graphql_version}}-node-modules-${{hashFiles('yarn.lock')}}
6462
${{runner.os}}-16-${{matrix.graphql_version}}-node-modules-
6563
6664
- name: Use GraphQL v${{matrix.graphql_version}}
@@ -105,7 +103,6 @@ jobs:
105103
path: '**/node_modules'
106104
key: ${{runner.os}}-${{matrix.node_version}}-${{matrix.graphql_version}}-node-modules-${{hashFiles('yarn.lock')}}
107105
restore-keys: |
108-
${{runner.os}}-${{matrix.node_version}}-${{matrix.graphql_version}}-node-modules-${{hashFiles('yarn.lock')}}
109106
${{runner.os}}-${{matrix.node_version}}-${{matrix.graphql_version}}-node-modules-
110107
111108
- name: Use GraphQL v${{matrix.graphql_version}}
@@ -120,7 +117,6 @@ jobs:
120117
path: .cache/jest
121118
key: ${{runner.os}}-${{matrix.node_version}}-jest-${{hashFiles('yarn.lock')}}
122119
restore-keys: |
123-
${{runner.os}}-${{matrix.node_version}}-jest-${{hashFiles('yarn.lock')}}
124120
${{runner.os}}-${{matrix.node_version}}-jest-
125121
126122
# We need build for examples.spec.ts test

.vscode/settings.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,5 @@
1616
"mode": "auto",
1717
"changeProcessCWD": true
1818
}
19-
],
20-
"eslint.validate": ["javascript", "javascriptreact", "typescript", "typescriptreact", "graphql"]
19+
]
2120
}

README.md

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -147,17 +147,9 @@ To provide that, we are using `graphql-tools` loaders to load your sibling opera
147147

148148
### VSCode Integration
149149

150-
By default, [ESLint VSCode plugin](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) will not lint files with extensions other than `js`, `jsx`, `ts` and `tsx`.
150+
Use [ESLint VSCode extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint) to integrate ESLint into VSCode.
151151

152-
In order to enable it processing other extensions, add the following section in `settings.json` or workspace configuration.
153-
154-
```json
155-
{
156-
"eslint.validate": ["javascript", "javascriptreact", "typescript", "typescriptreact", "graphql"]
157-
}
158-
```
159-
160-
Currently, you also need a GraphQL IDE extension for syntax highlighting installed (which may potentially have its own linting) - for example [GraphQL (by GraphQL Foundation)](https://marketplace.visualstudio.com/items?itemName=GraphQL.vscode-graphql).
152+
For syntax highlighting you need a GraphQL extension (which may potentially have its own linting), for example [GraphQL (by GraphQL Foundation)](https://marketplace.visualstudio.com/items?itemName=GraphQL.vscode-graphql).
161153

162154
### Disabling Rules
163155

File renamed without changes.

0 commit comments

Comments
 (0)