chore: remove unique-enum-value-names rule from recommended config (#800)

Author: Dimitri POSTOLOV

.changeset/two-drinks-build.md

@@ -0,0 +1,5 @@
+---
+'@graphql-eslint/eslint-plugin': patch
+---
+
+chore: remove `unique-enum-value-names` rule from recommended config

docs/README.md

@@ -2,8 +2,6 @@
 
 ✅ The `"extends": "plugin:@graphql-eslint/schema-recommended"` property in a configuration file enables this rule.
 
-🔧 The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#--fix) can automatically fix some of the problems reported by this rule.
-
 - Category: `Schema`
 - Rule name: `@graphql-eslint/no-case-insensitive-enum-values-duplicates`
 - Requires GraphQL Schema: `false` [ℹ️](../../README.md#extended-linting-rules-with-graphql-schema)
@@ -40,3 +38,4 @@ enum MyEnum {
 ## Resources
 
 - [Rule source](../../packages/plugin/src/rules/no-case-insensitive-enum-values-duplicates.ts)
+- [Test source](../../packages/plugin/tests/no-case-insensitive-enum-values-duplicates.spec.ts)

docs/rules/no-case-insensitive-enum-values-duplicates.md

@@ -1,7 +1,5 @@
 # `unique-enum-value-names`
 
-✅ The `"extends": "plugin:@graphql-eslint/schema-recommended"` property in a configuration file enables this rule.
-
 - Category: `Schema`
 - Rule name: `@graphql-eslint/unique-enum-value-names`
 - Requires GraphQL Schema: `false` [ℹ️](../../README.md#extended-linting-rules-with-graphql-schema)

docs/rules/unique-enum-value-names.md

@@ -14,10 +14,7 @@ export default {
       },
     ],
     '@graphql-eslint/input-name': 'error',
-    '@graphql-eslint/no-root-type': 'off',
     '@graphql-eslint/no-scalar-result-type-on-mutation': 'error',
-    '@graphql-eslint/no-unused-fields': 'off',
-    '@graphql-eslint/possible-type-extension': 'off',
     '@graphql-eslint/require-deprecation-date': 'error',
     '@graphql-eslint/require-field-of-type-query-in-mutation-result': 'error',
   },

packages/plugin/src/configs/schema-all.ts

@@ -43,7 +43,6 @@ export default {
     '@graphql-eslint/strict-id-in-types': 'error',
     '@graphql-eslint/unique-directive-names': 'error',
     '@graphql-eslint/unique-directive-names-per-location': 'error',
-    '@graphql-eslint/unique-enum-value-names': 'error',
     '@graphql-eslint/unique-field-definition-names': 'error',
     '@graphql-eslint/unique-operation-types': 'error',
     '@graphql-eslint/unique-type-names': 'error',

packages/plugin/src/configs/schema-recommended.ts

@@ -327,6 +327,7 @@ export const GRAPHQL_JS_VALIDATIONS = Object.assign(
     category: 'Schema',
     description: `A GraphQL enum type is only valid if all its values are uniquely named.`,
     requiresSchema: false,
+    recommended: false,
   }),
   validationToRule('unique-field-definition-names', 'UniqueFieldDefinitionNames', {
     category: 'Schema',

packages/plugin/src/rules/graphql-js-validation.ts

@@ -1,13 +1,13 @@
+import { EnumTypeDefinitionNode, EnumTypeExtensionNode, Kind } from 'graphql';
+import { GraphQLESTreeNode } from '../estree-parser';
 import { GraphQLESLintRule } from '../types';
-
-const ERROR_MESSAGE_ID = 'NO_CASE_INSENSITIVE_ENUM_VALUES_DUPLICATES';
+import { getLocation } from '../utils';
 
 const rule: GraphQLESLintRule = {
   meta: {
     type: 'suggestion',
     docs: {
-      url:
-        'https://github.com/dotansimha/graphql-eslint/blob/master/docs/rules/no-case-insensitive-enum-values-duplicates.md',
+      url: `https://github.com/dotansimha/graphql-eslint/blob/master/docs/rules/no-case-insensitive-enum-values-duplicates.md`,
       category: 'Schema',
       recommended: true,
       description: 'Disallow case-insensitive enum values duplicates.',
@@ -34,27 +34,21 @@ const rule: GraphQLESLintRule = {
         },
       ],
     },
-    fixable: 'code',
-    messages: {
-      [ERROR_MESSAGE_ID]: `Case-insensitive enum values duplicates are not allowed! Found: "{{ found }}"`,
-    },
     schema: [],
   },
   create(context) {
+    const selector = [Kind.ENUM_TYPE_DEFINITION, Kind.ENUM_TYPE_EXTENSION].join(',');
     return {
-      EnumTypeDefinition(node) {
-        const foundDuplicates = node.values.filter(
-          (item, index) =>
-            node.values.findIndex(v => v.name.value.toLowerCase() === item.name.value.toLowerCase()) !== index
+      [selector](node: GraphQLESTreeNode<EnumTypeDefinitionNode | EnumTypeExtensionNode>) {
+        const duplicates = node.values.filter(
+          (item, index, array) =>
+            array.findIndex(v => v.name.value.toLowerCase() === item.name.value.toLowerCase()) !== index
         );
-
-        for (const dup of foundDuplicates) {
+        for (const duplicate of duplicates) {
+          const enumName = duplicate.name.value;
           context.report({
-            node: dup.name,
-            data: {
-              found: dup.name.value,
-            },
-            messageId: ERROR_MESSAGE_ID,
+            loc: getLocation(duplicate.loc, enumName),
+            message: `Case-insensitive enum values duplicates are not allowed! Found: "${enumName}"`,
           });
         }
       },

packages/plugin/src/rules/no-case-insensitive-enum-values-duplicates.ts

@@ -0,0 +1,11 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[` 1`] = `
+> 1 | enum A { TEST TesT }
+    |               ^^^^ Case-insensitive enum values duplicates are not allowed! Found: "TesT"
+`;
+
+exports[` 2`] = `
+> 1 | extend enum A { TEST TesT }
+    |                      ^^^^ Case-insensitive enum values duplicates are not allowed! Found: "TesT"
+`;

packages/plugin/tests/__snapshots__/no-case-insensitive-enum-values-duplicates.spec.ts.snap

@@ -0,0 +1,18 @@
+import { GraphQLRuleTester } from '../src';
+import rule from '../src/rules/no-case-insensitive-enum-values-duplicates';
+
+const ruleTester = new GraphQLRuleTester();
+
+ruleTester.runGraphQLTests('no-case-insensitive-enum-values-duplicates', rule, {
+  valid: [],
+  invalid: [
+    {
+      code: 'enum A { TEST TesT }',
+      errors: [{ message: 'Case-insensitive enum values duplicates are not allowed! Found: "TesT"' }],
+    },
+    {
+      code: 'extend enum A { TEST TesT }',
+      errors: [{ message: 'Case-insensitive enum values duplicates are not allowed! Found: "TesT"' }],
+    },
+  ],
+});