chore(deps): update dependency typescript to v4.2.4 (#332)

* chore(deps): update dependency typescript to v4.2.4

* fix ts issues

* types fixes

* fixes

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Dotan Simha <[email protected]>

Author: 3 people

package.json

@@ -46,7 +46,7 @@
     "@types/jest": "26.0.23",
     "ts-jest": "26.5.6",
     "rimraf": "3.0.2",
-    "typescript": "4.1.5",
+    "typescript": "4.2.4",
     "jest": "26.6.3"
   },
   "resolutions": {

packages/plugin/package.json

@@ -32,7 +32,7 @@
     "bob-the-bundler": "1.2.0",
     "graphql-config": "3.2.0",
     "graphql": "15.5.0",
-    "typescript": "4.1.5"
+    "typescript": "4.2.4"
   },
   "peerDependencies": {
     "graphql": "^0.8.0 || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0 || ^15.0.0"

packages/plugin/src/rules/graphql-js-validation.ts

@@ -56,160 +56,161 @@ const validationToRule = (
   };
 };
 
-export const GRAPHQL_JS_VALIDATIONS: Record<string, GraphQLESLintRule> = {
-  ...validationToRule('executable-definitions', 'ExecutableDefinitions', {
+export const GRAPHQL_JS_VALIDATIONS = Object.assign(
+  {},
+  validationToRule('executable-definitions', 'ExecutableDefinitions', {
     docs: {
       description: `A GraphQL document is only valid for execution if all definitions are either operation or fragment definitions.`,
     },
   }),
-  ...validationToRule('fields-on-correct-type', 'FieldsOnCorrectType', {
+  validationToRule('fields-on-correct-type', 'FieldsOnCorrectType', {
     docs: {
       description: `A GraphQL document is only valid if all fields selected are defined by the parent type, or are an allowed meta field such as __typename.`,
     },
   }),
-  ...validationToRule('fragments-on-composite-type', 'FragmentsOnCompositeTypes', {
+  validationToRule('fragments-on-composite-type', 'FragmentsOnCompositeTypes', {
     docs: {
       description: `Fragments use a type condition to determine if they apply, since fragments can only be spread into a composite type (object, interface, or union), the type condition must also be a composite type.`,
     },
   }),
-  ...validationToRule('known-argument-names', 'KnownArgumentNames', {
+  validationToRule('known-argument-names', 'KnownArgumentNames', {
     docs: {
       description: `A GraphQL field is only valid if all supplied arguments are defined by that field.`,
     },
   }),
-  ...validationToRule('known-directives', 'KnownDirectives', {
+  validationToRule('known-directives', 'KnownDirectives', {
     docs: {
       description: `A GraphQL document is only valid if all \`@directives\` are known by the schema and legally positioned.`,
     },
   }),
-  ...validationToRule('known-fragment-names', 'KnownFragmentNames', {
+  validationToRule('known-fragment-names', 'KnownFragmentNames', {
     docs: {
       description: `A GraphQL document is only valid if all \`...Fragment\` fragment spreads refer to fragments defined in the same document.`,
     },
   }),
-  ...validationToRule('known-type-names', 'KnownTypeNames', {
+  validationToRule('known-type-names', 'KnownTypeNames', {
     docs: {
       description: `A GraphQL document is only valid if referenced types (specifically variable definitions and fragment conditions) are defined by the type schema.`,
     },
   }),
-  ...validationToRule('lone-anonymous-operation', 'LoneAnonymousOperation', {
+  validationToRule('lone-anonymous-operation', 'LoneAnonymousOperation', {
     docs: {
       description: `A GraphQL document is only valid if when it contains an anonymous operation (the query short-hand) that it contains only that one operation definition.`,
     },
   }),
-  ...validationToRule('lone-schema-definition', 'LoneSchemaDefinition', {
+  validationToRule('lone-schema-definition', 'LoneSchemaDefinition', {
     docs: {
       description: `A GraphQL document is only valid if it contains only one schema definition.`,
     },
   }),
-  ...validationToRule('no-fragment-cycles', 'NoFragmentCycles', {
+  validationToRule('no-fragment-cycles', 'NoFragmentCycles', {
     docs: {
       description: `A GraphQL fragment is only valid when it does not have cycles in fragments usage.`,
     },
   }),
-  ...validationToRule('no-undefined-variables', 'NoUndefinedVariables', {
+  validationToRule('no-undefined-variables', 'NoUndefinedVariables', {
     docs: {
       description: `A GraphQL operation is only valid if all variables encountered, both directly and via fragment spreads, are defined by that operation.`,
     },
   }),
-  ...validationToRule('no-unused-fragments', 'NoUnusedFragments', {
+  validationToRule('no-unused-fragments', 'NoUnusedFragments', {
     docs: {
       description: `A GraphQL document is only valid if all fragment definitions are spread within operations, or spread within other fragments spread within operations.`,
     },
   }),
-  ...validationToRule('no-unused-variables', 'NoUnusedVariables', {
+  validationToRule('no-unused-variables', 'NoUnusedVariables', {
     docs: {
       description: `A GraphQL operation is only valid if all variables defined by an operation are used, either directly or within a spread fragment.`,
     },
   }),
-  ...validationToRule('overlapping-fields-can-be-merged', 'OverlappingFieldsCanBeMerged', {
+  validationToRule('overlapping-fields-can-be-merged', 'OverlappingFieldsCanBeMerged', {
     docs: {
       description: `A selection set is only valid if all fields (including spreading any fragments) either correspond to distinct response names or can be merged without ambiguity.`,
     },
   }),
-  ...validationToRule('possible-fragment-spread', 'PossibleFragmentSpreads', {
+  validationToRule('possible-fragment-spread', 'PossibleFragmentSpreads', {
     docs: {
       description: `A fragment spread is only valid if the type condition could ever possibly be true: if there is a non-empty intersection of the possible parent types, and possible types which pass the type condition.`,
     },
   }),
-  ...validationToRule('possible-type-extension', 'PossibleTypeExtensions', {
+  validationToRule('possible-type-extension', 'PossibleTypeExtensions', {
     docs: {
       description: `A type extension is only valid if the type is defined and has the same kind.`,
     },
   }),
-  ...validationToRule('provided-required-arguments', 'ProvidedRequiredArguments', {
+  validationToRule('provided-required-arguments', 'ProvidedRequiredArguments', {
     docs: {
       description: `A field or directive is only valid if all required (non-null without a default value) field arguments have been provided.`,
     },
   }),
-  ...validationToRule('scalar-leafs', 'ScalarLeafs', {
+  validationToRule('scalar-leafs', 'ScalarLeafs', {
     docs: {
       description: `A GraphQL document is valid only if all leaf fields (fields without sub selections) are of scalar or enum types.`,
     },
   }),
-  ...validationToRule('one-field-subscriptions', 'SingleFieldSubscriptions', {
+  validationToRule('one-field-subscriptions', 'SingleFieldSubscriptions', {
     docs: {
       description: `A GraphQL subscription is valid only if it contains a single root field.`,
     },
   }),
-  ...validationToRule('unique-argument-names', 'UniqueArgumentNames', {
+  validationToRule('unique-argument-names', 'UniqueArgumentNames', {
     docs: {
       description: `A GraphQL field or directive is only valid if all supplied arguments are uniquely named.`,
     },
   }),
-  ...validationToRule('unique-directive-names', 'UniqueDirectiveNames', {
+  validationToRule('unique-directive-names', 'UniqueDirectiveNames', {
     docs: {
       description: `A GraphQL document is only valid if all defined directives have unique names.`,
     },
   }),
-  ...validationToRule('unique-directive-names-per-location', 'UniqueDirectivesPerLocation', {
+  validationToRule('unique-directive-names-per-location', 'UniqueDirectivesPerLocation', {
     docs: {
       description: `A GraphQL document is only valid if all non-repeatable directives at a given location are uniquely named.`,
     },
   }),
-  ...validationToRule('unique-enum-value-names', 'UniqueEnumValueNames', {
+  validationToRule('unique-enum-value-names', 'UniqueEnumValueNames', {
     docs: {
       description: `A GraphQL enum type is only valid if all its values are uniquely named.`,
     },
   }),
-  ...validationToRule('unique-field-definition-names', 'UniqueFieldDefinitionNames', {
+  validationToRule('unique-field-definition-names', 'UniqueFieldDefinitionNames', {
     docs: {
       description: `A GraphQL complex type is only valid if all its fields are uniquely named.`,
     },
   }),
-  ...validationToRule('unique-input-field-names', 'UniqueInputFieldNames', {
+  validationToRule('unique-input-field-names', 'UniqueInputFieldNames', {
     docs: {
       description: `A GraphQL input object value is only valid if all supplied fields are uniquely named.`,
     },
   }),
-  ...validationToRule('unique-operation-types', 'UniqueOperationTypes', {
+  validationToRule('unique-operation-types', 'UniqueOperationTypes', {
     docs: {
       description: `A GraphQL document is only valid if it has only one type per operation.`,
     },
   }),
-  ...validationToRule('unique-type-names', 'UniqueTypeNames', {
+  validationToRule('unique-type-names', 'UniqueTypeNames', {
     docs: {
       description: `A GraphQL document is only valid if all defined types have unique names.`,
     },
   }),
-  ...validationToRule('unique-variable-names', 'UniqueVariableNames', {
+  validationToRule('unique-variable-names', 'UniqueVariableNames', {
     docs: {
       description: `A GraphQL operation is only valid if all its variables are uniquely named.`,
     },
   }),
-  ...validationToRule('value-literals-of-correct-type', 'ValuesOfCorrectType', {
+  validationToRule('value-literals-of-correct-type', 'ValuesOfCorrectType', {
     docs: {
       description: `A GraphQL document is only valid if all value literals are of the type expected at their position.`,
     },
   }),
-  ...validationToRule('variables-are-input-types', 'VariablesAreInputTypes', {
+  validationToRule('variables-are-input-types', 'VariablesAreInputTypes', {
     docs: {
       description: `A GraphQL operation is only valid if all the variables it defines are of input types (scalar, enum, or input object).`,
     },
   }),
-  ...validationToRule('variables-in-allowed-position', 'VariablesInAllowedPosition', {
+  validationToRule('variables-in-allowed-position', 'VariablesInAllowedPosition', {
     docs: {
       description: `Variables passed to field arguments conform to type.`,
     },
-  }),
-};
+  })
+) as Record<string, GraphQLESLintRule>;

packages/plugin/src/rules/index.ts

@@ -17,10 +17,9 @@ import noHashtagDescription from './no-hashtag-description';
 import selectionSetDepth from './selection-set-depth';
 import avoidDuplicateFields from './avoid-duplicate-fields';
 import strictIdInTypes from './strict-id-in-types';
-import { GraphQLESLintRule } from '../types';
 import { GRAPHQL_JS_VALIDATIONS } from './graphql-js-validation';
 
-export const rules: Record<string, GraphQLESLintRule> = {
+export const rules = {
   'no-unreachable-types': noUnreachableTypes,
   'no-deprecated': noDeprecated,
   'unique-fragment-name': uniqueFragmentName,

packages/plugin/src/rules/naming-convention.ts

@@ -87,7 +87,7 @@ const schemaOption = {
   oneOf: [{ $ref: '#/definitions/asString' }, { $ref: '#/definitions/asObject' }],
 };
 
-interface PropertySchema {
+export interface PropertySchema {
   style?: ValidNaming;
   suffix?: string;
   prefix?: string;

packages/plugin/src/rules/strict-id-in-types.ts

@@ -2,7 +2,7 @@ import { Kind, ObjectTypeDefinitionNode } from 'graphql';
 import { GraphQLESTreeNode } from '../estree-parser';
 import { GraphQLESLintRule } from '../types';
 
-interface ExceptionRule {
+export interface ExceptionRule {
   types?: string[];
   suffixes?: string[];
 }

packages/plugin/src/testkit.ts

@@ -37,7 +37,7 @@ export class GraphQLRuleTester extends require('eslint').RuleTester {
 
   runGraphQLTests<Config>(
     name: string,
-    rule: GraphQLESLintRule<Config>,
+    rule: any,
     tests: {
       valid?: Array<string | GraphQLValidTestCase<Config>>;
       invalid?: Array<string | GraphQLInvalidTestCase<Config>>;

packages/plugin/tests/executable-definitions.spec.ts

@@ -25,7 +25,7 @@ const WITH_SCHEMA = {
 
 const ruleTester = new GraphQLRuleTester();
 
-ruleTester.runGraphQLTests('executable-definitions', GRAPHQL_JS_VALIDATIONS['executable-definitions'], {
+ruleTester.runGraphQLTests('executable-definitions', GRAPHQL_JS_VALIDATIONS['executable-definitions'] as any, {
   valid: [
     {
       ...WITH_SCHEMA,

yarn.lock

@@ -6590,6 +6590,11 @@ [email protected]:
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.1.5.tgz#123a3b214aaff3be32926f0d8f1f6e704eb89a72"
   integrity sha512-6OSu9PTIzmn9TCDiovULTnET6BgXtDYL4Gg4szY+cGsc3JP1dQL8qvE8kShTRx1NIw4Q9IBHlwODjkjWEtMUyA==
 
+[email protected]:
+  version "4.2.4"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.2.4.tgz#8610b59747de028fda898a8aef0e103f156d0961"
+  integrity sha512-V+evlYHZnQkaz8TRBuxTA92yZBPotr5H+WhQ7bD3hZUndx5tGOa1fuCgeSjxAzM1RiN5IzvadIXTVefuuwZCRg==
+
 unbox-primitive@^1.0.0:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/unbox-primitive/-/unbox-primitive-1.0.1.tgz#085e215625ec3162574dc8859abee78a59b14471"