Reenable running require-id-when-available on FragmentDefinition (#2711)

* aa

* aa

Author: dimaMachina

.changeset/neat-cows-worry.md

@@ -0,0 +1,5 @@
+---
+'@graphql-eslint/eslint-plugin': patch
+---
+
+Reenable running `require-id-when-available` on `FragmentDefinition`

packages/plugin/src/rules/require-selections/index.test.ts

@@ -89,23 +89,6 @@ const DOCUMENT_WITH_UNION = /* GraphQL */ `
 
 ruleTester.run<RuleOptions, true>('require-selections', rule, {
   valid: [
-    {
-      name: 'should completely ignore FragmentDefinition',
-      code: /* GraphQL */ `
-        fragment UserFields on User {
-          name
-          posts {
-            title
-          }
-        }
-      `,
-      parserOptions: {
-        graphQLConfig: {
-          schema: USER_POST_SCHEMA,
-          documents: '{ foo }',
-        },
-      },
-    },
     {
       name: "should ignore checking selections on OperationDefinition as it's redundant check",
       code: '{ foo }',
@@ -500,5 +483,23 @@ ruleTester.run<RuleOptions, true>('require-selections', rule, {
         },
       },
     },
+    {
+      name: 'should not ignore FragmentDefinition',
+      code: /* GraphQL */ `
+        fragment UserFields on User {
+          name
+          posts {
+            title
+          }
+        }
+      `,
+      parserOptions: {
+        graphQLConfig: {
+          schema: USER_POST_SCHEMA,
+          documents: '{ foo }',
+        },
+      },
+      errors: 2,
+    },
   ],
 });

packages/plugin/src/rules/require-selections/index.ts

@@ -118,8 +118,7 @@ export const rule: GraphQLESLintRule<RuleOptions, true> = {
 
     // Check selections only in OperationDefinition,
     // skip selections of OperationDefinition and InlineFragment
-    const selector =
-      'OperationDefinition SelectionSet[parent.kind!=/(^OperationDefinition|InlineFragment)$/]';
+    const selector = 'SelectionSet[parent.kind!=/(^OperationDefinition|InlineFragment)$/]';
     const typeInfo = new TypeInfo(schema);
 
     function checkFragments(node: GraphQLESTreeNode<SelectionSetNode>): void {

packages/plugin/src/rules/require-selections/snapshot.md

@@ -38,6 +38,50 @@ exports[`require-selections > invalid > Invalid #2 1`] = `
     1 | { hasId { name id } }
 `;
 
+exports[`require-selections > invalid > should not ignore FragmentDefinition 1`] = `
+#### ⌨️ Code
+
+      1 |         fragment UserFields on User {
+      2 |           name
+      3 |           posts {
+      4 |             title
+      5 |           }
+      6 |         }
+
+#### ❌ Error 1/2
+
+    > 1 |         fragment UserFields on User {
+        |                                     ^ Field \`UserFields.id\` must be selected when it's available on a type.
+    Include it in your selection set.
+      2 |           name
+
+#### 💡 Suggestion: Add \`id\` selection
+
+    1 |         fragment UserFields on User {
+    2 |           id name
+    3 |           posts {
+    4 |             title
+    5 |           }
+    6 |         }
+
+#### ❌ Error 2/2
+
+      2 |           name
+    > 3 |           posts {
+        |                 ^ Field \`posts.id\` must be selected when it's available on a type.
+    Include it in your selection set.
+      4 |             title
+
+#### 💡 Suggestion: Add \`id\` selection
+
+    1 |         fragment UserFields on User {
+    2 |           name
+    3 |           posts {
+    4 |             id title
+    5 |           }
+    6 |         }
+`;
+
 exports[`require-selections > invalid > should not work with n nested fragments if you never get the id 1`] = `
 #### ⌨️ Code