Support aliases in require-id-when-available (#1019)

* feat: support aliases in require-id-when-available

Fixes #1017

* add changeset

Co-authored-by: Dimitri POSTOLOV <[email protected]>

Author: grubersjoe

.changeset/dirty-rules-sin.md

@@ -0,0 +1,5 @@
+---
+'@graphql-eslint/eslint-plugin': patch
+---
+
+feat: support select `id` field with an alias in `require-id-when-available` rule

docs/rules/require-id-when-available.md

@@ -50,6 +50,13 @@ query {
     name
   }
 }
+
+# Selecting `id` with an alias is also valid
+query {
+  user {
+    id: name
+  }
+}
 ```
 
 ## Config Schema

packages/plugin/src/rules/require-id-when-available.ts

@@ -70,6 +70,13 @@ const rule: GraphQLESLintRule<[RequireIdWhenAvailableRuleConfig], true> = {
                 name
               }
             }
+
+            # Selecting \`id\` with an alias is also valid
+            query {
+              user {
+                id: name
+              }
+            }
           `,
         },
       ],
@@ -164,6 +171,10 @@ const rule: GraphQLESLintRule<[RequireIdWhenAvailableRuleConfig], true> = {
       function hasIdField({ selections }: typeof node): boolean {
         return selections.some(selection => {
           if (selection.kind === Kind.FIELD) {
+            if (selection.alias && idNames.includes(selection.alias.value)) {
+              return true;
+            }
+
             return idNames.includes(selection.name.value);
           }
 

packages/plugin/tests/require-id-when-available.spec.ts

@@ -273,6 +273,7 @@ ruleTester.runGraphQLTests<[RequireIdWhenAvailableRuleConfig], true>('require-id
         `,
       },
     },
+    {name: 'should work when `id` is selected by an alias', ...WITH_SCHEMA, code: '{ hasId {  id: name } }' },
   ],
   invalid: [
     {