fixes

dotansimha · dotansimha · commit f6c5355b9776 · 2020-09-30T21:11:29.000+03:00
diff --git a/README.md b/README.md
@@ -2,12 +2,12 @@ This project integrates GraphQL AST parser and ESLint.
 
 ## Key Features:
 
-🚀 Integrates with ESLint core (as a ESTree parser).
-🚀 Works on `.graphql` files, `gql` usages and `/* GraphQL */` magic comments.
-🚀 Lints both GraphQL schema and GraphQL operations.
-🚀 Extended type info for more advanced usages
-🚀 Supports ESLint directives (for example: `disable-next-line`)
-🚀 Easily extendable - supports custom rules.
+- 🚀 Integrates with ESLint core (as a ESTree parser).
+- 🚀 Works on `.graphql` files, `gql` usages and `/* GraphQL */` magic comments.
+- 🚀 Lints both GraphQL schema and GraphQL operations.
+- 🚀 Extended type info for more advanced usages
+- 🚀 Supports ESLint directives (for example: `disable-next-line`)
+- 🚀 Easily extendable - supports custom rules.
 
 Special thanks to [ilyavolodin](https://github.com/ilyavolodin) for his work on a similar project!
 
@@ -101,6 +101,6 @@ In order to enable it processing other extensions, add the following section in
 
 ## Available Rules
 
-You can find a complete list of [all available plugins here](./RULES.md)
+You can find a complete list of [all available plugins here](./docs/README.md)
 
 > This repo doesn't exports a "recommended" set of rules - feel free to recommend us!
diff --git a/RULES.md b/RULES.md
diff --git a/docs/README.md b/docs/README.md
@@ -0,0 +1,14 @@
+## Available Rules
+
+- [`avoid-operation-name-prefix`](./avoid-operation-name-prefix.md)
+- [`input-name`](./input-name.md)
+- [`description-style`](./description-style.md)
+- [`naming-convention`](./naming-convention.md)
+- [`no-anonymous-operations`](./no-anonymous-operations.md)
+- [`require-deprecation-reason`](./require-deprecation-reason.md)
+- [`no-case-insensitive-enum-values-duplicates`](./no-case-insensitive-enum-values-duplicates.md)
+- [`no-operation-name-suffix`](./no-operation-name-suffix.md)
+- [`require-id-when-available`](./require-id-when-available.md)
+- [`validate-against-schema`](./validate-against-schema.md)
+- [`prettier`](./prettier.md)
+- [`require-description`](./require-description.md)
diff --git a/docs/rules/avoid-operation-name-prefix.md b/docs/rules/avoid-operation-name-prefix.md
@@ -0,0 +1,32 @@
+## Avoid Prefix in GraphQL operation name
+
+- Name: `avoid-operation-name-prefix`
+- Requires GraphQL Schema: `false`
+
+Allow you to enforce and avoid operation name prefix, useful if you wish to avoid prefix in your root fields,like `getSomething`.
+
+### Usage Example
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/avoid-operation-name-prefix: ["error", { keywords: "get" }]
+
+query getUserDetails {
+  # ...
+}
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/avoid-operation-name-prefix: ["error", { keywords: "get" }]
+
+query userDetails {
+  # ...
+}
+```
+
+### Configuration
+
+- `keywords`: array of prefixes you with to avoid in operation names.
diff --git a/docs/rules/description-style.md b/docs/rules/description-style.md
@@ -0,0 +1,38 @@
+# Enforce style of the description comments
+
+- Name: `description-style`
+- Requires GraphQL Schema: `false`
+
+Following the same style for description comments in your code will make them easier to read.
+
+## Rule Details
+
+This rule enforces same style for all description comments in your code. This rule has one option: `style` that can be set to either `block` or `inline` (default).
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/description-style: ["error", { style: "inline" }]
+
+""" Description """
+type someTypeName {
+    ...
+}
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/description-style: ["error", { style: "inline" }]
+
+" Description "
+type SomeTypeName {
+  someFieldName: String
+}
+```
+
+## Options
+
+This rule accepts configuration object with one option:
+
+- `style: 'block'|'inline'` - Will require all comments to be either in block style (`"""`) or inline style (`"`)
diff --git a/docs/rules/input-name.md b/docs/rules/input-name.md
@@ -0,0 +1,42 @@
+# Enforce names of input parameters and input types
+
+- Name: `input-name`
+- Requires GraphQL Schema: `false`
+
+Using the same name for all input parameters will make your schemas easier to consume and more predictable. Using the same name as mutation for InputType will make it easier to find mutations that InputType belongs to.
+
+## Rule Details
+
+This rule enforces all input parameters to be named `input`, and all InputTypes to use the name of the mutation + `'Input'`.
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/input-name: ["error", { checkInputType: true }]
+
+type Mutation {
+  SetMessage(message: InputMessage): String
+}
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/input-name: ["error", { checkInputType: true }]
+
+type Mutation {
+  SetMessage(input: SetMessageInput): String
+}
+```
+
+```graphql
+# eslint @graphql-eslint/input-name: ["error", { checkInputType: false }]
+
+type Mutation {
+  SetMessage(input: AnyInputTypeName): String
+}
+```
+
+## Configuration
+
+This rule accepts one option `checkInputType`. If `true` (default) it will verify that the name of the input type matches name of the mutation + 'Input'. If `false` it will not check InputType name.
diff --git a/docs/rules/naming-convention.md b/docs/rules/naming-convention.md
@@ -0,0 +1,43 @@
+# Enforce naming conventions patterns in your typeDefs
+
+- Name: `naming-convention`
+- Requires GraphQL Schema: `false`
+
+Following the same naming conventions in all your type definitions will make them easier to read and more predictable.
+
+## Rule Details
+
+This rule enforces naming conventions patterns for your type definitions. It can control if the names should be in PascalCase, camelCase, snake_case or UPPER_CASE. It can also allow or disallow trailing and leading underscores.
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/naming-convention: ["error", { ObjectTypeDefinition: "PascalCase" }]
+
+type someTypeName {
+    ...
+}
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/naming-convention: ["error", { FieldDefinition: "camelCase", ObjectTypeDefinition: "PascalCase" }]
+
+type SomeTypeName {
+  someFieldName: String
+}
+```
+
+## Options
+
+This rule accepts configuration object with multiple options:
+
+- `ObjectTypeDefinition: 'PascalCase'|'camelCase'|'snake_case'|'UPPER_CASE'` - Will affect names of types, input objects, enums and interfaces
+- `FieldDefinition: 'PascalCase'|'camelCase'|'snake_case'|'UPPER_CASE'` - Will affect names of type fields
+- `EnumValueDefinition: 'PascalCase'|'camelCase'|'snake_case'|'UPPER_CASE'` - Will affect names of enumeration values
+- `InputValueDefinition: 'PascalCase'|'camelCase'|'snake_case'|'UPPER_CASE'` - Will affect names of input properties
+- `FragmentDefinition: 'PascalCase'|'camelCase'|'snake_case'|'UPPER_CASE'` - Will affect names of fragments
+- `ScalarTypeDefinition: 'PascalCase'|'camelCase'|'snake_case'|'UPPER_CASE'` - Will affect names of scalars
+- `leadingUnderscore: 'allow'|'forbid'` - Will allow or forbid leading underscores in all names. Default value is `forbid`.
+- `trailingUnderscore: 'allow'|'forbid'` - Will allow of forbid trailing underscores in all names. Default value is `forbid`.
diff --git a/docs/rules/no-anonymous-operations.md b/docs/rules/no-anonymous-operations.md
@@ -0,0 +1,28 @@
+## Avoid Anonymous GraphQL operations
+
+- Name: `no-anonymous-operations`
+- Requires GraphQL Schema: `false`
+
+Allow you to require name for your GraphQL operations. This is useful since most GraphQL client libraries are using the operation name for caching purposes.
+
+### Usage Example
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/no-anonymous-operations: ["error"]
+
+query {
+  # ...
+}
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/no-anonymous-operations: ["error"]
+
+query something {
+  # ...
+}
+```
diff --git a/docs/rules/no-case-insensitive-enum-values-duplicates.md b/docs/rules/no-case-insensitive-enum-values-duplicates.md
@@ -0,0 +1,32 @@
+## Avoid Duplicates In Enum Values
+
+- Name: `no-case-insensitive-enum-values-duplicates`
+- Requires GraphQL Schema: `false`
+
+Checks enums values for duplicate values defined (case-insensitive).
+
+### Usage Example
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/no-case-insensitive-enum-values-duplicates: ["error"]
+
+enum MyEnum {
+  Value
+  VALUE
+  ValuE
+}
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/no-case-insensitive-enum-values-duplicates: ["error"]
+
+enum MyEnum {
+  Value1
+  Value2
+  Value3
+}
+```
diff --git a/docs/rules/no-operation-name-suffix.md b/docs/rules/no-operation-name-suffix.md
@@ -0,0 +1,28 @@
+## No Operation Name Suffix
+
+- Name: `no-operation-name-suffix`
+- Requires GraphQL Schema: `false`
+
+Makes sure you are not adding the operation type to the name of the operation.
+
+### Usage Example
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/no-operation-name-suffix: ["error"]
+
+query userQuery {
+  # ...
+}
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/no-operation-name-suffix: ["error"]
+
+query user {
+  # ...
+}
+```
diff --git a/docs/rules/prettier.md b/docs/rules/prettier.md
@@ -0,0 +1,12 @@
+# Enforces styling consistency in your type definitions
+
+- Name: `prettier`
+- Requires GraphQL Schema: `false`
+
+Having all your code follow the same styling guidelines makes it easier to read and understand the code
+
+## Rule Details
+
+This rule is a copy of the rule in [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) adjusted to work for GraphQL.
+
+Please see [documentation](https://github.com/prettier/eslint-plugin-prettier#options) for available options and configurations.
diff --git a/docs/rules/require-deprecation-reason.md b/docs/rules/require-deprecation-reason.md
@@ -0,0 +1,35 @@
+# Require all deprecation directives to specify a reason
+
+- Name: `require-deprecation-reason`
+- Requires GraphQL Schema: `false`
+
+Deprecation reason will document your decisions for others.
+
+# Rule Details
+
+This rule will require all `@deprecated` directives to specify deprecation reason
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/require-deprecation-reason: "error"
+...
+  name: String @deprecated
+...
+```
+
+```graphql
+# eslint @graphql-eslint/require-deprecation-reason: "error"
+...
+  name: String @deprecated(reason: "")
+...
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/require-deprecation-reason: "error"
+...
+  name: String @depecated(reason: "Removing in 2 releases. Use fullname instead")
+...
+```
diff --git a/docs/rules/require-description.md b/docs/rules/require-description.md
@@ -0,0 +1,53 @@
+# Enforce descriptions in your type definitions
+
+- Name: `require-description`
+- Requires GraphQL Schema: `false`
+
+Because documentation for GraphQL schemas are usually auto-generated omitting descriptions will not provide any information about types in your schema. It's considered best practice to provide descriptions for all your type definitions.
+
+## Rule Details
+
+This rule requires descriptions to be present in your type definitions files.
+
+Examples of **incorrect** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/require-description: ["error", { on: ["ObjectTypeDefinition", "FieldDefinition" }]
+
+type someTypeName {
+  name: String
+}
+```
+
+Examples of **correct** code for this rule:
+
+```graphql
+# eslint @graphql-eslint/require-description: ["error", { on: ["ObjectTypeDefinition", "FieldDefinition" }]
+
+"""
+Some type description
+"""
+type someTypeName {
+  """
+  Name description
+  """
+  name: String
+}
+```
+
+## Configuration
+
+By default, this rules doesn't enforce description on any type of AST node.
+
+This rule accepts an configuration key called `on`, with an array strings. The values are all possible AST nodes that has `description` field available:
+
+- `SchemaDefinition`
+- `ObjectTypeDefinition`
+- `FieldDefinition`
+- `InputValueDefinition`
+- `InterfaceTypeDefinition`
+- `UnionTypeDefinition`
+- `EnumTypeDefinition`
+- `EnumValueDefinition`
+- `InputObjectTypeDefinition`
+- `DirectiveDefinition`
diff --git a/docs/rules/require-id-when-available.md b/docs/rules/require-id-when-available.md
diff --git a/docs/rules/validate-against-schema.md b/docs/rules/validate-against-schema.md
diff --git a/packages/plugin/src/rules/index.ts b/packages/plugin/src/rules/index.ts
diff --git a/packages/plugin/src/rules/require-deprecation-reason.ts b/packages/plugin/src/rules/require-deprecation-reason.ts
